From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7F65740466 for ; Sun, 24 Jul 2022 11:05:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 62D9C68B761; Sun, 24 Jul 2022 14:05:13 +0300 (EEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ED55068B1F1 for ; Sun, 24 Jul 2022 14:05:06 +0300 (EEST) Received: by mail-wr1-f46.google.com with SMTP id g2so4121472wru.3 for ; Sun, 24 Jul 2022 04:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=rWGpqwhklDzc++iw2ZBek9tkiHqIuzluMoUPF7x03L8=; b=JtFKV2DC5j6jt/Nv6WToo0XCjFelX5Emw897O2Eok98kgQPETxO5pudk5QbOHWYwlS Fy9NePoWGDi5UUnfLLg7DSl5HicijwU8qnEb6PhX2gqHv2aaSYCxW2etyKnMfVu/6nNy NHQtSi59EAmSWk8mhzYXv7jW4uKBnII7pwKWDA/ZMU2cIAMteIDw8ZzHQf7F92/uiAD9 Iu29NZXlWMjvz4loU7g1x8jo9nLs0sVh9b6xJO9dGA1FOtqgLQupJa+DoQvZvINq4sXG Zo8sHI1XWU3byScPLnYYq4UPN9Q9hOFkyCINoTNm5J5ENRPy3yVBDG0n/BNR7ZiJ4Xxp nb1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=rWGpqwhklDzc++iw2ZBek9tkiHqIuzluMoUPF7x03L8=; b=1OZaFH4FhTJ4Wrl+2UKK2FXkKldsRT6YfO0yHYjTrcs8eUmNctNjVRjn5B4D/U5s6/ Jpv729Aoj3CvDH4K8AUHf3QQnL8TFT16zCRYaP5QzMIPhZWKuapWA0ut+EEa2i4NtGel IfNJ8Yjp/dFDHl+DbPe+ZnodkV3G1JPwbrUSeLdk2j6+vrvdeOpT/5ZmcN/yTSUEJuBl PpLUR82lQK076QOUHX19PAO7ZrG6rahiV2UrEIwXjzMHorFpKbHViU7nAhup8sYFziqE bPJz9jGumXlGUwhRn8THKJYmp9gL8RANrn6f9Qbs3Rm76EAS0niNQS/UMwzmJ5YyTLI5 iFcg== X-Gm-Message-State: AJIora8hik7eiv+wnJuPHrw8cWLYtOYdLHNROitl0lBrl84kmYAC+LST kmQnX6Z6/Q9mrtPZeU4fK33MmJx4Oqv+1KTD3kz+3wYIh7Q= X-Google-Smtp-Source: AGRyM1v42ujNHaOe8OXiUfw05DVJo4mMj65qmCSKn2QRaUrjqNb9IMIYBSLMrZSucDE2TqAmLXvwkU4AZj0pmbp0VPA= X-Received: by 2002:a05:6000:154a:b0:21d:b74d:3561 with SMTP id 10-20020a056000154a00b0021db74d3561mr4871980wry.584.1658660706289; Sun, 24 Jul 2022 04:05:06 -0700 (PDT) MIME-Version: 1.0 References: <20220724101149.50584-1-epirat07@gmail.com> In-Reply-To: <20220724101149.50584-1-epirat07@gmail.com> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Sun, 24 Jul 2022 14:04:53 +0300 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] configure: properly require libx264 if enabled X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, Jul 24, 2022 at 1:12 PM Marvin Scholz wrote: > > When libx264 can not be found even though it is enabled, it should error > out properly instead of silently disabling it. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 46f6490a64..6629d14099 100755 > --- a/configure > +++ b/configure > @@ -6673,7 +6673,7 @@ enabled libvpx && { > enabled libwebp && { > enabled libwebp_encoder && require_pkg_config libwebp "libwebp >= 0.2.0" webp/encode.h WebPGetEncoderVersion > enabled libwebp_anim_encoder && check_pkg_config libwebp_anim_encoder "libwebpmux >= 0.4.0" webp/mux.h WebPAnimEncoderOptionsInit; } > -enabled libx264 && check_pkg_config libx264 x264 "stdint.h x264.h" x264_encoder_encode && > +enabled libx264 && require_pkg_config libx264 x264 "stdint.h x264.h" x264_encoder_encode && Looking at the commit message in dd5a0302d5286e66ca03a57770537d5afa4c7775 , support for non-pkg-config usage was removed then, so require_pkg_config (which dies if the check doesn't succeed) seems like the correct option to utilize. LGTM Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".