From: "Jan Ekström" <jeebjp@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: use larger of bit rate and max rate for buffer size
Date: Mon, 13 Mar 2023 11:57:17 +0200
Message-ID: <CAEu79Sa5Naf8nZ=tLNnPjngEYWXJWR-h8b0fSmhzmOuKY-eTyw@mail.gmail.com> (raw)
In-Reply-To: <20230309185735.93571-1-jeebjp@gmail.com>
On Thu, Mar 9, 2023 at 8:57 PM Jan Ekström <jeebjp@gmail.com> wrote:
>
> Generally if maxrate is set, the calculation should be maxrate over
> bufsize. This additionally enables CRF + maxrate & bufsize usage.
>
> In order to keep negative values from enabling zero to be treated
> as larger and causing a division by zero, check that one of the
> variables is larger than zero.
> ---
> libavcodec/libsvtav1.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
The idea and patch was OK'd by Christopher from SVT-AV1 and James
noted that it seemed OK on IRC.
Thus will be pulling this in in the evening unless there are concerns raised.
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-13 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 18:57 Jan Ekström
2023-03-13 9:57 ` Jan Ekström [this message]
2023-03-13 22:19 ` Jan Ekström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEu79Sa5Naf8nZ=tLNnPjngEYWXJWR-h8b0fSmhzmOuKY-eTyw@mail.gmail.com' \
--to=jeebjp@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git