Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: use larger of bit rate and max rate for buffer size

From: "Jan Ekström" <jeebjp@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: use larger of bit rate and max rate for buffer size
Date: Tue, 14 Mar 2023 00:19:01 +0200
Message-ID: <CAEu79Sa3+f9hc-OTx9e6yqGQd7jC-nopwhOa5Vh1ue09bTXMZw@mail.gmail.com> (raw)
In-Reply-To: <CAEu79Sa5Naf8nZ=tLNnPjngEYWXJWR-h8b0fSmhzmOuKY-eTyw@mail.gmail.com>

On Mon, Mar 13, 2023 at 11:57 AM Jan Ekström <jeebjp@gmail.com> wrote:
>
> On Thu, Mar 9, 2023 at 8:57 PM Jan Ekström <jeebjp@gmail.com> wrote:
> >
> > Generally if maxrate is set, the calculation should be maxrate over
> > bufsize. This additionally enables CRF + maxrate & bufsize usage.
> >
> > In order to keep negative values from enabling zero to be treated
> > as larger and causing a division by zero, check that one of the
> > variables is larger than zero.
> > ---
> >  libavcodec/libsvtav1.c | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
>
> The idea and patch was OK'd by Christopher from SVT-AV1 and James
> noted that it seemed OK on IRC.
>
> Thus will be pulling this in in the evening unless there are concerns raised.

Applied as fba9d9609fe00c8c4d04b76f9ecdd274aad318dd .

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".