From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 97FEF42396 for ; Sun, 15 May 2022 18:41:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA6D668B45C; Sun, 15 May 2022 21:41:37 +0300 (EEST) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3934168B1F6 for ; Sun, 15 May 2022 21:41:30 +0300 (EEST) Received: by mail-lj1-f182.google.com with SMTP id 16so15768258lju.13 for ; Sun, 15 May 2022 11:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=iZACGSwUdhM6zIAG3hq6hupmOKSfsB4LAaraNqLO8hs=; b=YokZfk8EsEt/Gq/Gnm908M1k+/scG7MF2ISWwqq97fgmWT8n+0vnCnsV4TrVxDs+Zb hZkB6ecqnrPG06oHPkp680yDxMlRsl6wkMx1MxJKIp4Vx6FW/vaY4bdlOY4g8q3jFgCB NLmM+fo7CIvBLuslh/LSJlJFhwliEzQJiqoKwCRu1xFY7K5btOXQt/S8fYLQdRmG1SWp J7Mvf3jpa591OhHMtj6cy43rynjeUz+d9XTTsfNldjK7jSK2yFxQSbVwxKdKL11mGGhQ taxnyr1tQQ+dMVewlSjnch3rrwAhF99QtBkiAMnyDqN77KE29Ym8QqNxQ+x/6lOwg/29 +JiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=iZACGSwUdhM6zIAG3hq6hupmOKSfsB4LAaraNqLO8hs=; b=I7ctmw+pKPKAmgTpxD2iN4HEn3z866VHdD4YzTOl6f6v9+zRcoWhLsQ41X+IFBCloQ gEuouta6ParikpHJ+6zVxcTE4C2bvIkeyPetZVW8HeNweWC0aEtYTbbjSL3BsV1/rffK 0AoAfVN2YhQiBBKUxWhZEqkc79hhQWrp2NpQreXHp3uYzmuII8cr8Uavc6ikyiO79E41 EeUP1D3sNoA2rLK58Kd500Vv3mGMwpK3XpxbO1zoJEbKdbZ1fRtTo7wMYAn6LZ98BSm5 frJJE1xTYenaCUQAYFCBTe8+7l0UvzUUw4OEKmJ/JuzxvQsGgzywMUbp7FI/NGTvpY/Q 3/KA== X-Gm-Message-State: AOAM532mGs1THJp2UpKQhP+hnG3+iWwTPWPMaUuP0p5JukCF4fdYriAv lCfMU8/sIjHVTz6jWwH70Lx6dBylmTfYJ2rtVspKARzt X-Google-Smtp-Source: ABdhPJyJM1fTgObIoEC2nncJmUpVEpsW2SS6WdreXzKuoE35KccymZ4iF3TUB74eztfXVCbNSi2uZ2dFjGvA7UTJnLk= X-Received: by 2002:a05:651c:12c7:b0:23e:b8f9:15b2 with SMTP id 7-20020a05651c12c700b0023eb8f915b2mr9297305lje.382.1652640089419; Sun, 15 May 2022 11:41:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Sun, 15 May 2022 21:41:18 +0300 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls, dashdec: Don't use AV_OPT_FLAG_* in av_dict_set() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, May 15, 2022 at 8:57 PM Andreas Rheinhardt wrote: > > av_dict_set() expects a different set of flags, namely the AV_DICT_* > flags. Using AV_OPT_FLAG_DECODING_PARAM (or any AV_OPT_FLAG_*) ic > av_dict_set() is therefore completely wrong and given that av_dict_set() > just doesn't care about whether the string it receives has anything > to do with a decoding parameter or not, it should just be removed > without replacement. > (The numerical value of AV_OPT_FLAG_DECODING_PARAM currently coincides > with AV_DICT_IGNORE_SUFFIX. Given that the dictionaries we are dealing > with here are always empty (i.e. NULL) before the calls to > av_dict_set(), this flag changes nothing. It would be different if > it were equal to one of the AV_DICT_DONT_STRDUP_* values.) LGTM as far as the patch contents go. Well noticed. For commit message I think we utilize do not utilize capital letters after the "prefix: ". This can be changed as you apply the patch :) . Personally I would have worded it a la "don't use AV_OPT flags with av_dict_set()", but this is just a preference and you are free to ignore this bit. Cheers, Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".