From: "Jan Ekström" <jeebjp@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 11/12] avcodec/libx264: add support for writing out CLL and MDCV
Date: Sun, 20 Aug 2023 01:25:27 +0300
Message-ID: <CAEu79SZW9_BvJDKxiK-9J0=b0vCZEG9uBjcZyfJbKg0TyQzH7A@mail.gmail.com> (raw)
In-Reply-To: <20230819165327.GA7802@pb2>
On Sat, Aug 19, 2023 at 7:53 PM Michael Niedermayer
<michael@niedermayer.cc> wrote:
>
> On Fri, Aug 18, 2023 at 12:48:49AM +0300, Jan Ekström wrote:
> > Both of these two structures were first available with X264_BUILD
> > 163, so make relevant functionality conditional on the version
> > being at least such.
> >
> > Keep handle_side_data available in all cases as this way X264_init
> > does not require additional version based conditions within it.
> >
> > Finally, add a FATE test which verifies that pass-through of the
> > MDCV/CLL side data is working during encoding.
> > ---
> > libavcodec/libx264.c | 79 ++++++++++++++++++++++++++++++++++++
> > tests/fate/enc_external.mak | 5 +++
> > tests/ref/fate/libx264-hdr10 | 15 +++++++
> > 3 files changed, 99 insertions(+)
> > create mode 100644 tests/ref/fate/libx264-hdr10
>
> fate fails with X264_BUILD 152
>
> The filters 'Parsed_null_0' and 'format' do not have a common format and automatic conversion is disabled.
> [vf#0:0 @ 0x55eddf8d4780] Error reinitializing filters!
> Failed to inject frame into filter network: Invalid argument
> Error while filtering: Invalid argument
> [out#0/mp4 @ 0x55eddf87b980] Nothing was written into output file, because at least one of its streams received no packets.
> frame= 0 fps=0.0 q=0.0 Lsize= 0kB time=N/A bitrate=N/A speed=N/A
> Conversion failed!
> threads=1
> tests/Makefile:307: recipe for target 'fate-libx264-hdr10' failed
> make: *** [fate-libx264-hdr10] Error 234
>
Without having more information, that sounds more like a 8bit only
build rather than an X264_BUILD related issue, as the error seems to
come from a conversion from the input 10bit content to whatever not
being available.
Can you check if that is the case?
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-08-19 22:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 21:48 [FFmpeg-devel] [PATCH v3 00/12] encoder AVCodecContext configuration side data Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 01/12] avutil/frame: add AVFrameSideDataSet for passing sets of " Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 02/12] avutil/frame: split side data list wiping out to non-AVFrame function Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 03/12] avutil/frame: add helper for uninitializing side data sets Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 04/12] avutil/frame: split side_data_from_buf to base and AVFrame func Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 05/12] avutil/frame: add helper for adding side data to set Jan Ekström
2023-08-18 4:52 ` Andreas Rheinhardt
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 06/12] avutil/frame: add helper for getting side data from set Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 07/12] avutil/frame: add helper for extending a set of side data Jan Ekström
2023-08-20 9:45 ` Andreas Rheinhardt
2023-08-28 20:30 ` Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 08/12] avcodec: add side data set to AVCodecContext Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 09/12] ffmpeg: pass first video AVFrame's side data to encoder Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 10/12] avcodec/libsvtav1: add support for writing out CLL and MDCV Jan Ekström
2023-08-20 7:11 ` Andreas Rheinhardt
2023-08-21 21:38 ` Jan Ekström
2023-08-21 22:00 ` Andreas Rheinhardt
2023-08-22 21:49 ` Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 11/12] avcodec/libx264: " Jan Ekström
2023-08-19 16:53 ` Michael Niedermayer
2023-08-19 22:25 ` Jan Ekström [this message]
2023-08-20 6:32 ` Andreas Rheinhardt
2023-08-20 13:12 ` Michael Niedermayer
2023-08-21 19:31 ` Jan Ekström
2023-08-21 19:50 ` Andreas Rheinhardt
2023-08-22 13:19 ` Vittorio Giovara
2023-08-22 17:45 ` Andreas Rheinhardt
2023-08-20 6:55 ` Andreas Rheinhardt
2023-08-21 20:31 ` Jan Ekström
2023-08-17 21:48 ` [FFmpeg-devel] [PATCH v3 12/12] avcodec/libx265: " Jan Ekström
2023-08-20 7:04 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEu79SZW9_BvJDKxiK-9J0=b0vCZEG9uBjcZyfJbKg0TyQzH7A@mail.gmail.com' \
--to=jeebjp@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git