From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 655D344C07 for ; Fri, 13 Jan 2023 14:38:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2BDB768B6B1; Fri, 13 Jan 2023 16:38:44 +0200 (EET) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7CA7D68B0A7 for ; Fri, 13 Jan 2023 16:38:37 +0200 (EET) Received: by mail-wr1-f45.google.com with SMTP id t5so16857809wrq.1 for ; Fri, 13 Jan 2023 06:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=WXyBv7YzMG05elzKXg5gkqkN/9CsLy/+HKUdhGutmTI=; b=coPiFMIpqLnQ60gkk7iQo4zu7s/oKLXQDA09d6T15Q5cUWDb0CMD1bJ0kBUKDptoxP usD/aKtSycVLKg+P6FqGOHsEeA1dPrcH91HjgRlsd8jM0rt5Ej9GTnFnSc8N9fficsaD aT5fI2EHN47Im7nL9keaxPARtzbBh0VvhDI0BjDSe7aq20W6OqsOH8R/ano7qt8Gb5xl iA9/7jyv9PJVhGFgf2AfFr8r0RfG7gSXBJOUUy0wuAxOVyBlU3+dT2wSIP+QAzV2lHr1 zAwKlvrFk2SAEpNDDxj5GU2MOT3Eyy8QHh15R30bV2BQN5V2J8siaN+yXDs7b0mHHns4 4ctA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WXyBv7YzMG05elzKXg5gkqkN/9CsLy/+HKUdhGutmTI=; b=DgpCaAo8Q0M0mfAAAbVno1CtN1ADMxAxCLybZxmpSHxOM+Ycx2GRQ2RnfbX7UU4orv 1yk000swm0Coz/A6jOnuGqs+JRHm5S/NgD+eflWdfvELfhLk6YcVcjJmETP2dTMecXDi I+jcfOI/ITgxZXdpNIPMmRWlAuBz/VqsFteh4FRS9qflFfL4mzi7IpUkzFqvYOq7H4CS hAzC1uxVjb+KJmUo5vGdNF7VqwsmXpWbrkCFGwuzIB0HBGhpJswHHdlCttrk7upg033l HZsy1NFOdcNf0bW69ravqMwDyJFVXl5ojWLPB76LhF3jrLbuXVXlFFcjUUiw3w1XJUbf kCSw== X-Gm-Message-State: AFqh2kqWC6jMNaCJYhclIgi7AibROLlMs0Cw7c2/pHjgQWrxQMPPHfIh RoAfsNC7W8iUzZ0emBIavIB6iawkC+Z2QXACWkZ+duZY X-Google-Smtp-Source: AMrXdXv6bAH5BrN+bJhnejUyni7ApCXR7Lh24hA9lniKH7oXFb+BdxMaWhJ0MyM4Yd8//oD7HH76aR0wVN98B6L6iFA= X-Received: by 2002:adf:aa83:0:b0:2bd:d339:e2b6 with SMTP id h3-20020adfaa83000000b002bdd339e2b6mr289907wrc.584.1673620716815; Fri, 13 Jan 2023 06:38:36 -0800 (PST) MIME-Version: 1.0 References: <20230111193102.38416-1-jamrial@gmail.com> In-Reply-To: <20230111193102.38416-1-jamrial@gmail.com> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Fri, 13 Jan 2023 16:38:24 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_showinfo: use av_frame_side_data_name() to print side data names X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Jan 11, 2023 at 9:31 PM James Almer wrote: > > This ensures all defined types are supported, even if only to report > their presence and print their size if a custom implementation is > not added. > > Signed-off-by: James Almer > --- > This patch supersedes: > [PATCH 1/2] avfilter/vf_showinfo: remove superfluous line break > [PATCH 2/2] avfilter/vf_showinfo: add support for raw Dolby Vision RPU side data > > By achieving the same effect in a future proof, generic way. > I quite like this approach, and agree with the idea. It did feel weird that we have a single location which sets human readable names for side data types, yet it was not utilized. I think the only drawback is that I'm pretty sure there would be some side data types printed out now with a different name, and I do know that some people parse the output of this filter instead of utilizing ffprobe. Granted, we generally don't promise that log lines are a machine readable interface. Thus this is not a blocker, but something to keep in mind. I wonder if at some point (at the latest when we'll start wanting to make a generic string/dict based side data setting interface) we'll want to have separately a "long name" (more human readable) as well as a shorter identifier similar to AVCodecs' "name". Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".