Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Jan Ekström" <jeebjp@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/utvideoenc: Don't advertise unsupported option
Date: Fri, 16 May 2025 21:02:05 +0300
Message-ID: <CAEu79SYv7z1evdHYiutTrSSXByvo8OVOEWet97JsXu-K5RufLA@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB074400C7E987821E042F41588F93A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

On Fri, May 16, 2025 at 5:19 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Patch attached.
>

LGTM.

Seems like as part of moving prediction method from codec context to
private options in 2862b63783b5556f7f3fb2d097629bc6879f833a the
gradient value was kept as an alternative, even though even then it
was just being checked against.

If the value was not in the middle in UtVideo, I would note that it
may have made sense to just drop any references or checking for this
value from utvideoenc, but alas I don't think that's possible?

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-05-16 18:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 14:19 Andreas Rheinhardt
2025-05-16 18:02 ` Jan Ekström [this message]
2025-05-16 20:02   ` Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEu79SYv7z1evdHYiutTrSSXByvo8OVOEWet97JsXu-K5RufLA@mail.gmail.com \
    --to=jeebjp@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git