[FFmpeg-devel] [PATCH] configure: Fix typo

[FFmpeg-devel] [PATCH] configure: Fix typo

[Xiang, Haihao]

From: Haihao Xiang <haihao.xiang@intel.com>

Otherwise there are link errors:
LD      ffprobe_g
/usr/bin/ld: libavcodec/libavcodec.so: undefined reference to
`ff_dovi_rpu_generate'
/usr/bin/ld: libavcodec/libavcodec.so: undefined reference to
`ff_dovi_configure'
collect2: error: ld returned 1 exit status

Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index b101ed9256..02711bf930 100755
--- a/configure
+++ b/configure
@@ -3534,7 +3534,7 @@ libspeex_decoder_deps="libspeex"
 libspeex_encoder_deps="libspeex"
 libspeex_encoder_select="audio_frame_queue"
 libsvtav1_encoder_deps="libsvtav1"
-libsvtav1_encoder_select="dovi_rpueenc"
+libsvtav1_encoder_select="dovi_rpuenc"
 libtheora_encoder_deps="libtheora"
 libtwolame_encoder_deps="libtwolame"
 libuavs3d_decoder_deps="libuavs3d"
@@ -3554,7 +3554,7 @@ libx264_encoder_select="atsc_a53 golomb"
 libx264rgb_encoder_deps="libx264"
 libx264rgb_encoder_select="libx264_encoder"
 libx265_encoder_deps="libx265"
-libx265_encoder_select="atsc_a53 dovi_rpueenc"
+libx265_encoder_select="atsc_a53 dovi_rpuenc"
 libxavs_encoder_deps="libxavs"
 libxavs2_encoder_deps="libxavs2"
 libxevd_decoder_deps="libxevd"
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: Fix typo

[Eoff, Ullysses A]

> 
> From: Haihao Xiang <haihao.xiang@intel.com>
> 
> Otherwise there are link errors:
> LD      ffprobe_g
> /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to
> `ff_dovi_rpu_generate'
> /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to
> `ff_dovi_configure'
> collect2: error: ld returned 1 exit status
> 
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index b101ed9256..02711bf930 100755
> --- a/configure
> +++ b/configure
> @@ -3534,7 +3534,7 @@ libspeex_decoder_deps="libspeex"
>  libspeex_encoder_deps="libspeex"
>  libspeex_encoder_select="audio_frame_queue"
>  libsvtav1_encoder_deps="libsvtav1"
> -libsvtav1_encoder_select="dovi_rpueenc"
> +libsvtav1_encoder_select="dovi_rpuenc"
>  libtheora_encoder_deps="libtheora"
>  libtwolame_encoder_deps="libtwolame"
>  libuavs3d_decoder_deps="libuavs3d"
> @@ -3554,7 +3554,7 @@ libx264_encoder_select="atsc_a53 golomb"
>  libx264rgb_encoder_deps="libx264"
>  libx264rgb_encoder_select="libx264_encoder"
>  libx265_encoder_deps="libx265"
> -libx265_encoder_select="atsc_a53 dovi_rpueenc"
> +libx265_encoder_select="atsc_a53 dovi_rpuenc"
>  libxavs_encoder_deps="libxavs"
>  libxavs2_encoder_deps="libxavs2"
>  libxevd_decoder_deps="libxevd"
> --

LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: Fix typo

[Jan Ekström]

On Mon, Apr 22, 2024 at 3:34 PM Xiang, Haihao
<haihao.xiang-at-intel.com@ffmpeg.org> wrote:
>
> From: Haihao Xiang <haihao.xiang@intel.com>
>
> Otherwise there are link errors:
> LD      ffprobe_g
> /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to
> `ff_dovi_rpu_generate'
> /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to
> `ff_dovi_configure'
> collect2: error: ld returned 1 exit status
>
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---

LGTM, and thanks for catching this quickly. The commit message could
be adjusted to something like "configure: fix rpuenc typos" or so (I
don't think the post-prefix text is generally considered as a
sentence, and might as well mention the thing that is being typo'd).

In any case, feel free to apply as soon as you are able to, as
currently libsvtav1 and libx265 wrappers do not link properly :) .

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".