From: "Jan Ekström" <jeebjp@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] configure: Fix typo
Date: Mon, 22 Apr 2024 23:13:30 +0300
Message-ID: <CAEu79SYkum=czhDSRFHr4s8VK5jT4+vi=pdULNeULkOdDMcDYg@mail.gmail.com> (raw)
In-Reply-To: <20240422123414.151024-1-haihao.xiang@intel.com>
On Mon, Apr 22, 2024 at 3:34 PM Xiang, Haihao
<haihao.xiang-at-intel.com@ffmpeg.org> wrote:
>
> From: Haihao Xiang <haihao.xiang@intel.com>
>
> Otherwise there are link errors:
> LD ffprobe_g
> /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to
> `ff_dovi_rpu_generate'
> /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to
> `ff_dovi_configure'
> collect2: error: ld returned 1 exit status
>
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
LGTM, and thanks for catching this quickly. The commit message could
be adjusted to something like "configure: fix rpuenc typos" or so (I
don't think the post-prefix text is generally considered as a
sentence, and might as well mention the thing that is being typo'd).
In any case, feel free to apply as soon as you are able to, as
currently libsvtav1 and libx265 wrappers do not link properly :) .
Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-04-22 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 12:34 Xiang, Haihao
2024-04-22 18:08 ` Eoff, Ullysses A
2024-04-22 20:13 ` Jan Ekström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEu79SYkum=czhDSRFHr4s8VK5jT4+vi=pdULNeULkOdDMcDYg@mail.gmail.com' \
--to=jeebjp@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git