From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B100B42B14 for ; Fri, 14 Oct 2022 13:20:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B879868BDA6; Fri, 14 Oct 2022 16:20:10 +0300 (EEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A9C9768BBBC for ; Fri, 14 Oct 2022 16:20:03 +0300 (EEST) Received: by mail-wm1-f54.google.com with SMTP id t4so3041106wmj.5 for ; Fri, 14 Oct 2022 06:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=E2l+I4VzSXq7w0r32QDyT5piJeBSOKCAQrLLy3RWwDk=; b=nKy4uvUABAuaKa09GXaMxkPHO7lDnAI4nmPJRyARPVmAoz3JD69y35fLUP9/PXwd9X J3jKF1XffT7jkFQW1Xt9eoih8lEwFag0/l7yx2clkU5kBbCIPNocbo16d+KQm4OberQq RrNKE8fX8WZOMSX0/8yAgI7MTjUAnv9i30Jbjq0Omek2wef3nKfffdHUUD6fTYBh9ozr E+XmnN88yofTJYMf8uYHkKD+cSlg+dLegCv1OcAeVagrtF5GGWsIJCkdipyAWlD/B5zp WZ/2zMSCVItOGwjM22Fe4q8LgzaX/oJXhX9fsj3m2fHW81mdtVMffYwVINMRtrp245H9 UdOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E2l+I4VzSXq7w0r32QDyT5piJeBSOKCAQrLLy3RWwDk=; b=DG++HfQWY7vv88fOIGJ58D6DCwDxZJXR+m2dxcI2Lt/vxsYbOkRzliLDHcpTGoNZCH vHi9ohybJJChjUuQ0JbB1N/pDID4SOD9oUPljCnRGOAa4f24ACVON0Hs6TB2/U31rtBZ UHl9c5hq3rqW49jT37sfavTaSs075hHrD7pe+ynUO7fW0uhlBOMwgKvCNhVEJpzdMGeO I7yxuY7iJ8VqYKoRTrta/qpiz5+VwBDFTL+HOm7NCNt4/vH2ykaSx0a/YDvzZLK84Hqe TG+at0VJCcwz6tbBkqPQdJ/GOgSZc2lbCTZZlAgqKVnHAoUmskOb+1HcAhqUrUX+iH/N peUw== X-Gm-Message-State: ACrzQf0MsZK5JM3r9XsKkEpERaKp1zMwOEwkYq1TCYBneAZkwPBKEUKp ntUYqIKfctqXfibnCWuJzGCfUJm+nwa68W+xDMjz8Yt1 X-Google-Smtp-Source: AMsMyM5AJBxXNxo41eaTlXdF9QlkEhQ2oNFNEK4e1Q4ZsS2V80LFoEP+AB8iylaDpixXx3/rjpwvig84SsXotcuBjMw= X-Received: by 2002:a05:600c:510e:b0:3b4:fed8:e65c with SMTP id o14-20020a05600c510e00b003b4fed8e65cmr3499066wms.93.1665753602976; Fri, 14 Oct 2022 06:20:02 -0700 (PDT) MIME-Version: 1.0 References: <20220927044056.2154-1-ffmpeg@gyani.pro> In-Reply-To: <20220927044056.2154-1-ffmpeg@gyani.pro> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Fri, 14 Oct 2022 16:19:50 +0300 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg: fix implementation of updated input start time X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Sep 27, 2022 at 7:41 AM Gyan Doshi wrote: > > The current adjustment of input start times just adjusts the tsoffset. > And it does so, by resetting the tsoffset to nullify the new start time. > This leads to breakage of -copyts, ignoring of user_ts_offset, breaking > of -isync as well as breaking wrap correction. > > Fixed by taking cognizance of these parameters, and by correcting start > times just before sync offsets are applied. Out of interest and sorry for not testing this myself: does this improve the current state of affairs with itsoffset with discontinuous inputs like MPEG-TS? Until now the offset was put together with a whole bunch of other things, which led to logic which was supposed to only start the input at PTS=0 to also take out the configured itsoffset at the same time (since both the user defined offset as well as the format start time offset were both chunked into the same thing). Cheers, Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".