From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 92AD343751 for ; Mon, 27 Jun 2022 07:04:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 03B9368B8AC; Mon, 27 Jun 2022 10:04:15 +0300 (EEST) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4816F68B6A2 for ; Mon, 27 Jun 2022 10:04:08 +0300 (EEST) Received: by mail-wr1-f45.google.com with SMTP id o4so7647403wrh.3 for ; Mon, 27 Jun 2022 00:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=6/MBvnaX+k0qmRYHseVEFWIq1WgZbmtMHDKjwvt8mL0=; b=VltFev2Mw4dP6nOTsfXKPJ2BUCf1ehVr3r5vJb9mQuKmJJ8vJBmVYXgfSNrSZ84yMM l+AAHxKt5oZUquhelSxGDa8CBcRNXxGT+n+7ivMfTnyDiRIGSNUZzeclIRNu5VlQ3BnX r4lEoySsQaGesy0RJ0xOm6kjjfvG0BNLdhrC4ccZgnNaV6F+JzFZF4dB3f+rI+JjY0Vy zVzVysMjiP/VZ8wknje2NL0g81gSZOmbV/o6tBYQkB0YjLzyqhF1oa+kgPTo4u2/tXHB VvNzaTkwcD0Jx92TgQrC+ecJI1DMEIhDmq40Wp9Kd6Fdb8S49CgFPrfPxZw/Phztwx1D 2aWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6/MBvnaX+k0qmRYHseVEFWIq1WgZbmtMHDKjwvt8mL0=; b=CrAYGFUgHct2mTv/J1OA1SjNmEQTElpgTneC/ACgitccxHuOLjQYRfCYCh9y2iAmXB dkwegZjYjOXAKlJ9CLBXwvExuw+tYEyRbM7o9lSle/Pa/HlXvXNzfaa6UZvVEDcaM5Bx lqVFc2RQS5ud56V5jL1GItgkWtzYx/OLA5SCRIvwy5rAGAS9ko5+vxtX6VDfysPMyHse vbSgoFYDN9uQb6feavXLXPvvXiQKgCtxSsiXl636ecI+45LusT0nv0SprlB2lwOb16ks yP0VYUiv/G5SGSfra/UjzLXtQNUzJrFz99nLopW4KlWmLDd0OAxdz6Qa1Gu5LGOhSsiV n/9Q== X-Gm-Message-State: AJIora9ifOD49Kcvhc/X9SzvEAe4zNuP/feC19eUxDwrl7VQPKOgCWbT r9g86IqVv0o4k7w6CUGtzT5fQqpTvYmyWje+670OR7HN X-Google-Smtp-Source: AGRyM1t5drBeQYlHZC4LEYlMNveSDwb/YYXG6RQxHGKQdzmrPpdrECH+HtkRmVMYurnr2Oi6zs9f1U8TmMEw4VNSo3I= X-Received: by 2002:a5d:6883:0:b0:21b:9408:8ba0 with SMTP id h3-20020a5d6883000000b0021b94088ba0mr11014842wru.419.1656313447678; Mon, 27 Jun 2022 00:04:07 -0700 (PDT) MIME-Version: 1.0 References: <20220621194617.76561-1-ffmpeg@haasn.xyz> In-Reply-To: <20220621194617.76561-1-ffmpeg@haasn.xyz> From: =?UTF-8?B?SmFuIEVrc3Ryw7Zt?= Date: Mon, 27 Jun 2022 10:03:55 +0300 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffplay: fix YUV conversion mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, Jun 21, 2022 at 10:46 PM Niklas Haas wrote: > > From: Niklas Haas > > GL and Metal cache the state at time of texture creation. GLES2 and > Direct3D 11 use the state at time of the render copy call. > > So the only way we can get the correct behavior consistently is by > making sure the state is set for both the upload *and* the draw call. > This probably isn't our bug to fix (upstream should make itself behave > consistently and also document its functions), but as it stands, > `ffplay` is misrendering BT.709 as BT.601 on my stock Linux system, and > that leaves a bad taste in my mouth. > > Signed-off-by: Niklas Haas > --- Moves the color space setting earlier, as well as clears the state in case of an additional failure exit case with upload. LGTM. Jan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".