From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B75C04C232 for ; Thu, 6 Feb 2025 08:01:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C1BCC68BA75; Thu, 6 Feb 2025 10:01:01 +0200 (EET) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 25A3D68B3F2 for ; Thu, 6 Feb 2025 10:00:55 +0200 (EET) Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-435f8f29f8aso3597045e9.2 for ; Thu, 06 Feb 2025 00:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738828854; x=1739433654; darn=ffmpeg.org; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=DFHkZ1AGRmdbgo2Kpwm019B7Z3jHYMw8a5GhlRJA/UQ=; b=CMbEit4eMFJSyqlzyDzt5rU0nD1piD+YEslidGHX1O5U48erMudeAKHaO24BT7I9CE /c++f3LmzrqSCUUPzRPh0d1x0ljkuiSwk8aCCroMLO+1IXw4hWwUHjeJ1VNh0ZESzi4S Lt4bv3Kv9X2eIcThM0NK0aNnch4wcqEuK2Y5pxZN6Eh2bFXT5B7eOB9NtQFNkGn+77+b OUZI/i2RGcUi4q3dJtJFRNJQCy3eRsSsha+nzjPkdyxAmzlc1Uhf4Oqoj7u69oJ8m+da LCj1DGtK79S0pEEED3k+P+iSQmJ4JWY60NuLnqDF0F8miB0JWoEBoBwuWtJkH/5X0sRq YHvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738828854; x=1739433654; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DFHkZ1AGRmdbgo2Kpwm019B7Z3jHYMw8a5GhlRJA/UQ=; b=UC+Dhkh419C/Pki2ceXilk8qJbQMfTzmJnxeJhbLINY3rOjvy5oy19aWCmzUm/r3/o A0Vn3LJ9+67DizKRLLzCDwF//bORnY0h2rk0BfJlEEk/j/8SieZHsfYjIOC33Hnj7WzH 9KZ06fgH7fMq19EifJYSOyuXUbQAd29WS0JA1dr8ur7kNrcTz5th6DT/2wmUQJe6i02F /S9CxuEIKTi/RL32pLu+Q86IaeFhWEeiJVBE7iFufdjS/I2dmQ7GzQnt2GYTNn3g79C/ XaCaW7KwefXewR3VHumi+4SDchOnFellFSQ2sZOmrJq85Rf8KcZLlVYngBbFzfLgNZpI VOPA== X-Gm-Message-State: AOJu0YyuBicUuz5YZbiW4+8BmHKPYFL2B/5miLhsmxs7Bj+XH2WOPCdu EnfMkkIWNHh4JPHkl3bOCPTBuPyxbd5IKp19Ss+r9OSSCtvhqfTA+ZoSMdmLpO/DoeDUoovKWIO psTYqaVmNe4qBwdPQj4ANYzfKI/yLW2Jo X-Gm-Gg: ASbGncv94e7SeUfeQn9hWTpMX1VsX/EWSVfNCtehNJpbPUL+dbEZquXxj07+9FuLy3e c+1wo92BleSc8W6XJSku4q61Rx/i9wXOqLpl5kkqSTqNCHNsnIC3XDCdn0+/gxVgAhNjMxVXLP2 NOy6/2zV1YYLSAuZrC2z/nyXCRKrSDtA== X-Google-Smtp-Source: AGHT+IEMnd1q1P5gjzpkw8BRLQHw+GXEzn5VXAwJCQrbCDill2pxgIyB+qF7A4GiVVB4dzidz3J9WfsETJJxhdlU+bA= X-Received: by 2002:a05:600c:4253:b0:431:55c1:f440 with SMTP id 5b1f17b1804b1-4391466908emr10986685e9.30.1738828853971; Thu, 06 Feb 2025 00:00:53 -0800 (PST) MIME-Version: 1.0 Received: by 2002:adf:f087:0:b0:386:2ab6:da4f with HTTP; Thu, 6 Feb 2025 00:00:53 -0800 (PST) In-Reply-To: References: <20250206070047.152-1-torresefrain10@gmail.com> From: Efrain T Date: Thu, 6 Feb 2025 02:00:53 -0600 X-Gm-Features: AWEUYZn4Iivsvh5IT2SpKfLsLyJ3NuY5iUkdAQW2ykxwhsnS-0bYVNDXUwPPd_s Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avformat/unix: Set is_streamed to true X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: That sounds perfectly fine with me. Thanks for the quick reply. On Thursday, February 6, 2025, Leo Izen wrote: > On 2/6/25 2:00 AM, dank074 wrote: > >> Currently when a Unix Domain Socket is used as input there is a loss of >> data when data is consumed from the stream. Setting is_streamed to true >> fixes this, since the unix domain socket is now treated like a consumable >> stream. >> >> Fixes: #9346 >> Signed-off-by: dank074 >> --- >> libavformat/unix.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/unix.c b/libavformat/unix.c >> index 5704155cf0..2de4023835 100644 >> --- a/libavformat/unix.c >> +++ b/libavformat/unix.c >> @@ -89,7 +89,7 @@ static int unix_open(URLContext *h, const char >> *filename, int flags) >> } >> s->fd = fd; >> - >> + h->is_streamed = 1; >> return 0; >> fail: >> > > The patch looks fine as-is but two style nitpicks: > > - we like to have a full blank line between the return statement and the > one before it, so you should add this line of code right after the line > s->fd = fd; but not remove the blank line that was there > - commit messages should be capped at 72 characters per line for > historical reasons, so please insert newline characters in the commit > message > > If there's no other objections I will push this patch and make both of > these changes on my end, preserving authorship before I do, if that is okay > with you. > > - Leo Izen (Traneptora) > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".