From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D7D96476E6 for ; Wed, 20 Sep 2023 00:45:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 656FC68C96A; Wed, 20 Sep 2023 03:45:07 +0300 (EEST) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ED99868C841 for ; Wed, 20 Sep 2023 03:45:00 +0300 (EEST) Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-530bc7c5bc3so4874628a12.1 for ; Tue, 19 Sep 2023 17:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695170700; x=1695775500; darn=ffmpeg.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KsZ84lCQT5SaDfmsP4KZ4OZe3tgR/zLil//MA1H5mac=; b=B7QBEScxg1jZZAM0VSCDgc384RF9Rsw63Xpwb54eZlmsh7kGN33VVyEp7qZ/3kYJif uA3YGcTYcKRFZxxkgReZ/7oQfshG8H5XheC5Kkwv3xX9Q0SpMvTkQqxShpuunSfuGLhr bkRRp79k+fvblMsMgA4EEoVZz/vLThs2YoHzEnOV3N3+xea9QWrGoN9Hhqzs4h/FmOwm kYYP/h1YPJHjiblq1+xJOlwuz99QHCJ3TPcaEuZ/CJD4QRYbdCMODsDUo1zkSF/R+DPF FxDqCKuskNHKapT8zZyzz86EPmlqNfBPfDB+53VLq63PIYMaRiBBnzvFoL6GTy+1ypIl xeHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695170700; x=1695775500; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KsZ84lCQT5SaDfmsP4KZ4OZe3tgR/zLil//MA1H5mac=; b=xEySXwPX5ABrj/nd5NaOlsjBUN6YEqUC8f7kpwyZOz98mFu3LLs7suYe5v7NejXsOW oAjccQb5rqewGujuIb6GX3xNF1HnpdvgWr5CHIQM4qLluSOjkLz4BDcUdsJGwz/9v7zp 83Wn531xs8Wh/+pW9rdzMjE7PxodB16RMTAEaHSylxp+asmBukFvVbmNmsT7tmRUAnHW BZuWYD4jujf4OuUqOm3SllNN4i+q2nJ/VvNHf1eNqNrP++dVAxSGSl7lTDEGsSuAudMW KUCazzYkFpvLTmFygt0EyizhbER3IRjo8yuz4ShG049Ocav04hdjXN+ehv0DMH5iZoZe t9fQ== X-Gm-Message-State: AOJu0YxpvEGJYqwMuNTZO+jEYITfBgiNqtNE617dU9IRayNkBWRxwr0b uQb8c/hlPgdWIlFTMzuxLsnTnA4nKTYkKG2COo8RifH5NEVaTw== X-Google-Smtp-Source: AGHT+IEiOhmvM11vetIJaw+amf+oBE8EjZ/Q6QgXhIBF8z4M8vT4J+47i6A+t0DQRPiIPYId1iWuuYMH9i6NEwZD2rY= X-Received: by 2002:aa7:cc1a:0:b0:525:442b:6068 with SMTP id q26-20020aa7cc1a000000b00525442b6068mr856578edt.13.1695170699704; Tue, 19 Sep 2023 17:44:59 -0700 (PDT) MIME-Version: 1.0 References: <20230911075232.797886-1-fei.w.wang@intel.com> <20230911075232.797886-5-fei.w.wang@intel.com> In-Reply-To: <20230911075232.797886-5-fei.w.wang@intel.com> From: Neal Gompa Date: Tue, 19 Sep 2023 20:44:23 -0400 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v5 5/8] lavc/vaapi_encode: Extract set output pkt property function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: fei.w.wang@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: T24gTW9uLCBTZXAgMTEsIDIwMjMgYXQgMzo1M+KAr0FNIDxmZWkudy53YW5nLWF0LWludGVsLmNv bUBmZm1wZWcub3JnPiB3cm90ZToKPgo+IEZyb206IEZlaSBXYW5nIDxmZWkudy53YW5nQGludGVs LmNvbT4KPgo+IFNpZ25lZC1vZmYtYnk6IEZlaSBXYW5nIDxmZWkudy53YW5nQGludGVsLmNvbT4K PiAtLS0KPiAgbGliYXZjb2RlYy92YWFwaV9lbmNvZGUuYyB8IDY1ICsrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzggaW5zZXJ0aW9ucygr KSwgMjcgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvbGliYXZjb2RlYy92YWFwaV9lbmNv ZGUuYyBiL2xpYmF2Y29kZWMvdmFhcGlfZW5jb2RlLmMKPiBpbmRleCA1YWU2M2M5ZjI1Li40Njc2 MjM0MmViIDEwMDY0NAo+IC0tLSBhL2xpYmF2Y29kZWMvdmFhcGlfZW5jb2RlLmMKPiArKysgYi9s aWJhdmNvZGVjL3ZhYXBpX2VuY29kZS5jCj4gQEAgLTY1MCw2ICs2NTAsNDEgQEAgZmFpbF9hdF9l bmQ6Cj4gICAgICByZXR1cm4gZXJyOwo+ICB9Cj4KPiArc3RhdGljIGludCB2YWFwaV9lbmNvZGVf c2V0X291dHB1dF9wcm9wZXJ0eShBVkNvZGVjQ29udGV4dCAqYXZjdHgsCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgVkFBUElFbmNvZGVQaWN0dXJlICpwaWMs Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgQVZQYWNrZXQg KnBrdCkKPiArewo+ICsgICAgVkFBUElFbmNvZGVDb250ZXh0ICpjdHggPSBhdmN0eC0+cHJpdl9k YXRhOwo+ICsKPiArICAgIGlmIChwaWMtPnR5cGUgPT0gUElDVFVSRV9UWVBFX0lEUikKPiArICAg ICAgICBwa3QtPmZsYWdzIHw9IEFWX1BLVF9GTEFHX0tFWTsKPiArCj4gKyAgICBwa3QtPnB0cyA9 IHBpYy0+cHRzOwo+ICsgICAgcGt0LT5kdXJhdGlvbiA9IHBpYy0+ZHVyYXRpb247Cj4gKwo+ICsg ICAgLy8gZm9yIG5vLWRlbGF5IGVuY29kZXJzIHRoaXMgaXMgaGFuZGxlZCBpbiBnZW5lcmljIGNv ZGVjCj4gKyAgICBpZiAoYXZjdHgtPmNvZGVjLT5jYXBhYmlsaXRpZXMgJiBBVl9DT0RFQ19DQVBf REVMQVkgJiYKPiArICAgICAgICBhdmN0eC0+ZmxhZ3MgJiBBVl9DT0RFQ19GTEFHX0NPUFlfT1BB UVVFKSB7Cj4gKyAgICAgICAgcGt0LT5vcGFxdWUgICAgID0gcGljLT5vcGFxdWU7Cj4gKyAgICAg ICAgcGt0LT5vcGFxdWVfcmVmID0gcGljLT5vcGFxdWVfcmVmOwo+ICsgICAgICAgIHBpYy0+b3Bh cXVlX3JlZiA9IE5VTEw7Cj4gKyAgICB9Cj4gKwo+ICsgICAgaWYgKGN0eC0+b3V0cHV0X2RlbGF5 ID09IDApIHsKPiArICAgICAgICBwa3QtPmR0cyA9IHBrdC0+cHRzOwo+ICsgICAgfSBlbHNlIGlm IChwaWMtPmVuY29kZV9vcmRlciA8IGN0eC0+ZGVjb2RlX2RlbGF5KSB7Cj4gKyAgICAgICAgaWYg KGN0eC0+dHNfcmluZ1twaWMtPmVuY29kZV9vcmRlcl0gPCBJTlQ2NF9NSU4gKyBjdHgtPmR0c19w dHNfZGlmZikKPiArICAgICAgICAgICAgcGt0LT5kdHMgPSBJTlQ2NF9NSU47Cj4gKyAgICAgICAg ZWxzZQo+ICsgICAgICAgICAgICBwa3QtPmR0cyA9IGN0eC0+dHNfcmluZ1twaWMtPmVuY29kZV9v cmRlcl0gLSBjdHgtPmR0c19wdHNfZGlmZjsKPiArICAgIH0gZWxzZSB7Cj4gKyAgICAgICAgcGt0 LT5kdHMgPSBjdHgtPnRzX3JpbmdbKHBpYy0+ZW5jb2RlX29yZGVyIC0gY3R4LT5kZWNvZGVfZGVs YXkpICUKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoMyAqIGN0eC0+b3V0cHV0 X2RlbGF5ICsgY3R4LT5hc3luY19kZXB0aCldOwo+ICsgICAgfQo+ICsKPiArICAgIHJldHVybiAw Owo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHZhYXBpX2VuY29kZV9vdXRwdXQoQVZDb2RlY0NvbnRl eHQgKmF2Y3R4LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgVkFBUElFbmNvZGVQ aWN0dXJlICpwaWMsIEFWUGFja2V0ICpwa3QpCj4gIHsKPiBAQCAtNjkxLDEyICs3MjYsNiBAQCBz dGF0aWMgaW50IHZhYXBpX2VuY29kZV9vdXRwdXQoQVZDb2RlY0NvbnRleHQgKmF2Y3R4LAo+ICAg ICAgICAgIHB0ciArPSBidWYtPnNpemU7Cj4gICAgICB9Cj4KPiAtICAgIGlmIChwaWMtPnR5cGUg PT0gUElDVFVSRV9UWVBFX0lEUikKPiAtICAgICAgICBwa3QtPmZsYWdzIHw9IEFWX1BLVF9GTEFH X0tFWTsKPiAtCj4gLSAgICBwa3QtPnB0cyA9IHBpYy0+cHRzOwo+IC0gICAgcGt0LT5kdXJhdGlv biA9IHBpYy0+ZHVyYXRpb247Cj4gLQo+ICAgICAgdmFzID0gdmFVbm1hcEJ1ZmZlcihjdHgtPmh3 Y3R4LT5kaXNwbGF5LCBwaWMtPm91dHB1dF9idWZmZXIpOwo+ICAgICAgaWYgKHZhcyAhPSBWQV9T VEFUVVNfU1VDQ0VTUykgewo+ICAgICAgICAgIGF2X2xvZyhhdmN0eCwgQVZfTE9HX0VSUk9SLCAi RmFpbGVkIHRvIHVubWFwIG91dHB1dCBidWZmZXJzOiAiCj4gQEAgLTcwNSwxNCArNzM0LDYgQEAg c3RhdGljIGludCB2YWFwaV9lbmNvZGVfb3V0cHV0KEFWQ29kZWNDb250ZXh0ICphdmN0eCwKPiAg ICAgICAgICBnb3RvIGZhaWw7Cj4gICAgICB9Cj4KPiAtICAgIC8vIGZvciBuby1kZWxheSBlbmNv ZGVycyB0aGlzIGlzIGhhbmRsZWQgaW4gZ2VuZXJpYyBjb2RlYwo+IC0gICAgaWYgKGF2Y3R4LT5j b2RlYy0+Y2FwYWJpbGl0aWVzICYgQVZfQ09ERUNfQ0FQX0RFTEFZICYmCj4gLSAgICAgICAgYXZj dHgtPmZsYWdzICYgQVZfQ09ERUNfRkxBR19DT1BZX09QQVFVRSkgewo+IC0gICAgICAgIHBrdC0+ b3BhcXVlICAgICA9IHBpYy0+b3BhcXVlOwo+IC0gICAgICAgIHBrdC0+b3BhcXVlX3JlZiA9IHBp Yy0+b3BhcXVlX3JlZjsKPiAtICAgICAgICBwaWMtPm9wYXF1ZV9yZWYgPSBOVUxMOwo+IC0gICAg fQo+IC0KPiAgICAgIGF2X2J1ZmZlcl91bnJlZigmcGljLT5vdXRwdXRfYnVmZmVyX3JlZik7Cj4g ICAgICBwaWMtPm91dHB1dF9idWZmZXIgPSBWQV9JTlZBTElEX0lEOwo+Cj4gQEAgLTEyNzMsMTkg KzEyOTQsOSBAQCBpbnQgZmZfdmFhcGlfZW5jb2RlX3JlY2VpdmVfcGFja2V0KEFWQ29kZWNDb250 ZXh0ICphdmN0eCwgQVZQYWNrZXQgKnBrdCkKPiAgICAgICAgICByZXR1cm4gZXJyOwo+ICAgICAg fQo+Cj4gLSAgICBpZiAoY3R4LT5vdXRwdXRfZGVsYXkgPT0gMCkgewo+IC0gICAgICAgIHBrdC0+ ZHRzID0gcGt0LT5wdHM7Cj4gLSAgICB9IGVsc2UgaWYgKHBpYy0+ZW5jb2RlX29yZGVyIDwgY3R4 LT5kZWNvZGVfZGVsYXkpIHsKPiAtICAgICAgICBpZiAoY3R4LT50c19yaW5nW3BpYy0+ZW5jb2Rl X29yZGVyXSA8IElOVDY0X01JTiArIGN0eC0+ZHRzX3B0c19kaWZmKQo+IC0gICAgICAgICAgICBw a3QtPmR0cyA9IElOVDY0X01JTjsKPiAtICAgICAgICBlbHNlCj4gLSAgICAgICAgICAgIHBrdC0+ ZHRzID0gY3R4LT50c19yaW5nW3BpYy0+ZW5jb2RlX29yZGVyXSAtIGN0eC0+ZHRzX3B0c19kaWZm Owo+IC0gICAgfSBlbHNlIHsKPiAtICAgICAgICBwa3QtPmR0cyA9IGN0eC0+dHNfcmluZ1socGlj LT5lbmNvZGVfb3JkZXIgLSBjdHgtPmRlY29kZV9kZWxheSkgJQo+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICgzICogY3R4LT5vdXRwdXRfZGVsYXkgKyBjdHgtPmFzeW5jX2RlcHRo KV07Cj4gLSAgICB9Cj4gLSAgICBhdl9sb2coYXZjdHgsIEFWX0xPR19ERUJVRywgIk91dHB1dCBw YWNrZXQ6IHB0cyAlIlBSSWQ2NCIgZHRzICUiUFJJZDY0Ii5cbiIsCj4gLSAgICAgICAgICAgcGt0 LT5wdHMsIHBrdC0+ZHRzKTsKPiArICAgIHZhYXBpX2VuY29kZV9zZXRfb3V0cHV0X3Byb3BlcnR5 KGF2Y3R4LCBwaWMsIHBrdCk7Cj4gKyAgICBhdl9sb2coYXZjdHgsIEFWX0xPR19ERUJVRywgIk91 dHB1dCBwYWNrZXQ6IHB0cyAlIlBSSWQ2NCIsIGR0cyAlIlBSSWQ2NCIsICIKPiArICAgICAgICAg ICAic2l6ZSAlZCBieXRlcy5cbiIsIHBrdC0+cHRzLCBwa3QtPmR0cywgcGt0LT5zaXplKTsKPgo+ ICAgICAgY3R4LT5vdXRwdXRfb3JkZXIgPSBwaWMtPmVuY29kZV9vcmRlcjsKPiAgICAgIHZhYXBp X2VuY29kZV9jbGVhcl9vbGQoYXZjdHgpOwo+IC0tCj4gMi4yNS4xCj4KCkxHVE0uCgpSZXZpZXdl ZC1ieTogTmVhbCBHb21wYSA8bmdvbXBhMTNAZ21haWwuY29tPgoKCgotLSAK55yf5a6f44Gv44GE 44Gk44KC5LiA44Gk77yBLyBBbHdheXMsIHRoZXJlJ3Mgb25seSBvbmUgdHJ1dGghCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmZmbXBlZy1kZXZlbCBtYWls aW5nIGxpc3QKZmZtcGVnLWRldmVsQGZmbXBlZy5vcmcKaHR0cHM6Ly9mZm1wZWcub3JnL21haWxt YW4vbGlzdGluZm8vZmZtcGVnLWRldmVsCgpUbyB1bnN1YnNjcmliZSwgdmlzaXQgbGluayBhYm92 ZSwgb3IgZW1haWwKZmZtcGVnLWRldmVsLXJlcXVlc3RAZmZtcGVnLm9yZyB3aXRoIHN1YmplY3Qg InVuc3Vic2NyaWJlIi4K