Re: [FFmpeg-devel] [PATCH v5 8/8] lavc/av1: Add unit test for level handling

[Neal Gompa <ngompa13@gmail.com>]

On Mon, Sep 11, 2023 at 3:54 AM <fei.w.wang-at-intel.com@ffmpeg.org> wrote:
>
> From: Fei Wang <fei.w.wang@intel.com>
>
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
>  libavcodec/tests/.gitignore   |   1 +
>  libavcodec/tests/av1_levels.c | 126 ++++++++++++++++++++++++++++++++++
>  tests/fate/libavcodec.mak     |   5 ++
>  3 files changed, 132 insertions(+)
>  create mode 100644 libavcodec/tests/av1_levels.c
>
> diff --git a/libavcodec/tests/.gitignore b/libavcodec/tests/.gitignore
> index 2acfc4e804..5e0ccc5838 100644
> --- a/libavcodec/tests/.gitignore
> +++ b/libavcodec/tests/.gitignore
> @@ -1,3 +1,4 @@
> +/av1_levels
>  /avcodec
>  /avfft
>  /avpacket
> diff --git a/libavcodec/tests/av1_levels.c b/libavcodec/tests/av1_levels.c
> new file mode 100644
> index 0000000000..e862d197d2
> --- /dev/null
> +++ b/libavcodec/tests/av1_levels.c
> @@ -0,0 +1,126 @@
> +/*
> + * Copyright (c) 2023 Intel Corporation
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#include <stddef.h>
> +#include <inttypes.h>
> +#include "libavutil/log.h"
> +#include "libavcodec/av1_levels.h"
> +
> +static const struct {
> +    int width;
> +    int height;
> +    float framerate;
> +    int level_idx;
> +} test_sizes[] = {
> +    {  426,  240,  30.0,  0 },
> +    {  640,  360,  30.0,  1 },
> +    {  854,  480,  30.0,  4 },
> +    { 1280,  720,  30.0,  5 },
> +    { 1920, 1080,  30.0,  8 },
> +    { 1920, 1080,  60.0,  9 },
> +    { 3840, 2160,  30.0, 12 },
> +    { 3840, 2160,  60.0, 13 },
> +    { 3840, 2160, 120.0, 14 },
> +    { 7680, 4320,  30.0, 16 },
> +    { 7680, 4320,  60.0, 17 },
> +    { 7680, 4320, 120.0, 18 },
> +};
> +
> +static const struct {
> +    int64_t bitrate;
> +    int tier;
> +    int level_idx;
> +} test_bitrate[] = {
> +    {   1500000, 0,  0 },
> +    {   3000000, 0,  1 },
> +    {   6000000, 0,  4 },
> +    {  10000000, 0,  5 },
> +    {  12000000, 0,  8 },
> +    {  30000000, 1,  8 },
> +    {  20000000, 0,  9 },
> +    {  50000000, 1,  9 },
> +    {  30000000, 0, 12 },
> +    { 100000000, 1, 12 },
> +    {  40000000, 0, 13 },
> +    { 160000000, 1, 13 },
> +    {  60000000, 0, 14 },
> +    { 240000000, 1, 14 },
> +    { 100000000, 0, 17 },
> +    { 480000000, 1, 17 },
> +    { 160000000, 0, 18 },
> +    { 800000000, 1, 18 },
> +};
> +
> +static const struct {
> +    int tiles;
> +    int tile_cols;
> +    int level_idx;
> +} test_tiles[] = {
> +    {    8,  4,  0 },
> +    {   16,  6,  4 },
> +    {   32,  8,  8 },
> +    {   64,  8, 12 },
> +    {  128, 16, 16 },
> +};
> +
> +int main(void)
> +{
> +    const AV1LevelDescriptor *level;
> +    int i;
> +
> +#define CHECK(expected, format, ...) do { \
> +        if (level ? (level->level_idx != expected) \
> +                     : !level) { \
> +            av_log(NULL, AV_LOG_ERROR, "Incorrect level for " \
> +                   format ": expected %d, got %d.\n", __VA_ARGS__, \
> +                   expected, level ? level->level_idx : -1); \
> +            return 1; \
> +        } \
> +    } while (0)
> +
> +    for (i = 0; i < FF_ARRAY_ELEMS(test_sizes); i++) {
> +        level = ff_av1_guess_level(0, 0,
> +                                   test_sizes[i].width,
> +                                   test_sizes[i].height,
> +                                   0, 0, test_sizes[i].framerate);
> +        CHECK(test_sizes[i].level_idx, "size %dx%d, framerate %f",
> +              test_sizes[i].width, test_sizes[i].height, test_sizes[i].framerate);
> +    }
> +
> +    for (i = 0; i < FF_ARRAY_ELEMS(test_bitrate); i++) {
> +        level = ff_av1_guess_level(test_bitrate[i].bitrate,
> +                                   test_bitrate[i].tier,
> +                                   0, 0, 0, 0, 0);
> +        CHECK(test_bitrate[i].level_idx, "bitrate %"PRId64" tier %d",
> +              test_bitrate[i].bitrate, test_bitrate[i].tier);
> +    }
> +
> +    for (i = 0; i < FF_ARRAY_ELEMS(test_tiles); i++) {
> +        level = ff_av1_guess_level(0, 0, 0, 0,
> +                                   test_tiles[i].tiles,
> +                                   test_tiles[i].tile_cols,
> +                                   0);
> +        CHECK(test_tiles[i].level_idx, "tiles %d, tile cols %d",
> +              test_tiles[i].tiles,
> +              test_tiles[i].tile_cols);
> +    }
> +
> +    return 0;
> +}
> diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak
> index 8f56fae3a8..1a5694fa5f 100644
> --- a/tests/fate/libavcodec.mak
> +++ b/tests/fate/libavcodec.mak
> @@ -1,3 +1,8 @@
> +FATE_LIBAVCODEC-$(CONFIG_AV1_VAAPI_ENCODER) += fate-av1-levels
> +fate-av1-levels: libavcodec/tests/av1_levels$(EXESUF)
> +fate-av1-levels: CMD = run libavcodec/tests/av1_levels$(EXESUF)
> +fate-av1-levels: REF = /dev/null
> +
>  FATE_LIBAVCODEC-yes += fate-avpacket
>  fate-avpacket: libavcodec/tests/avpacket$(EXESUF)
>  fate-avpacket: CMD = run libavcodec/tests/avpacket$(EXESUF)
> --
> 2.25.1
>

LGTM.

Reviewed-by: Neal Gompa <ngompa13@gmail.com>



-- 
真実はいつも一つ！/ Always, there's only one truth!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".