Re: [FFmpeg-devel] [PATCH v9 0/6] Support enhanced flv in FFmpeg

[Neal Gompa <ngompa13@gmail.com>]

On Fri, May 12, 2023 at 7:59 AM Steven Liu <lingjiujianke@gmail.com> wrote:
>
> Vibhoothi <vibhoothiiaanand@gmail.com> 于2023年5月12日周五 18:48写道：
> >
> > Hi,
> >
> > On Fri, 12 May 2023 at 04:59, Steven Liu <lq@chinaffmpeg.org> wrote:
> > >
> > > Reference file: https://github.com/veovera/enhanced-rtmp/blob/main/enhanced-rtmp-v1.pdf
> > > The Enhanced flv has been supported by OBS, Simple Realtime Server, mpegts.js.
> > > you can publish hevc, av1 or vp9 codec stream to Youtube over rtmp.
> > > The enhanced flv documentation contributors include
> > > Jean-Baptiste Kempf (FFmpeg, VideoLAN).
> > > So this should be support by ffmpeg too.
> > >
> > > v8:
> > >     Support vp9 codec according to enhanced flv.
> > >     Support PacketTypeCodedFrames type for hevc in flv.
> > > v9:
> > >     Add dependency codec object files for flvenc in Makefile.
> > >     Move the hevc,av1,vp9 codec out of FF_COMPLIANCE_UNOFFICIAL.
> > >
> > > Steven Liu (6):
> > >   avformat/flvenc: Add support for HEVC over flv in muxer
> > >   avformat/flvdec: support demux hevc in enhanced flv
> > >   avformat/flvenc: support mux av1 in enhanced flv
> > >   avformat/flvdec: support demux av1 in enhanced flv
> > >   avformat/flvenc: support mux vp9 in enhanced flv
> > >   avformat/flvenc: support demux vp9 in enhanced flv
> > Nit: Shouldn't the commit message be pointing flvdec
> > ("avformat/flvdec") instead of flvenc ("avformat/flvenc") for
> > VP9 demuxer support?
> Good catch,
> Thanks Vibhoothi
>
>  fix it localy.
> >
> > I could see the changes being made to,
> >  libavformat/flvdec.c | 11 +++++++++--,
> > in the patch set.
> >
> > >
> > >  libavformat/Makefile |  2 +-
> > >  libavformat/flv.h    | 15 +++++++++
> > >  libavformat/flvdec.c | 73 +++++++++++++++++++++++++++++++++++++++-----
> > >  libavformat/flvenc.c | 58 +++++++++++++++++++++++++++++------
> > >  4 files changed, 130 insertions(+), 18 deletions(-)
> > >
> > > --
> > > 2.40.0
> > >
>

I've applied your patch set to Fedora's ffmpeg 6.0 on Fedora 38 and
attempted to test it. It seems to mostly work now, except that AAC
audio doesn't play in the AV1+AAC sample remuxed from MKV to FLV. My
H264+AAC sample seems to work properly though.

Here are reproducer samples:
https://ngompa.fedorapeople.org/obs-recording-samples.tar

My command for remuxing them is simple:

$ ffmpeg -i "input.mkv" -vcodec copy -acodec copy "output.flv"


-- 
真実はいつも一つ！/ Always, there's only one truth!
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".