Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Chema Gonzalez <chema@berkeley.edu>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/1] pixdesc: add limited|full aliases for -color_range parameter
Date: Mon, 10 Apr 2023 11:01:53 -0700
Message-ID: <CAEb0MffjozKMO3AEDTfOaO0W4E+Asv1uOL10sQ2Kp7wjOzP3ig@mail.gmail.com> (raw)
In-Reply-To: <20230331154956.3675424-2-chemag@gmail.com>

Ping :)

-Chema

On Fri, Mar 31, 2023 at 8:50 AM Chema Gonzalez <chemag@gmail.com> wrote:
>
> Aliases are also used in scale and zscale filters.
>
> Tested:
> ```
> $ ./ffmpeg -hide_banner -y -i ~/src/media/images/y4m/lena.490x490.y4m  -pix_fmt yuv420p -color_range unknown /tmp/unknown.y4m
> ...
> $ md5sum /tmp/unknown.y4m
> 69aa7bf52bbd72444268a544c81d7643  /tmp/unknown.y4m
>
> $ ./ffmpeg -hide_banner -y -i ~/src/media/images/y4m/lena.490x490.y4m  -pix_fmt yuv420p -color_range tv /tmp/tv.y4m
> ...
> $ md5sum /tmp/tv.y4m
> 5c1c8759708ff6b25dd8a660da5200e7  /tmp/tv.y4m
>
> $ ./ffmpeg -hide_banner -y -i ~/src/media/images/y4m/lena.490x490.y4m  -pix_fmt yuv420p -color_range pc /tmp/pc.y4m
> ...
> $ md5sum /tmp/pc.y4m
> 1ccb85d14a3dfecb22e625711587ba97  /tmp/pc.y4m
>
> $ ./ffmpeg -hide_banner -y -i ~/src/media/images/y4m/lena.490x490.y4m  -pix_fmt yuv420p -color_range limited /tmp/limited.y4m
> ...
> $ md5sum /tmp/limited.y4m
> 5c1c8759708ff6b25dd8a660da5200e7  /tmp/limited.y4m
>
> $ ./ffmpeg -hide_banner -y -i ~/src/media/images/y4m/lena.490x490.y4m  -pix_fmt yuv420p -color_range full /tmp/full.y4m
> ...
> $ md5sum /tmp/full.y4m
> 1ccb85d14a3dfecb22e625711587ba97  /tmp/full.y4m
> ```
>
> Also ran fate.
> ```
> $ make fate -j
> ...
> TEST    ffprobe_xsd
> TEST    flv-add_keyframe_index
> ```
> ---
>  doc/codecs.texi            | 2 ++
>  libavcodec/options_table.h | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/doc/codecs.texi b/doc/codecs.texi
> index 1adacd2b59..bd04e134e1 100644
> --- a/doc/codecs.texi
> +++ b/doc/codecs.texi
> @@ -890,9 +890,11 @@ Possible values:
>  @table @samp
>  @item tv
>  @item mpeg
> +@item limited
>  MPEG (219*2^(n-8))
>  @item pc
>  @item jpeg
> +@item full
>  JPEG (2^n-1)
>  @end table
>
> diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h
> index f331ce2861..979904daae 100644
> --- a/libavcodec/options_table.h
> +++ b/libavcodec/options_table.h
> @@ -346,6 +346,8 @@ static const AVOption avcodec_options[] = {
>  {"unspecified", "Unspecified", 0, AV_OPT_TYPE_CONST, {.i64 = AVCOL_RANGE_UNSPECIFIED }, INT_MIN, INT_MAX, V|E|D, "color_range_type"},
>  {"mpeg", "MPEG (219*2^(n-8))", 0, AV_OPT_TYPE_CONST, {.i64 = AVCOL_RANGE_MPEG },        INT_MIN, INT_MAX, V|E|D, "color_range_type"},
>  {"jpeg", "JPEG (2^n-1)",       0, AV_OPT_TYPE_CONST, {.i64 = AVCOL_RANGE_JPEG },        INT_MIN, INT_MAX, V|E|D, "color_range_type"},
> +{"limited", "MPEG (219*2^(n-8))", 0, AV_OPT_TYPE_CONST, {.i64 = AVCOL_RANGE_MPEG },     INT_MIN, INT_MAX, V|E|D, "color_range_type"},
> +{"full", "JPEG (2^n-1)",       0, AV_OPT_TYPE_CONST, {.i64 = AVCOL_RANGE_JPEG },        INT_MIN, INT_MAX, V|E|D, "color_range_type"},
>  {"chroma_sample_location", "chroma sample location", OFFSET(chroma_sample_location), AV_OPT_TYPE_INT, {.i64 = AVCHROMA_LOC_UNSPECIFIED }, 0, INT_MAX, V|E|D, "chroma_sample_location_type"},
>  {"unknown",     "Unspecified", 0, AV_OPT_TYPE_CONST, {.i64 = AVCHROMA_LOC_UNSPECIFIED }, INT_MIN, INT_MAX, V|E|D, "chroma_sample_location_type"},
>  {"left",        "Left",        0, AV_OPT_TYPE_CONST, {.i64 = AVCHROMA_LOC_LEFT },        INT_MIN, INT_MAX, V|E|D, "chroma_sample_location_type"},
> --
> 2.39.2
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-04-10 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 15:49 [FFmpeg-devel] [PATCH 0/1] " Chema Gonzalez
2023-03-31 15:49 ` [FFmpeg-devel] [PATCH 1/1] pixdesc: " Chema Gonzalez
2023-04-10 18:01   ` Chema Gonzalez [this message]
2023-09-23 14:57 ` [FFmpeg-devel] [PATCH 0/1] " Niklas Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEb0MffjozKMO3AEDTfOaO0W4E+Asv1uOL10sQ2Kp7wjOzP3ig@mail.gmail.com \
    --to=chema@berkeley.edu \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git