From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 787B8449B9 for ; Wed, 28 Sep 2022 16:20:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0C27968B9F1; Wed, 28 Sep 2022 19:20:42 +0300 (EEST) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A2021680CE9 for ; Wed, 28 Sep 2022 19:20:35 +0300 (EEST) Received: by mail-yb1-f170.google.com with SMTP id 126so16492711ybw.3 for ; Wed, 28 Sep 2022 09:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=berkeley.edu; s=google; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=d/ersotbjrXvLPJhpb0dW4Ll4M7ZEIpZ04TH/pqR3ro=; b=gHmQtykqrZ/TfZr/tWi/kM0PZ3apczDZ7vuA395JJNCWMRiIlpCLOVU2JGS2NoKqct txf09uYtAMVSfqihRMq0Fd37d7tMYhMt6UoVJIJKk++isVTiL5od9VERJkv3g4UpXghz yo+kxPJpHe4PHRWqO99ViQs8a2mu2oqwzcCHrgJG0nL8rK12HJhAGwBZOcM4pSN3tYTh FXOgAoXabr52CO3qpqsH2RKmLtD42RLAp3++UGPbvY2pyy0TIKk1TxwkexGpQJ43L8RM u7M6peCRA7BMXK1OyjnjxJNyySt1Ztqc6mXCwxJXG78zYYlj7J7t5A3/0CXXEabig8rz YbNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=d/ersotbjrXvLPJhpb0dW4Ll4M7ZEIpZ04TH/pqR3ro=; b=LvLN68dcPEjtph/4CZ5Mg1MrJFV4grzWCa5jIymMwiv9pg06kSsyWk0s3ybInXMUn9 klEhYUiYDX1Siw+LQmXccLm1LYnVK4phQDpDmHGLSyPLIfMl+MhzWzARDOIONcRdoPpH lcyzHjWb4xyqipaAWJpFlpaUFM739aymjHTXWL3Pj2eIfeR0faEyHOlOraibJuoEQXJW avEAtNqwswQ3uDztETdzFzxcfFxARr2aFWJnG6rIGaq5h1Q+ruCbl1dVp1kNZbvxa68c rObJgIFk1g4/LxPtUus4XiDB3SW4Z7rtACa9z8d3NZqW6hF0sK/4buUI5Gwi8knYW6x+ utVw== X-Gm-Message-State: ACrzQf3dLzDWkueHdQo0W9bM86LTpsgGkKFaPfe7rX088ywJTLXVXfPO QPIIErAYpPt/0UDzOZXBGwwtGGdrOtqDLs1opo8aShPsDC+VXQ== X-Google-Smtp-Source: AMsMyM5aC9X54unmKS1diDdQYv9dazbzehAQW+L4MAoa5g0HL5NAKEOB7zHmJNJQCOCcV4mBfqJQmLUZVcselIYFOwI= X-Received: by 2002:a25:8547:0:b0:672:ca9c:d33f with SMTP id f7-20020a258547000000b00672ca9cd33fmr32418205ybn.270.1664382033766; Wed, 28 Sep 2022 09:20:33 -0700 (PDT) MIME-Version: 1.0 References: <20220926161122.1352372-1-chemag@gmail.com> <166437777511.22057.15424129912103570657@lain.khirnov.net> In-Reply-To: <166437777511.22057.15424129912103570657@lain.khirnov.net> From: Chema Gonzalez Date: Wed, 28 Sep 2022 09:20:22 -0700 Message-ID: To: ffmpeg-devel@ffmpeg.org, Chema Gonzalez Subject: Re: [FFmpeg-devel] [PATCH 1/1] libswscale: force a minimum size of the slide for bayer sources X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Wed, Sep 28, 2022 at 8:09 AM Anton Khirnov wrote: > > if (isBayer(srcFormat)) { > > + c->dst_slice_align = 2; > > IMO it's better to put this next to the line that sets dst_slice_align > for non-bayer cases, makes it clearer what the final value is. Are you suggesting setting `dst_slice_align` in a different function? The way I read `ff_get_unscaled_swscale()` is that it goes through the quirks of all the different conversions (per source and destination type). In all cases, it sets the `convert_unscaled` function pointer. In the cases where there is the need to align (yuv2bgr and yuv410p_to_yuv[a]420p), it also adds `dst_slice_align`. In the same fashion, the conversions that affect Bayer sources are set in line 2097. Thanks, -Chema _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".