* [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init @ 2023-12-20 8:39 flow gg 2023-12-20 9:51 ` Anton Khirnov 0 siblings, 1 reply; 3+ messages in thread From: flow gg @ 2023-12-20 8:39 UTC (permalink / raw) To: FFmpeg development discussions and patches [-- Attachment #1: Type: text/plain, Size: 1 bytes --] [-- Attachment #2: 0001-lvac-dnxhdenc-add-ff_dnxhdenc_init.patch --] [-- Type: text/x-patch, Size: 1268 bytes --] From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001 From: sunyuechi <sunyuechi@iscas.ac.cn> Date: Wed, 20 Dec 2023 16:17:32 +0800 Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init This is for clarity and use in testing, consistent with other parts of the code. --- libavcodec/dnxhdenc.c | 6 ++++++ libavcodec/dnxhdenc.h | 1 + 2 files changed, 7 insertions(+) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index f52a2e9918..1ac8116f53 100644 --- a/libavcodec/dnxhdenc.c +++ b/libavcodec/dnxhdenc.c @@ -1377,3 +1377,9 @@ const FFCodec ff_dnxhd_encoder = { .p.profiles = NULL_IF_CONFIG_SMALL(ff_dnxhd_profiles), .caps_internal = FF_CODEC_CAP_INIT_CLEANUP, }; + +void ff_dnxhdenc_init(DNXHDEncContext *ctx) { +#if ARCH_X86 + ff_dnxhdenc_init_x86(ctx); +#endif +} diff --git a/libavcodec/dnxhdenc.h b/libavcodec/dnxhdenc.h index e581312ce4..95aea83d28 100644 --- a/libavcodec/dnxhdenc.h +++ b/libavcodec/dnxhdenc.h @@ -111,6 +111,7 @@ typedef struct DNXHDEncContext { const uint8_t *pixels, ptrdiff_t line_size); } DNXHDEncContext; +void ff_dnxhdenc_init(DNXHDEncContext *ctx); void ff_dnxhdenc_init_x86(DNXHDEncContext *ctx); #endif /* AVCODEC_DNXHDENC_H */ -- 2.43.0 [-- Attachment #3: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init 2023-12-20 8:39 [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init flow gg @ 2023-12-20 9:51 ` Anton Khirnov 2023-12-20 10:12 ` flow gg 0 siblings, 1 reply; 3+ messages in thread From: Anton Khirnov @ 2023-12-20 9:51 UTC (permalink / raw) To: FFmpeg development discussions and patches Quoting flow gg (2023-12-20 09:39:57) > > > From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001 > From: sunyuechi <sunyuechi@iscas.ac.cn> > Date: Wed, 20 Dec 2023 16:17:32 +0800 > Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init typo in 'lavc' > > This is for clarity and use in testing, consistent with other parts of the code. > --- > libavcodec/dnxhdenc.c | 6 ++++++ > libavcodec/dnxhdenc.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c > index f52a2e9918..1ac8116f53 100644 > --- a/libavcodec/dnxhdenc.c > +++ b/libavcodec/dnxhdenc.c > @@ -1377,3 +1377,9 @@ const FFCodec ff_dnxhd_encoder = { > .p.profiles = NULL_IF_CONFIG_SMALL(ff_dnxhd_profiles), > .caps_internal = FF_CODEC_CAP_INIT_CLEANUP, > }; > + > +void ff_dnxhdenc_init(DNXHDEncContext *ctx) { Brace should be on its own line > +#if ARCH_X86 > + ff_dnxhdenc_init_x86(ctx); > +#endif > +} > diff --git a/libavcodec/dnxhdenc.h b/libavcodec/dnxhdenc.h > index e581312ce4..95aea83d28 100644 > --- a/libavcodec/dnxhdenc.h > +++ b/libavcodec/dnxhdenc.h > @@ -111,6 +111,7 @@ typedef struct DNXHDEncContext { > const uint8_t *pixels, ptrdiff_t line_size); > } DNXHDEncContext; > > +void ff_dnxhdenc_init(DNXHDEncContext *ctx); Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call in dnxhdenc.c? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init 2023-12-20 9:51 ` Anton Khirnov @ 2023-12-20 10:12 ` flow gg 0 siblings, 0 replies; 3+ messages in thread From: flow gg @ 2023-12-20 10:12 UTC (permalink / raw) To: FFmpeg development discussions and patches [-- Attachment #1: Type: text/plain, Size: 2156 bytes --] > typo in 'lavc' fixed. > Brace should be on its own line fixed > Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call in dnxhdenc.c? Sorry, I missed this part, it's fixed in this reply Anton Khirnov <anton@khirnov.net> 于2023年12月20日周三 17:51写道： > Quoting flow gg (2023-12-20 09:39:57) > > > > > > From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001 > > From: sunyuechi <sunyuechi@iscas.ac.cn> > > Date: Wed, 20 Dec 2023 16:17:32 +0800 > > Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init > > typo in 'lavc' > > > > > This is for clarity and use in testing, consistent with other parts of > the code. > > --- > > libavcodec/dnxhdenc.c | 6 ++++++ > > libavcodec/dnxhdenc.h | 1 + > > 2 files changed, 7 insertions(+) > > > > diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c > > index f52a2e9918..1ac8116f53 100644 > > --- a/libavcodec/dnxhdenc.c > > +++ b/libavcodec/dnxhdenc.c > > @@ -1377,3 +1377,9 @@ const FFCodec ff_dnxhd_encoder = { > > .p.profiles = NULL_IF_CONFIG_SMALL(ff_dnxhd_profiles), > > .caps_internal = FF_CODEC_CAP_INIT_CLEANUP, > > }; > > + > > +void ff_dnxhdenc_init(DNXHDEncContext *ctx) { > > Brace should be on its own line > > > +#if ARCH_X86 > > + ff_dnxhdenc_init_x86(ctx); > > +#endif > > +} > > diff --git a/libavcodec/dnxhdenc.h b/libavcodec/dnxhdenc.h > > index e581312ce4..95aea83d28 100644 > > --- a/libavcodec/dnxhdenc.h > > +++ b/libavcodec/dnxhdenc.h > > @@ -111,6 +111,7 @@ typedef struct DNXHDEncContext { > > const uint8_t *pixels, ptrdiff_t > line_size); > > } DNXHDEncContext; > > > > +void ff_dnxhdenc_init(DNXHDEncContext *ctx); > > Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call > in dnxhdenc.c? > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > [-- Attachment #2: 0001-lavc-dnxhdenc-add-ff_dnxhdenc_init.patch --] [-- Type: text/x-patch, Size: 1606 bytes --] From 38e8ffbf49d23417bc597b166f6869dadee5d0a3 Mon Sep 17 00:00:00 2001 From: sunyuechi <sunyuechi@iscas.ac.cn> Date: Wed, 20 Dec 2023 16:17:32 +0800 Subject: [PATCH 1/3] lavc/dnxhdenc: add ff_dnxhdenc_init This is for clarity and use in testing, consistent with other parts of the code. --- libavcodec/dnxhdenc.c | 11 ++++++++--- libavcodec/dnxhdenc.h | 1 + 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index f52a2e9918..0d9727bbbf 100644 --- a/libavcodec/dnxhdenc.c +++ b/libavcodec/dnxhdenc.c @@ -445,9 +445,7 @@ static av_cold int dnxhd_encode_init(AVCodecContext *avctx) ctx->block_width_l2 = 3; } -#if ARCH_X86 - ff_dnxhdenc_init_x86(ctx); -#endif + ff_dnxhdenc_init(ctx); ctx->m.mb_height = (avctx->height + 15) / 16; ctx->m.mb_width = (avctx->width + 15) / 16; @@ -1377,3 +1375,10 @@ const FFCodec ff_dnxhd_encoder = { .p.profiles = NULL_IF_CONFIG_SMALL(ff_dnxhd_profiles), .caps_internal = FF_CODEC_CAP_INIT_CLEANUP, }; + +void ff_dnxhdenc_init(DNXHDEncContext *ctx) +{ +#if ARCH_X86 + ff_dnxhdenc_init_x86(ctx); +#endif +} diff --git a/libavcodec/dnxhdenc.h b/libavcodec/dnxhdenc.h index e581312ce4..95aea83d28 100644 --- a/libavcodec/dnxhdenc.h +++ b/libavcodec/dnxhdenc.h @@ -111,6 +111,7 @@ typedef struct DNXHDEncContext { const uint8_t *pixels, ptrdiff_t line_size); } DNXHDEncContext; +void ff_dnxhdenc_init(DNXHDEncContext *ctx); void ff_dnxhdenc_init_x86(DNXHDEncContext *ctx); #endif /* AVCODEC_DNXHDENC_H */ -- 2.43.0 [-- Attachment #3: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-20 10:13 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-12-20 8:39 [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init flow gg 2023-12-20 9:51 ` Anton Khirnov 2023-12-20 10:12 ` flow gg
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git