* [FFmpeg-devel] [PATCH 2/6] checkasm/takdsp: add decorrelate_sr test
@ 2023-12-18 15:14 flow gg
2023-12-22 9:47 ` Martin Storsjö
0 siblings, 1 reply; 2+ messages in thread
From: flow gg @ 2023-12-18 15:14 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: 0002-checkasm-takdsp-add-decorrelate_sr-test.patch --]
[-- Type: text/x-patch, Size: 1444 bytes --]
From 9254ae1f72498568857357059eb514e8cb90b5f1 Mon Sep 17 00:00:00 2001
From: sunyuechi <sunyuechi@iscas.ac.cn>
Date: Mon, 18 Dec 2023 22:47:29 +0800
Subject: [PATCH 2/6] checkasm/takdsp: add decorrelate_sr test
---
tests/checkasm/takdsp.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/tests/checkasm/takdsp.c b/tests/checkasm/takdsp.c
index 4c7442f922..2fa639bfc1 100644
--- a/tests/checkasm/takdsp.c
+++ b/tests/checkasm/takdsp.c
@@ -59,10 +59,37 @@ static void test_decorrelate_ls(TAKDSPContext *s) {
report("decorrelate_ls");
}
+static void test_decorrelate_sr(TAKDSPContext *s) {
+#define BUF_SIZE 1024
+ declare_func(void, int32_t *, int32_t *, int);
+
+ if (check_func(s->decorrelate_sr, "decorrelate_sr")) {
+ LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
+ LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]);
+ LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]);
+
+ randomize(p1, BUF_SIZE);
+ randomize(p2, BUF_SIZE);
+ memcpy(p2_2, p2, BUF_SIZE);
+
+ call_ref(p1, p2, BUF_SIZE);
+ call_new(p1, p2_2, BUF_SIZE);
+
+ if (memcmp(p2, p2_2, BUF_SIZE) != 0){
+ fail();
+ }
+
+ bench_new(p1, p2, BUF_SIZE);
+ }
+
+ report("decorrelate_sr");
+}
+
void checkasm_check_takdsp(void)
{
TAKDSPContext s = { 0 };
ff_takdsp_init(&s);
test_decorrelate_ls(&s);
+ test_decorrelate_sr(&s);
}
--
2.43.0
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/6] checkasm/takdsp: add decorrelate_sr test
2023-12-18 15:14 [FFmpeg-devel] [PATCH 2/6] checkasm/takdsp: add decorrelate_sr test flow gg
@ 2023-12-22 9:47 ` Martin Storsjö
0 siblings, 0 replies; 2+ messages in thread
From: Martin Storsjö @ 2023-12-22 9:47 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Mon, 18 Dec 2023, flow gg wrote:
>
> +static void test_decorrelate_sr(TAKDSPContext *s) {
> +#define BUF_SIZE 1024
> + declare_func(void, int32_t *, int32_t *, int);
> +
> + if (check_func(s->decorrelate_sr, "decorrelate_sr")) {
> + LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
> + LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]);
> + LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]);
> +
> + randomize(p1, BUF_SIZE);
> + randomize(p2, BUF_SIZE);
> + memcpy(p2_2, p2, BUF_SIZE);
> +
> + call_ref(p1, p2, BUF_SIZE);
> + call_new(p1, p2_2, BUF_SIZE);
> +
> + if (memcmp(p2, p2_2, BUF_SIZE) != 0){
> + fail();
> + }
This function mutates p1, not p2, so p1 is the one that needs to be copied
and checked, and memcpy/memcmp need a *sizeof().
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-22 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-18 15:14 [FFmpeg-devel] [PATCH 2/6] checkasm/takdsp: add decorrelate_sr test flow gg
2023-12-22 9:47 ` Martin Storsjö
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git