From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E308847800 for ; Wed, 22 Nov 2023 16:38:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D158A68CEDF; Wed, 22 Nov 2023 18:37:59 +0200 (EET) Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C93DD68CDEB for ; Wed, 22 Nov 2023 18:37:53 +0200 (EET) Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-67089696545so75996d6.0 for ; Wed, 22 Nov 2023 08:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700671072; x=1701275872; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=DvVco8AcgXFoCjEcolJGPHLDuOdbzGBEaAMO/lzEkEM=; b=SPMVxhZS2R8UFz/Jqsn+WDz2eXDFRJi/uBbkVnJOFwe5EU8TVIMuGRVDB/SRZPJXl8 PUiaqoKKVjPryRQOjGwXyhha5CIVMo22YQGjDRGbjso1qmvSDI/rYfVppsBOPZWqDkk3 0VUzSUwOGL3dGZrLUVNsP7/oXX9KeI61WeBuwL4GgZ1j9nxEic+mRQl2kFA0fGRFW+/K 4yh+2/2qzEzbITKNB9NeyzXHHKt+dX7luEQ+LtSJ9ay9N/SyBPEv6WCprdyfD+BgW629 YWwGuuk+cmNB4u7d5j30UdPFG0wq9XeU9UUXoOjKjnIbnbcvg0UkNhJoSSo/UFRZICMA jMag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700671072; x=1701275872; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DvVco8AcgXFoCjEcolJGPHLDuOdbzGBEaAMO/lzEkEM=; b=qxI+LVyFsE9xUqalIW41lwFVZfQTcUmOl1UupoNVcLW/6GNAvaLpj05mgOHWKOAuvK ez6CO4k5r3hViyMPpIwK3TUn1qPClYsY8NTPatq5TvZQbp41J3FemJzZjh2nACPUBz0k OfXlSDdXtEzQCYU4HiqxvoHDZDtyfUr0WuFqefuVrSGUgIEjNDLW6C4zFOMI5DCeul88 cipJcehtu4COzLOD4txcU1J7TC+y2v6G8w1inB5Oks4LO7uaeJaqWRZ7NUgTzfJgRIRW 0XRsWNfOGuQ7YJxNhOiKG/QrSd4DBsuBWQQip9HNIfWAZSNiab77IcJV5qseDzsG0on+ 3PqQ== X-Gm-Message-State: AOJu0YxV6gxCz5R0P9ttXkIHcso9+lFjTJ7CZZ0+NrxU2KOnwvz2YgNm U4sAHzPtmardmeAQFhvmnFC7IGhfJxsgJi0MxMkgwhxCKSoRUA== X-Google-Smtp-Source: AGHT+IEbFH0HrywOC9ppyR6tLEhwpoewmKD3MnFpPC5qrWx7io5YeyM2OMv1vb1hB72FDAECaxZcglKKX5J+eYlMrc8= X-Received: by 2002:a05:6214:300f:b0:679:f448:9a9 with SMTP id ke15-20020a056214300f00b00679f44809a9mr3055490qvb.29.1700671072078; Wed, 22 Nov 2023 08:37:52 -0800 (PST) MIME-Version: 1.0 References: <502DD795-A076-42CF-94EA-11B198219668@remlab.net> In-Reply-To: From: flow gg Date: Thu, 23 Nov 2023 00:37:41 +0800 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="00000000000021f463060ac057ed" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --00000000000021f463060ac057ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you for your guidance, I finally understand.. How about choosing manual zero-extension for rv64? I modified the patch. #if (__riscv_xlen =3D=3D 64) slli a2, a2, 32 srli a2, a2, 32 #endif R=C3=A9mi Denis-Courmont =E4=BA=8E2023=E5=B9=B411=E6=9C= =8822=E6=97=A5=E5=91=A8=E4=B8=89 22:51=E5=86=99=E9=81=93=EF=BC=9A > > > Le 22 novembre 2023 16:30:44 GMT+02:00, flow gg a > =C3=A9crit : > >> How did you test it? > > > >I wrote a test, but it was a bit rough, so I want to modify it before > >submitting. I've added it to this reply. > > > >> This does not seem according to the C ABI. AFAIK `unsigned` is > >sign-extended. > > > >I'm a bit confused... because this passed in the tests I wrote in qemu. > >Maybe there's a problem with my test=EF=BC=9F > > You probably didn't test sizes between 2^31 and 2^32-1. This might not > even be feasible in QEMU. > > Ideally the prototype would use size_t, then the problem wouldn't exist. > > > > >> ALU right before dependent conditional branch should be avoided. > > > >Should the sub be moved forward? I've modified it. > > > >> SHxADD can be used advantageously. > > > >Okay, I've made the modification > > > >R=C3=A9mi Denis-Courmont =E4=BA=8E2023=E5=B9=B411=E6= =9C=8822=E6=97=A5=E5=91=A8=E4=B8=89 21:41=E5=86=99=E9=81=93=EF=BC=9A > > > >> Hi, > >> > >> How did you test it? As per > >> http://ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310720.html we stil= l > >> don't have a FATE instance set up with the RISC-V Vector extension. Th= e > >> only testing consists of my manual runs of checkasm on a K230 board. (= We > >> *do* have Zba and Zbb now though, hence the existing > extract_exponents()). > >> > >> Also: > >> - This does not seem according to the C ABI. AFAIK `unsigned` is > >> sign-extended. > >> - ALU right before dependent conditional branch should be avoided. > >> - SHxADD can be used advantageously. > >> > >> > >> Le 22 novembre 2023 14:00:07 GMT+02:00, flow gg > a > >> =C3=A9crit : > >> >c910 > >> > float_to_fixed24_c: 208.2 > >> > float_to_fixed24_rvv_f32: 71.5 > >> _______________________________________________ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> To unsubscribe, visit link above, or email > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > --00000000000021f463060ac057ed Content-Type: text/x-patch; charset="US-ASCII"; name="lavc-ac3dsp-R-V-V-float_to_fixed24.patch" Content-Disposition: attachment; filename="lavc-ac3dsp-R-V-V-float_to_fixed24.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lp9zm7gk0 RnJvbSBkNzA5NTE5MjE5MTM4Yjc0NmZmNjIyYjE1YmIwMDRiMjdlZWQ3MzMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdW55dWVjaGkgPHN1bnl1ZWNoaUBpc2Nhcy5hYy5jbj4KRGF0 ZTogV2VkLCAyMiBOb3YgMjAyMyAxNDo1NzoyOSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGxhdmMv YWMzZHNwOiBSLVYgViBmbG9hdF90b19maXhlZDI0CgpjOTEwCiAgICBmbG9hdF90b19maXhlZDI0 X2M6IDIwOC4yCiAgICBmbG9hdF90b19maXhlZDI0X3J2dl9mMzI6IDcxLjUKLS0tCiBsaWJhdmNv ZGVjL3Jpc2N2L01ha2VmaWxlICAgICAgfCAgMyArKy0KIGxpYmF2Y29kZWMvcmlzY3YvYWMzZHNw X2luaXQuYyB8ICA1ICsrKysKIGxpYmF2Y29kZWMvcmlzY3YvYWMzZHNwX3J2di5TICB8IDQ1ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNTIgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGxpYmF2Y29kZWMv cmlzY3YvYWMzZHNwX3J2di5TCgpkaWZmIC0tZ2l0IGEvbGliYXZjb2RlYy9yaXNjdi9NYWtlZmls ZSBiL2xpYmF2Y29kZWMvcmlzY3YvTWFrZWZpbGUKaW5kZXggOGYyYTUxOTgyNy4uYWM3YjdjMjky OSAxMDA2NDQKLS0tIGEvbGliYXZjb2RlYy9yaXNjdi9NYWtlZmlsZQorKysgYi9saWJhdmNvZGVj L3Jpc2N2L01ha2VmaWxlCkBAIC0xLDcgKzEsOCBAQAogT0JKUy0kKENPTkZJR19BQUNfREVDT0RF UikgKz0gcmlzY3YvYWFjcHNkc3BfaW5pdC5vIHJpc2N2L3NicmRzcF9pbml0Lm8KIFJWVi1PQkpT LSQoQ09ORklHX0FBQ19ERUNPREVSKSArPSByaXNjdi9hYWNwc2RzcF9ydnYubyByaXNjdi9zYnJk c3BfcnZ2Lm8KIE9CSlMtJChDT05GSUdfQUMzRFNQKSArPSByaXNjdi9hYzNkc3BfaW5pdC5vIFwK LSAgICAgICAgICAgICAgICAgICAgICAgICByaXNjdi9hYzNkc3BfcnZiLm8KKyAgICAgICAgICAg ICAgICAgICAgICAgICByaXNjdi9hYzNkc3BfcnZiLm8gXAorICAgICAgICAgICAgICAgICAgICAg ICAgIHJpc2N2L2FjM2RzcF9ydnYubwogT0JKUy0kKENPTkZJR19BTEFDX0RFQ09ERVIpICs9IHJp c2N2L2FsYWNkc3BfaW5pdC5vCiBSVlYtT0JKUy0kKENPTkZJR19BTEFDX0RFQ09ERVIpICs9IHJp c2N2L2FsYWNkc3BfcnZ2Lm8KIE9CSlMtJChDT05GSUdfQVVESU9EU1ApICs9IHJpc2N2L2F1ZGlv ZHNwX2luaXQubyBcCmRpZmYgLS1naXQgYS9saWJhdmNvZGVjL3Jpc2N2L2FjM2RzcF9pbml0LmMg Yi9saWJhdmNvZGVjL3Jpc2N2L2FjM2RzcF9pbml0LmMKaW5kZXggMjBmMjk0ZjFkZS4uZGU4MmQx YzdhNyAxMDA2NDQKLS0tIGEvbGliYXZjb2RlYy9yaXNjdi9hYzNkc3BfaW5pdC5jCisrKyBiL2xp YmF2Y29kZWMvcmlzY3YvYWMzZHNwX2luaXQuYwpAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUg ImxpYmF2Y29kZWMvYWMzZHNwLmgiCiAKIHZvaWQgZmZfZXh0cmFjdF9leHBvbmVudHNfcnZiKHVp bnQ4X3QgKmV4cCwgaW50MzJfdCAqY29lZiwgaW50IG5iX2NvZWZzKTsKK3ZvaWQgZmZfZmxvYXRf dG9fZml4ZWQyNF9ydnYoaW50MzJfdCAqZHN0LCBjb25zdCBmbG9hdCAqc3JjLCB1bnNpZ25lZCBp bnQgbGVuKTsKIAogYXZfY29sZCB2b2lkIGZmX2FjM2RzcF9pbml0X3Jpc2N2KEFDM0RTUENvbnRl eHQgKmMpCiB7CkBAIC0zNSw0ICszNiw4IEBAIGF2X2NvbGQgdm9pZCBmZl9hYzNkc3BfaW5pdF9y aXNjdihBQzNEU1BDb250ZXh0ICpjKQogICAgICAgICBpZiAoZmxhZ3MgJiBBVl9DUFVfRkxBR19S VkJfQkFTSUMpCiAgICAgICAgICAgICBjLT5leHRyYWN0X2V4cG9uZW50cyA9IGZmX2V4dHJhY3Rf ZXhwb25lbnRzX3J2YjsKICAgICB9CisKKyAgICBpZiAoZmxhZ3MgJiBBVl9DUFVfRkxBR19SVlZf RjMyKSB7CisgICAgICAgIGMtPmZsb2F0X3RvX2ZpeGVkMjQgPSBmZl9mbG9hdF90b19maXhlZDI0 X3J2djsKKyAgICB9CiB9CmRpZmYgLS1naXQgYS9saWJhdmNvZGVjL3Jpc2N2L2FjM2RzcF9ydnYu UyBiL2xpYmF2Y29kZWMvcmlzY3YvYWMzZHNwX3J2di5TCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAuLjRkNGE1NjY2NTkKLS0tIC9kZXYvbnVsbAorKysgYi9saWJhdmNvZGVj L3Jpc2N2L2FjM2RzcF9ydnYuUwpAQCAtMCwwICsxLDQ1IEBACisvKgorICogQ29weXJpZ2h0IChj KSAyMDIzIEluc3RpdHVlIG9mIFNvZnR3YXJlIENoaW5lc2UgQWNhZGVteSBvZiBTY2llbmNlcyAo SVNDQVMpLgorICoKKyAqIFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEZGbXBlZy4KKyAqCisgKiBGRm1w ZWcgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBt b2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGlj CisgKiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9u OyBlaXRoZXIKKyAqIHZlcnNpb24gMi4xIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRp b24pIGFueSBsYXRlciB2ZXJzaW9uLgorICoKKyAqIEZGbXBlZyBpcyBkaXN0cmlidXRlZCBpbiB0 aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJB TlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJ TElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisg KiBMZXNzZXIgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAq IFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJh bCBQdWJsaWMKKyAqIExpY2Vuc2UgYWxvbmcgd2l0aCBGRm1wZWc7IGlmIG5vdCwgd3JpdGUgdG8g dGhlIEZyZWUgU29mdHdhcmUKKyAqIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVl dCwgRmlmdGggRmxvb3IsIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSBVU0EKKyAqLworCisjaW5jbHVk ZSAiY29uZmlnLmgiCisjaW5jbHVkZSAibGliYXZ1dGlsL3Jpc2N2L2FzbS5TIgorCitmdW5jIGZm X2Zsb2F0X3RvX2ZpeGVkMjRfcnZ2LCB6dmUzMmYKKyAgICAgICAgbGkgICAgICAgICAgICB0MSwg MSA8PCAyNAorICAgICAgICBmY3Z0LnMudyAgICAgIGYwLCB0MQorCisjaWYgKF9fcmlzY3ZfeGxl biA9PSA2NCkKKyAgICAgICAgc2xsaSBhMiwgYTIsIDMyCisgICAgICAgIHNybGkgYTIsIGEyLCAz MgorI2VuZGlmCisKKzE6CisgICAgICAgIHZzZXR2bGkgICAgICAgdDAsIGEyLCBlMzIsIG00LCB0 YSwgbWEKKyAgICAgICAgc3ViICAgICAgICAgICBhMiwgYTIsIHQwCisgICAgICAgIHZsZTMyLnYg ICAgICAgdjAsIChhMSkKKyAgICAgICAgdmZtdWwudmYgICAgICB2MCwgdjAsIGYwCisgICAgICAg IHZmY3Z0LnguZi52ICAgdjAsIHYwCisgICAgICAgIHNoMmFkZCAgICAgICAgYTEsIHQwLCBhMQor ICAgICAgICB2c2UzMi52ICAgICAgIHYwLCAoYTApCisgICAgICAgIHNoMmFkZCAgICAgICAgYTAs IHQwLCBhMAorICAgICAgICBiZ3R6ICAgICAgICAgIGEyLCAxYgorCisgICAgICAgIHJldAorZW5k ZnVuYwotLSAKMi40My4wCgo= --00000000000021f463060ac057ed Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --00000000000021f463060ac057ed--