From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1743D482FD for ; Thu, 23 Nov 2023 22:44:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 012E368CEEC; Fri, 24 Nov 2023 00:44:54 +0200 (EET) Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 612E068C449 for ; Fri, 24 Nov 2023 00:44:48 +0200 (EET) Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-67a109e3b11so1671686d6.0 for ; Thu, 23 Nov 2023 14:44:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700779487; x=1701384287; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=71shplmk/bDFYDwbtPA6lKshkmaxl7PLju5+Tt8gMlo=; b=ibnWEqkVY0m0lUF5tY79rw6Hq99d8/YXSFdg6dB3pKRFZ6AoCQbDxWsSsVFuFOCv/O XIh2c3Oa0wwr8by/LCmXRb6TBGFZ0su+bJL6pAsugM6x8AT152sAyI1FsJdUW0EimT5u CklSQDjSmeXFo4fuL6ZSaLTkY27jN5LGHQnp3BdbIajsSLOYwa/RIjoFVsx6H1kwlFrX lq1GYhGt1K2vD5TCr43UQ4w1o2hwJ1RFYx4RbMIUvabbffnijIEiCMIwGn9xEIZ5jNM+ zSjVadLtVFQQB+HQWi25V4Av87w54kEQHBjrN/dPoe97AbbF/dHGJOjhv4u/H3O532Im Z/Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700779487; x=1701384287; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=71shplmk/bDFYDwbtPA6lKshkmaxl7PLju5+Tt8gMlo=; b=FnTPAfxXh4Sf8sMnzA2SNKzhuNXg20DIKzb0ZNAAJiD4B4A6VH7cS5f3xmyaY5gMcB 9uAZbu6SuQZelQw3XAMwvmsDjArgyZCNY+oqtojyBUGK9lCaXoWZIhNix8NntjvRvGTp rEnB5MBFBV5tuoQz3Kc/n33XrqeFkb6ttO3sgbs0juO/Is2ZSnKGH/keM3aFbNsv5PHy mPUP5JEtxENnG9OIN0xco+Cj9z/JqZuqdIqesSbmR53I9EQR842LRU3v3R3S7EHmKd0S Dr40ArT8gWkifiMgODRudh8uKO+NmHCmxVxBTrois4wm8qJUOwB3e8Me8l0f4Gpr1GdC a+BA== X-Gm-Message-State: AOJu0Yx3k78h7ucHw1s9XiHcH9b+oYHmbRRMmhk84p5DmMKWYEiBVUBf Xgh0bhtTTW+HOWvyYw924i30PhUMLk/Ah+Mq+c+H7UCqQGheRGOg2Lw= X-Google-Smtp-Source: AGHT+IF3WQI60myw211vMcRH5Kjfgxq/0wc1lcGPiJj9hzvbdI0kX9NvhMY3MLHXhTBHCFYM5+hkMa7jzC2gsr4p/d8= X-Received: by 2002:a05:6214:1791:b0:66f:afe3:1ef7 with SMTP id ct17-20020a056214179100b0066fafe31ef7mr1044647qvb.12.1700779486921; Thu, 23 Nov 2023 14:44:46 -0800 (PST) MIME-Version: 1.0 References: <72e2f13b-0bc9-46cb-bda5-1058f551ac0e@gmail.com> In-Reply-To: <72e2f13b-0bc9-46cb-bda5-1058f551ac0e@gmail.com> From: flow gg Date: Fri, 24 Nov 2023 06:44:36 +0800 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="0000000000002901f1060ad99509" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] checkasm/ac3dsp: add float_to_fixed24 test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --0000000000002901f1060ad99509 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > You should probably add the test case to tests/fate/checkasm.mak > This one is not necessary. You can reuse dst or dst2 for the bench() as it's write only. > Changed BUF_SIZE instead of 10. Okay, changed. James Almer =E4=BA=8E2023=E5=B9=B411=E6=9C=8824=E6=97= =A5=E5=91=A8=E4=BA=94 01:11=E5=86=99=E9=81=93=EF=BC=9A > On 11/23/2023 4:08 AM, flow gg wrote: > > +static void check_float_to_fixed24(AC3DSPContext *c) { > > +#define BUF_SIZE 1024 > > + LOCAL_ALIGNED_32(int32_t, v1, [BUF_SIZE]); > > This one is not necessary. You can reuse dst or dst2 for the bench() as > it's write only. > > > + LOCAL_ALIGNED_32(float, v2, [BUF_SIZE]); > > + > > + declare_func(void, int32_t *, const float *, unsigned int); > > + > > + randomize_float(v2, BUF_SIZE); > > + > > + if (check_func(c->float_to_fixed24, "float_to_fixed24")) { > > + LOCAL_ALIGNED_32(int32_t, dst, [BUF_SIZE]); > > + LOCAL_ALIGNED_32(int32_t, dst2, [BUF_SIZE]); > > + > > + call_ref(dst, v2, BUF_SIZE); > > + call_new(dst2, v2, BUF_SIZE); > > + > > + if (memcmp(dst, dst2, sizeof(*dst) * 10) !=3D 0) > > BUF_SIZE instead of 10. > > > + fail(); > > + > > + bench_new(v1, v2, BUF_SIZE); > > + } > > + > > + > > + report("float_to_fixed24"); > > +} > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > --0000000000002901f1060ad99509 Content-Type: text/x-patch; charset="US-ASCII"; name="checkasm-ac3dsp-add-float_to_fixed24-test.patch" Content-Disposition: attachment; filename="checkasm-ac3dsp-add-float_to_fixed24-test.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lpbs6jdo0 RnJvbSBkNWJmYmVjZGQzMmRkYTA4MzkzODdkNDcwZmVlNzJiNjE1NWYwODRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdW55dWVjaGkgPHN1bnl1ZWNoaUBpc2Nhcy5hYy5jbj4KRGF0 ZTogV2VkLCAyMiBOb3YgMjAyMyAxNDo1NzoyOSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGNoZWNr YXNtL2FjM2RzcDogYWRkIGZsb2F0X3RvX2ZpeGVkMjQgdGVzdAoKLS0tCiB0ZXN0cy9jaGVja2Fz bS9NYWtlZmlsZSAgIHwgIDEgKwogdGVzdHMvY2hlY2thc20vYWMzZHNwLmMgICB8IDcwICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogdGVzdHMvY2hlY2thc20vY2hlY2th c20uYyB8ICAzICsrCiB0ZXN0cy9jaGVja2FzbS9jaGVja2FzbS5oIHwgIDEgKwogdGVzdHMvZmF0 ZS9jaGVja2FzbS5tYWsgICB8ICAxICsKIDUgZmlsZXMgY2hhbmdlZCwgNzYgaW5zZXJ0aW9ucygr KQogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3RzL2NoZWNrYXNtL2FjM2RzcC5jCgpkaWZmIC0tZ2l0 IGEvdGVzdHMvY2hlY2thc20vTWFrZWZpbGUgYi90ZXN0cy9jaGVja2FzbS9NYWtlZmlsZQppbmRl eCA4YmMyNDFkMjliLi41Mzc0MmM5M2FlIDEwMDY0NAotLS0gYS90ZXN0cy9jaGVja2FzbS9NYWtl ZmlsZQorKysgYi90ZXN0cy9jaGVja2FzbS9NYWtlZmlsZQpAQCAtMSw1ICsxLDYgQEAKICMgbGli YXZjb2RlYyB0ZXN0cwogIyBzdWJzeXN0ZW1zCitBVkNPREVDT0JKUy0kKENPTkZJR19BQzNEU1Ap ICAgICAgICAgICAgKz0gYWMzZHNwLm8KIEFWQ09ERUNPQkpTLSQoQ09ORklHX0FVRElPRFNQKSAg ICAgICAgICArPSBhdWRpb2RzcC5vCiBBVkNPREVDT0JKUy0kKENPTkZJR19CTE9DS0RTUCkgICAg ICAgICAgKz0gYmxvY2tkc3AubwogQVZDT0RFQ09CSlMtJChDT05GSUdfQlNXQVBEU1ApICAgICAg ICAgICs9IGJzd2FwZHNwLm8KZGlmZiAtLWdpdCBhL3Rlc3RzL2NoZWNrYXNtL2FjM2RzcC5jIGIv dGVzdHMvY2hlY2thc20vYWMzZHNwLmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMC4uOGYzNmYxNzM2YwotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3RzL2NoZWNrYXNtL2FjM2Rz cC5jCkBAIC0wLDAgKzEsNzAgQEAKKy8qCisgKiBDb3B5cmlnaHQgKGMpIDIwMjMgSW5zdGl0dWUg b2YgU29mdHdhcmUgQ2hpbmVzZSBBY2FkZW15IG9mIFNjaWVuY2VzIChJU0NBUykuCisgKgorICog VGhpcyBmaWxlIGlzIHBhcnQgb2YgRkZtcGVnLgorICoKKyAqIEZGbXBlZyBpcyBmcmVlIHNvZnR3 YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisgKiBpdCB1bmRlciB0 aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBi eQorICogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24gMiBvZiB0 aGUgTGljZW5zZSwgb3IKKyAqIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisg KgorICogRkZtcGVnIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1 c2VmdWwsCisgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1w bGllZCB3YXJyYW50eSBvZgorICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFS VElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQorICogR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2Ug Zm9yIG1vcmUgZGV0YWlscy4KKyAqCisgKiBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5 IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhbG9uZworICogd2l0aCBGRm1wZWc7 IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLiwKKyAq IDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsIEJvc3RvbiwgTUEgMDIxMTAtMTMwMSBV U0EuCisgKi8KKworI2luY2x1ZGUgPHN0cmluZy5oPgorCisjaW5jbHVkZSAibGliYXZ1dGlsL21l bS5oIgorI2luY2x1ZGUgImxpYmF2dXRpbC9tZW1faW50ZXJuYWwuaCIKKworI2luY2x1ZGUgImxp YmF2Y29kZWMvYWMzZHNwLmgiCisKKyNpbmNsdWRlICJjaGVja2FzbS5oIgorCisjZGVmaW5lIHJh bmRvbWl6ZV9mbG9hdChidWYsIGxlbikgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAor ICAgIGRvIHsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFwKKyAgICAgICAgaW50IGk7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBcCisgICAgICAgIGZvciAoaSA9IDA7IGkgPCBsZW47IGkrKykgeyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICAgICAgZmxvYXQgZiA9IChmbG9h dClybmQoKSAvIChVSU5UX01BWCA+PiA1KSAtIDE2LjBmOyAgIFwKKyAgICAgICAgICAgIGJ1Zltp XSA9IGY7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCisgICAgICAg IH0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XAorICAgIH0gd2hpbGUgKDApCisKK3N0YXRpYyB2b2lkIGNoZWNrX2Zsb2F0X3RvX2ZpeGVkMjQo QUMzRFNQQ29udGV4dCAqYykgeworI2RlZmluZSBCVUZfU0laRSAxMDI0CisgICAgTE9DQUxfQUxJ R05FRF8zMihmbG9hdCwgc3JjLCBbQlVGX1NJWkVdKTsKKworICAgIGRlY2xhcmVfZnVuYyh2b2lk LCBpbnQzMl90ICosIGNvbnN0IGZsb2F0ICosIHVuc2lnbmVkIGludCk7CisKKyAgICByYW5kb21p emVfZmxvYXQoc3JjLCBCVUZfU0laRSk7CisKKyAgICBpZiAoY2hlY2tfZnVuYyhjLT5mbG9hdF90 b19maXhlZDI0LCAiZmxvYXRfdG9fZml4ZWQyNCIpKSB7CisgICAgICAgIExPQ0FMX0FMSUdORURf MzIoaW50MzJfdCwgZHN0LCBbQlVGX1NJWkVdKTsKKyAgICAgICAgTE9DQUxfQUxJR05FRF8zMihp bnQzMl90LCBkc3QyLCBbQlVGX1NJWkVdKTsKKworICAgICAgICBjYWxsX3JlZihkc3QsIHNyYywg QlVGX1NJWkUpOworICAgICAgICBjYWxsX25ldyhkc3QyLCBzcmMsIEJVRl9TSVpFKTsKKworICAg ICAgICBpZiAobWVtY21wKGRzdCwgZHN0MiwgQlVGX1NJWkUpICE9IDApCisgICAgICAgICAgICBm YWlsKCk7CisKKyAgICAgICAgYmVuY2hfbmV3KGRzdCwgc3JjLCBCVUZfU0laRSk7CisgICAgfQor CisKKyAgICByZXBvcnQoImZsb2F0X3RvX2ZpeGVkMjQiKTsKK30KKwordm9pZCBjaGVja2FzbV9j aGVja19hYzNkc3Aodm9pZCkKK3sKKyAgICBBQzNEU1BDb250ZXh0IGM7CisgICAgZmZfYWMzZHNw X2luaXQoJmMpOworCisgICAgY2hlY2tfZmxvYXRfdG9fZml4ZWQyNCgmYyk7Cit9CmRpZmYgLS1n aXQgYS90ZXN0cy9jaGVja2FzbS9jaGVja2FzbS5jIGIvdGVzdHMvY2hlY2thc20vY2hlY2thc20u YwppbmRleCA3MDgxMTllN2M2Li5mMzdjN2ZhZDNhIDEwMDY0NAotLS0gYS90ZXN0cy9jaGVja2Fz bS9jaGVja2FzbS5jCisrKyBiL3Rlc3RzL2NoZWNrYXNtL2NoZWNrYXNtLmMKQEAgLTc4LDYgKzc4 LDkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB7CiAgICAgICAgIHsgImFhY3BzZHNwIiwgY2hlY2th c21fY2hlY2tfYWFjcHNkc3AgfSwKICAgICAgICAgeyAic2JyZHNwIiwgICBjaGVja2FzbV9jaGVj a19zYnJkc3AgfSwKICAgICAjZW5kaWYKKyAgICAjaWYgQ09ORklHX0FDM0RTUAorICAgICAgICB7 ICJhYzNkc3AiLCBjaGVja2FzbV9jaGVja19hYzNkc3AgfSwKKyAgICAjZW5kaWYKICAgICAjaWYg Q09ORklHX0FMQUNfREVDT0RFUgogICAgICAgICB7ICJhbGFjZHNwIiwgY2hlY2thc21fY2hlY2tf YWxhY2RzcCB9LAogICAgICNlbmRpZgpkaWZmIC0tZ2l0IGEvdGVzdHMvY2hlY2thc20vY2hlY2th c20uaCBiL3Rlc3RzL2NoZWNrYXNtL2NoZWNrYXNtLmgKaW5kZXggY2ZlYTg2OGZmMS4uYTQyMzhi MWRmYSAxMDA2NDQKLS0tIGEvdGVzdHMvY2hlY2thc20vY2hlY2thc20uaAorKysgYi90ZXN0cy9j aGVja2FzbS9jaGVja2FzbS5oCkBAIC00Myw2ICs0Myw3IEBACiAjaW5jbHVkZSAibGliYXZ1dGls L3RpbWVyLmgiCiAKIHZvaWQgY2hlY2thc21fY2hlY2tfYWFjcHNkc3Aodm9pZCk7Cit2b2lkIGNo ZWNrYXNtX2NoZWNrX2FjM2RzcCh2b2lkKTsKIHZvaWQgY2hlY2thc21fY2hlY2tfYWZpcih2b2lk KTsKIHZvaWQgY2hlY2thc21fY2hlY2tfYWxhY2RzcCh2b2lkKTsKIHZvaWQgY2hlY2thc21fY2hl Y2tfYXVkaW9kc3Aodm9pZCk7CmRpZmYgLS1naXQgYS90ZXN0cy9mYXRlL2NoZWNrYXNtLm1hayBi L3Rlc3RzL2ZhdGUvY2hlY2thc20ubWFrCmluZGV4IDM1ZmYxMjc3YmEuLjFjOGI3YzBhMjUgMTAw NjQ0Ci0tLSBhL3Rlc3RzL2ZhdGUvY2hlY2thc20ubWFrCisrKyBiL3Rlc3RzL2ZhdGUvY2hlY2th c20ubWFrCkBAIC0xLDQgKzEsNSBAQAogRkFURV9DSEVDS0FTTSA9IGZhdGUtY2hlY2thc20tYWFj cHNkc3AgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICAgICAgICAg IGZhdGUtY2hlY2thc20tYWMzZHNwICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XAogICAgICAgICAgICAgICAgIGZhdGUtY2hlY2thc20tYWZfYWZpciAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgICAgIGZhdGUtY2hlY2thc20tYWxhY2Rz cCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgICAgIGZh dGUtY2hlY2thc20tYXVkaW9kc3AgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAot LSAKMi40My4wCgo= --0000000000002901f1060ad99509 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --0000000000002901f1060ad99509--