From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CA500488DD for ; Wed, 20 Dec 2023 10:13:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4C37268D1EA; Wed, 20 Dec 2023 12:13:15 +0200 (EET) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 886DA68D17B for ; Wed, 20 Dec 2023 12:13:09 +0200 (EET) Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-77f642b9a22so43554685a.0 for ; Wed, 20 Dec 2023 02:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703067188; x=1703671988; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=jhE/A6GPllG49f8+5j3zENac5DD4x1WEqCgY9BTJGUk=; b=W4gnEmEINsJUWiNG/D1JBCq+NulC6MjuujXXvlCYvN+00y7VUQnD4pqbEYMvZtKQYJ u6Ja+gRYduceUwEJvrUN7u4k630jshY2cIqcphi5LR2QScqZgd9VtupAnchVOgAhSZM3 kxVhxGf7Fb0br4MblNMnj0qVFeMwl6zrQnbAaX65PVvl7MxglCFNKNTi9MZKVEEGcYQU UQ2P6/ZkGx/oqDUmHuSP13MXHbXoEFvP0fxZ6kuK0a7gIOxd/BuWto8S8dUzillo3L2y bDQuZuc55IttaN5UCGDqNAQEprpSE6Poi29Qa+bLiBL5MOwjhR6U47vSE06DObbWYaWS RNXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703067188; x=1703671988; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jhE/A6GPllG49f8+5j3zENac5DD4x1WEqCgY9BTJGUk=; b=aUElVs3EElihta9T+sFtdMTGszhGnVy5PAOhb/Il5siHHfSkWGzGWgt3mSHLG6JoqN LqY9J8IUsSy6XsZVIaCsnX+/G2RRMeselAB0aQdEg9DGZqcmXWISe2wCWmRkFm8B2+Bc gShkamCwbRFerNG613foxlUqdrpapAZMMiQC/pt4fQL+9HAVIJgQiTW13nGO9M6kG6f0 TJiiLYSmtC3L37QGQEFbYl881TpFGK2pOpRfCIUvoLkV9AQHX513Wsu12DXVZNQILuVj 2UEvl5ROf3pJ07R0JtbBxaQDH8jpxZPSTSLWY6G0nfh5whS85iIngkTj8twE2ZUOtvbs itCg== X-Gm-Message-State: AOJu0YysxCVUfwkwesOnn3K/aLCUrlYkSBmq6OdkV1VZ43XwtUo2sI4M xmmNZXoVSSyN/gyfEwWfDQWzimI1M52sD9DBhjT+LOqSHuyVm6hP X-Google-Smtp-Source: AGHT+IFwc0xnBMj4L6Nxkhkd/VMPl6ssVI3sCGfOgLd82I4Nx6Vdhqz2TLUFlZS8rBd5MzG+v0mW+ZJRKxnDWC3+Iro= X-Received: by 2002:a05:6214:529c:b0:67f:44b0:b997 with SMTP id kj28-20020a056214529c00b0067f44b0b997mr2951521qvb.52.1703067187745; Wed, 20 Dec 2023 02:13:07 -0800 (PST) MIME-Version: 1.0 References: <170306586433.8914.16398386237744409368@lain.khirnov.net> In-Reply-To: <170306586433.8914.16398386237744409368@lain.khirnov.net> From: flow gg Date: Wed, 20 Dec 2023 18:12:56 +0800 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="000000000000c1c392060cee3a75" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --000000000000c1c392060cee3a75 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > typo in 'lavc' fixed. > Brace should be on its own line fixed > Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call in dnxhdenc.c? Sorry, I missed this part, it's fixed in this reply Anton Khirnov =E4=BA=8E2023=E5=B9=B412=E6=9C=8820=E6=97= =A5=E5=91=A8=E4=B8=89 17:51=E5=86=99=E9=81=93=EF=BC=9A > Quoting flow gg (2023-12-20 09:39:57) > > > > > > From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001 > > From: sunyuechi > > Date: Wed, 20 Dec 2023 16:17:32 +0800 > > Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init > > typo in 'lavc' > > > > > This is for clarity and use in testing, consistent with other parts of > the code. > > --- > > libavcodec/dnxhdenc.c | 6 ++++++ > > libavcodec/dnxhdenc.h | 1 + > > 2 files changed, 7 insertions(+) > > > > diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c > > index f52a2e9918..1ac8116f53 100644 > > --- a/libavcodec/dnxhdenc.c > > +++ b/libavcodec/dnxhdenc.c > > @@ -1377,3 +1377,9 @@ const FFCodec ff_dnxhd_encoder =3D { > > .p.profiles =3D NULL_IF_CONFIG_SMALL(ff_dnxhd_profiles), > > .caps_internal =3D FF_CODEC_CAP_INIT_CLEANUP, > > }; > > + > > +void ff_dnxhdenc_init(DNXHDEncContext *ctx) { > > Brace should be on its own line > > > +#if ARCH_X86 > > + ff_dnxhdenc_init_x86(ctx); > > +#endif > > +} > > diff --git a/libavcodec/dnxhdenc.h b/libavcodec/dnxhdenc.h > > index e581312ce4..95aea83d28 100644 > > --- a/libavcodec/dnxhdenc.h > > +++ b/libavcodec/dnxhdenc.h > > @@ -111,6 +111,7 @@ typedef struct DNXHDEncContext { > > const uint8_t *pixels, ptrdiff_t > line_size); > > } DNXHDEncContext; > > > > +void ff_dnxhdenc_init(DNXHDEncContext *ctx); > > Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call > in dnxhdenc.c? > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > --000000000000c1c392060cee3a75 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lavc-dnxhdenc-add-ff_dnxhdenc_init.patch" Content-Disposition: attachment; filename="0001-lavc-dnxhdenc-add-ff_dnxhdenc_init.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lqdm6sse0 RnJvbSAzOGU4ZmZiZjQ5ZDIzNDE3YmM1OTdiMTY2ZjY4NjlkYWRlZTVkMGEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdW55dWVjaGkgPHN1bnl1ZWNoaUBpc2Nhcy5hYy5jbj4KRGF0 ZTogV2VkLCAyMCBEZWMgMjAyMyAxNjoxNzozMiArMDgwMApTdWJqZWN0OiBbUEFUQ0ggMS8zXSBs YXZjL2RueGhkZW5jOiBhZGQgZmZfZG54aGRlbmNfaW5pdAoKVGhpcyBpcyBmb3IgY2xhcml0eSBh bmQgdXNlIGluIHRlc3RpbmcsIGNvbnNpc3RlbnQgd2l0aCBvdGhlciBwYXJ0cyBvZiB0aGUgY29k ZS4KLS0tCiBsaWJhdmNvZGVjL2RueGhkZW5jLmMgfCAxMSArKysrKysrKy0tLQogbGliYXZjb2Rl Yy9kbnhoZGVuYy5oIHwgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDMg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGliYXZjb2RlYy9kbnhoZGVuYy5jIGIvbGliYXZj b2RlYy9kbnhoZGVuYy5jCmluZGV4IGY1MmEyZTk5MTguLjBkOTcyN2JiYmYgMTAwNjQ0Ci0tLSBh L2xpYmF2Y29kZWMvZG54aGRlbmMuYworKysgYi9saWJhdmNvZGVjL2RueGhkZW5jLmMKQEAgLTQ0 NSw5ICs0NDUsNyBAQCBzdGF0aWMgYXZfY29sZCBpbnQgZG54aGRfZW5jb2RlX2luaXQoQVZDb2Rl Y0NvbnRleHQgKmF2Y3R4KQogICAgICAgICBjdHgtPmJsb2NrX3dpZHRoX2wyICAgICA9IDM7CiAg ICAgfQogCi0jaWYgQVJDSF9YODYKLSAgICBmZl9kbnhoZGVuY19pbml0X3g4NihjdHgpOwotI2Vu ZGlmCisgICAgZmZfZG54aGRlbmNfaW5pdChjdHgpOwogCiAgICAgY3R4LT5tLm1iX2hlaWdodCA9 IChhdmN0eC0+aGVpZ2h0ICsgMTUpIC8gMTY7CiAgICAgY3R4LT5tLm1iX3dpZHRoICA9IChhdmN0 eC0+d2lkdGggICsgMTUpIC8gMTY7CkBAIC0xMzc3LDMgKzEzNzUsMTAgQEAgY29uc3QgRkZDb2Rl YyBmZl9kbnhoZF9lbmNvZGVyID0gewogICAgIC5wLnByb2ZpbGVzICAgICA9IE5VTExfSUZfQ09O RklHX1NNQUxMKGZmX2RueGhkX3Byb2ZpbGVzKSwKICAgICAuY2Fwc19pbnRlcm5hbCAgPSBGRl9D T0RFQ19DQVBfSU5JVF9DTEVBTlVQLAogfTsKKwordm9pZCBmZl9kbnhoZGVuY19pbml0KEROWEhE RW5jQ29udGV4dCAqY3R4KQoreworI2lmIEFSQ0hfWDg2CisgICAgZmZfZG54aGRlbmNfaW5pdF94 ODYoY3R4KTsKKyNlbmRpZgorfQpkaWZmIC0tZ2l0IGEvbGliYXZjb2RlYy9kbnhoZGVuYy5oIGIv bGliYXZjb2RlYy9kbnhoZGVuYy5oCmluZGV4IGU1ODEzMTJjZTQuLjk1YWVhODNkMjggMTAwNjQ0 Ci0tLSBhL2xpYmF2Y29kZWMvZG54aGRlbmMuaAorKysgYi9saWJhdmNvZGVjL2RueGhkZW5jLmgK QEAgLTExMSw2ICsxMTEsNyBAQCB0eXBlZGVmIHN0cnVjdCBETlhIREVuY0NvbnRleHQgewogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHVpbnQ4X3QgKnBpeGVscywgcHRyZGlm Zl90IGxpbmVfc2l6ZSk7CiB9IEROWEhERW5jQ29udGV4dDsKIAordm9pZCBmZl9kbnhoZGVuY19p bml0KEROWEhERW5jQ29udGV4dCAqY3R4KTsKIHZvaWQgZmZfZG54aGRlbmNfaW5pdF94ODYoRE5Y SERFbmNDb250ZXh0ICpjdHgpOwogCiAjZW5kaWYgLyogQVZDT0RFQ19ETlhIREVOQ19IICovCi0t IAoyLjQzLjAKCg== --000000000000c1c392060cee3a75 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --000000000000c1c392060cee3a75--