From: flow gg <hlefthleft@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Fix the tail handling in R-V V sad
Date: Sun, 19 Jan 2025 11:13:48 +0800
Message-ID: <CAEa-L+tOHnbAeGJybZriKcLYqyouwpoSN12HfdB+sDYwNk230Q@mail.gmail.com> (raw)
In-Reply-To: <tencent_3CC55C733B58D0614A3C93AAFE1602437308@qq.com>
ping
<uk7b-at-foxmail.com@ffmpeg.org> 于2024年12月23日周一 23:02写道：
> From: sunyuechi <sunyuechi@iscas.ac.cn>
>
> ---
> libavcodec/riscv/h26x/asm.S | 36 +++++++++++++++++-----------------
> libavcodec/riscv/vvc/sad_rvv.S | 2 +-
> 2 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/libavcodec/riscv/h26x/asm.S b/libavcodec/riscv/h26x/asm.S
> index d99690d9a0..0c9ebbdaad 100644
> --- a/libavcodec/riscv/h26x/asm.S
> +++ b/libavcodec/riscv/h26x/asm.S
> @@ -20,46 +20,46 @@
>
> #include "libavutil/riscv/asm.S"
>
> -.macro vsetvlstatic w, vlen, en, mn1, mn2, mn3, mn4, mn5, mn6
> +.macro vsetvlstatic w, vlen, en, mn1, mn2, mn3, mn4, mn5, mn6, vta=ta
> .if \w == 2 && \vlen == 128
> - vsetivli zero, \w, \en, \mn1, ta, ma
> + vsetivli zero, \w, \en, \mn1, \vta, ma
> .elseif \w <= 4 && \vlen == 128
> - vsetivli zero, \w, \en, \mn2, ta, ma
> + vsetivli zero, \w, \en, \mn2, \vta, ma
> .elseif \w <= 8 && \vlen == 128
> - vsetivli zero, \w, \en, \mn3, ta, ma
> + vsetivli zero, \w, \en, \mn3, \vta, ma
> .elseif \w <= 16 && \vlen == 128
> - vsetivli zero, \w, \en, \mn4, ta, ma
> + vsetivli zero, \w, \en, \mn4, \vta, ma
> .elseif \w <= 32 && \vlen == 128
> li t0, \w
> - vsetvli zero, t0, \en, \mn5, ta, ma
> + vsetvli zero, t0, \en, \mn5, \vta, ma
> .elseif \w <= 4 && \vlen == 256
> - vsetivli zero, \w, \en, \mn1, ta, ma
> + vsetivli zero, \w, \en, \mn1, \vta, ma
> .elseif \w <= 8 && \vlen == 256
> - vsetivli zero, \w, \en, \mn2, ta, ma
> + vsetivli zero, \w, \en, \mn2, \vta, ma
> .elseif \w <= 16 && \vlen == 256
> - vsetivli zero, \w, \en, \mn3, ta, ma
> + vsetivli zero, \w, \en, \mn3, \vta, ma
> .elseif \w <= 32 && \vlen == 256
> li t0, \w
> - vsetvli zero, t0, \en, \mn4, ta, ma
> + vsetvli zero, t0, \en, \mn4, \vta, ma
> .elseif \w <= 64 && \vlen == 256
> li t0, \w
> - vsetvli zero, t0, \en, \mn5, ta, ma
> + vsetvli zero, t0, \en, \mn5, \vta, ma
> .else
> li t0, \w
> - vsetvli zero, t0, \en, \mn6, ta, ma
> + vsetvli zero, t0, \en, \mn6, \vta, ma
> .endif
> .endm
>
> -.macro vsetvlstatic8 w, vlen
> - vsetvlstatic \w, \vlen, e8, mf8, mf4, mf2, m1, m2, m4
> +.macro vsetvlstatic8 w, vlen, vta
> + vsetvlstatic \w, \vlen, e8, mf8, mf4, mf2, m1, m2, m4, \vta
> .endm
>
> -.macro vsetvlstatic16 w, vlen
> - vsetvlstatic \w, \vlen, e16, mf4, mf2, m1, m2, m4, m8
> +.macro vsetvlstatic16 w, vlen, vta
> + vsetvlstatic \w, \vlen, e16, mf4, mf2, m1, m2, m4, m8, \vta
> .endm
>
> -.macro vsetvlstatic32 w, vlen
> - vsetvlstatic \w, \vlen, e32, mf2, m1, m2, m4, m8, m8
> +.macro vsetvlstatic32 w, vlen, vta
> + vsetvlstatic \w, \vlen, e32, mf2, m1, m2, m4, m8, m8, \vta
> .endm
>
> .macro POW2_JMP_TABLE id, vlen
> diff --git a/libavcodec/riscv/vvc/sad_rvv.S
> b/libavcodec/riscv/vvc/sad_rvv.S
> index 341167be1f..bb613cc340 100644
> --- a/libavcodec/riscv/vvc/sad_rvv.S
> +++ b/libavcodec/riscv/vvc/sad_rvv.S
> @@ -37,7 +37,7 @@ SADVSET\vlen\w:
> vsetvlstatic32 \w, \vlen
> vmv.v.i v0, 0
> vmv.s.x v24, zero
> - vsetvlstatic16 \w, \vlen
> + vsetvlstatic16 \w, \vlen, tu
> SAD\vlen\w:
> addi a5, a5, -2
> vle16.v v8, (a0)
> --
> 2.47.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2025-01-19 3:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_3CC55C733B58D0614A3C93AAFE1602437308@qq.com>
2025-01-19 3:13 ` flow gg [this message]
2025-01-25 7:43 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEa-L+tOHnbAeGJybZriKcLYqyouwpoSN12HfdB+sDYwNk230Q@mail.gmail.com \
--to=hlefthleft@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git