From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31CF34839C for ; Fri, 1 Dec 2023 20:16:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8196D68CF75; Fri, 1 Dec 2023 22:16:45 +0200 (EET) Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE71468CF12 for ; Fri, 1 Dec 2023 22:16:39 +0200 (EET) Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-677fba00a49so21456636d6.1 for ; Fri, 01 Dec 2023 12:16:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701461798; x=1702066598; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=2uo+jx/HbfyiwArxkEmY9cwWZZTIoVTUx8HCiLflUsA=; b=asdMa1puDbX7CNri7vT9ekx91Dz+nHqP/Amk7sakTCVcHIa6LIOAIbeIreS/AuO0Pf Qx5GYMkOeXuCzSwfHQfK4yH8xxo9YDdh7Hwf7NFKL3+jC6Ixbuizf3+l9v1wZpXNfWCg TSIy6t4f7Z2vsCKoYMDDvmwOKfvWkLsN3ynL7x1koZiVqq+HDsaMKm4TXMbTh+Wf4qko n/uLdNYBuxYt+DR4B9ozqSUSLN46+YNgpqxqJTRTDDG4sEazlSyXnvd3BZezGPpkJn6O 8OzIuyd4sIlw39h8d08VDDcatonLCRl0BaGgL9OaUmSA7ImXHciA0XueWq3VtUzKKir5 IZ9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701461798; x=1702066598; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2uo+jx/HbfyiwArxkEmY9cwWZZTIoVTUx8HCiLflUsA=; b=fZZtdUKS3Im6jojhQDbaQQpz3qpkx7xPcicyO9K6wDG5WSK+slZEBW226s/RjYnIdt FcUlaaB+T/PSOUEymzqcG5rFSepxe3qfioB7qVxuH7d9IO3vuOwIHHc2NXGPPJtvQWld Mrc/sv2I0w353zoLK7PYEhs8M7PGCnY3IAyzAxRl+yIn3p4g3eTGwLpdX825tUyj4xfV u3a0Ziu2gpb/iAq7EvBa/obyNSi8kiqPp+X90Q0Xpp2Bkrg/Wm+y552YdDgUVkE5Ycyo AJNBl+8AhTyHX41jaTt8jnRCVEdonnuB9BdymHzi5pzv3BjSC/j6TEImu3sJPxdYSp0o Q4MQ== X-Gm-Message-State: AOJu0YzJEYTFECnkuo8Ixyz9qOGPg4yS/Bgpb7VCrQ5f3fRf0cfh0xVa Jc3S1sd7d6hGRr84cVXB3UsIafMyeNXZZ1nWuTSfp2yjKXm3XCFOXKc= X-Google-Smtp-Source: AGHT+IHP6hB/PlYAt03xqKGsDG1SCqIkxC8TL3uRRyHTDNuZoPJFe1U2iqpH6bbHUqwj0NPUJqh8TsjOwZoHa2jVOW0= X-Received: by 2002:a0c:e80d:0:b0:67a:a721:7214 with SMTP id y13-20020a0ce80d000000b0067aa7217214mr119018qvn.49.1701461798296; Fri, 01 Dec 2023 12:16:38 -0800 (PST) MIME-Version: 1.0 References: <1963722.FVt6nWukC3@basile.remlab.net> <6596049.xiiJylZ7dE@basile.remlab.net> In-Reply-To: From: flow gg Date: Sat, 2 Dec 2023 04:16:27 +0800 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="000000000000169f1f060b78728e" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] ac3dsp: RISC-V V float_to_fixed24 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --000000000000169f1f060b78728e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I forgot to modify the Makefile; I've made the changes in this reply. flow gg =E4=BA=8E2023=E5=B9=B412=E6=9C=882=E6=97=A5= =E5=91=A8=E5=85=AD 03:50=E5=86=99=E9=81=93=EF=BC=9A > Okay, changed and attached > > R=C3=A9mi Denis-Courmont =E4=BA=8E2023=E5=B9=B412=E6=9C= =882=E6=97=A5=E5=91=A8=E5=85=AD 02:38=E5=86=99=E9=81=93=EF=BC=9A > >> Le perjantaina 1. joulukuuta 2023, 20.35.10 EET R=C3=A9mi Denis-Courmont= a >> =C3=A9crit : >> > Le perjantaina 24. marraskuuta 2023, 0.39.39 EET flow gg a =C3=A9crit = : >> > > Okay, changed >> > >> > src/libavcodec/riscv/ac3dsp_init.c: In function =E2=80=98ff_ac3dsp_ini= t_riscv=E2=80=99: >> > src/libavcodec/riscv/ac3dsp_init.c:39:33: warning: assignment to =E2= =80=98void >> (*) >> > (int32_t *, const float *, size_t)=E2=80=99 {aka =E2=80=98void (*)(int= *, const float *, >> > long unsigned int)=E2=80=99} from incompatible pointer type =E2=80=98v= oid (*)(int32_t *, >> > const float *, unsigned int)=E2=80=99 {aka =E2=80=98void (*)(int *, co= nst float *, >> unsigned >> > int)=E2=80=99} [- Wincompatible-pointer-types] >> > 39 | c->float_to_fixed24 =3D ff_float_to_fixed24_rvv; >> > >> > | ^ >> > >> > Also the Makefile precondition is inaccurate. >> >> Oh, and on C908, LMUL=3D8 is actually faster than LMUL=3D4. Generally >> speaking, >> you should maximise the LMUL unless there is a *specific* reason not to. >> >> -- >> =E3=83=AC=E3=83=9F=E3=83=BB=E3=83=87=E3=83=8B-=E3=82=AF=E3=83=BC=E3=83= =AB=E3=83=A2=E3=83=B3 >> http://www.remlab.net/ >> >> >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > --000000000000169f1f060b78728e Content-Type: text/x-patch; charset="US-ASCII"; name="lavc-ac3dsp-R-V-V-float_to_fixed24.patch" Content-Disposition: attachment; filename="lavc-ac3dsp-R-V-V-float_to_fixed24.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lpn2eusw0 RnJvbSAyYWEwNmQ5ZDhkNDg1M2FjMDg5YTEzZWQ2YTc1OGY5ZWNiMGFhNWE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdW55dWVjaGkgPHN1bnl1ZWNoaUBpc2Nhcy5hYy5jbj4KRGF0 ZTogV2VkLCAyMiBOb3YgMjAyMyAxNDo1NzoyOSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGxhdmMv YWMzZHNwOiBSLVYgViBmbG9hdF90b19maXhlZDI0CgpjOTEwCiAgICBmbG9hdF90b19maXhlZDI0 X2M6IDIyMDcuMgogICAgZmxvYXRfdG9fZml4ZWQyNF9ydnZfZjMyOiA2OTYuMgotLS0KIGxpYmF2 Y29kZWMvcmlzY3YvTWFrZWZpbGUgICAgICB8ICAxICsKIGxpYmF2Y29kZWMvcmlzY3YvYWMzZHNw X2luaXQuYyB8ICA0ICsrKysKIGxpYmF2Y29kZWMvcmlzY3YvYWMzZHNwX3J2di5TICB8IDM5ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNDQgaW5z ZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGxpYmF2Y29kZWMvcmlzY3YvYWMzZHNwX3J2 di5TCgpkaWZmIC0tZ2l0IGEvbGliYXZjb2RlYy9yaXNjdi9NYWtlZmlsZSBiL2xpYmF2Y29kZWMv cmlzY3YvTWFrZWZpbGUKaW5kZXggMmQwZTZjMTljOC4uMjlhN2ZlYzQ1NSAxMDA2NDQKLS0tIGEv bGliYXZjb2RlYy9yaXNjdi9NYWtlZmlsZQorKysgYi9saWJhdmNvZGVjL3Jpc2N2L01ha2VmaWxl CkBAIC0yLDYgKzIsNyBAQCBPQkpTLSQoQ09ORklHX0FBQ19ERUNPREVSKSArPSByaXNjdi9hYWNw c2RzcF9pbml0Lm8gcmlzY3Yvc2JyZHNwX2luaXQubwogUlZWLU9CSlMtJChDT05GSUdfQUFDX0RF Q09ERVIpICs9IHJpc2N2L2FhY3BzZHNwX3J2di5vIHJpc2N2L3NicmRzcF9ydnYubwogT0JKUy0k KENPTkZJR19BQzNEU1ApICs9IHJpc2N2L2FjM2RzcF9pbml0Lm8gXAogICAgICAgICAgICAgICAg ICAgICAgICAgIHJpc2N2L2FjM2RzcF9ydmIubworUlZWLU9CSlMtJChDT05GSUdfQUMzRFNQKSAr PSByaXNjdi9hYzNkc3BfcnZ2Lm8KIE9CSlMtJChDT05GSUdfQUxBQ19ERUNPREVSKSArPSByaXNj di9hbGFjZHNwX2luaXQubwogUlZWLU9CSlMtJChDT05GSUdfQUxBQ19ERUNPREVSKSArPSByaXNj di9hbGFjZHNwX3J2di5vCiBPQkpTLSQoQ09ORklHX0FVRElPRFNQKSArPSByaXNjdi9hdWRpb2Rz cF9pbml0Lm8gXApkaWZmIC0tZ2l0IGEvbGliYXZjb2RlYy9yaXNjdi9hYzNkc3BfaW5pdC5jIGIv bGliYXZjb2RlYy9yaXNjdi9hYzNkc3BfaW5pdC5jCmluZGV4IDIwZjI5NGYxZGUuLjExOGIyOTU1 Y2EgMTAwNjQ0Ci0tLSBhL2xpYmF2Y29kZWMvcmlzY3YvYWMzZHNwX2luaXQuYworKysgYi9saWJh dmNvZGVjL3Jpc2N2L2FjM2RzcF9pbml0LmMKQEAgLTE4LDYgKzE4LDcgQEAKICAqIEZvdW5kYXRp b24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsIEJvc3RvbiwgTUEgMDIx MTAtMTMwMSBVU0EKICAqLwogCisjaW5jbHVkZSA8c3RkZGVmLmg+CiAjaW5jbHVkZSA8c3RkaW50 Lmg+CiAKICNpbmNsdWRlICJjb25maWcuaCIKQEAgLTI2LDYgKzI3LDcgQEAKICNpbmNsdWRlICJs aWJhdmNvZGVjL2FjM2RzcC5oIgogCiB2b2lkIGZmX2V4dHJhY3RfZXhwb25lbnRzX3J2Yih1aW50 OF90ICpleHAsIGludDMyX3QgKmNvZWYsIGludCBuYl9jb2Vmcyk7Cit2b2lkIGZmX2Zsb2F0X3Rv X2ZpeGVkMjRfcnZ2KGludDMyX3QgKmRzdCwgY29uc3QgZmxvYXQgKnNyYywgc2l6ZV90IGxlbik7 CiAKIGF2X2NvbGQgdm9pZCBmZl9hYzNkc3BfaW5pdF9yaXNjdihBQzNEU1BDb250ZXh0ICpjKQog ewpAQCAtMzQsNSArMzYsNyBAQCBhdl9jb2xkIHZvaWQgZmZfYWMzZHNwX2luaXRfcmlzY3YoQUMz RFNQQ29udGV4dCAqYykKICAgICBpZiAoZmxhZ3MgJiBBVl9DUFVfRkxBR19SVkJfQUREUikgewog ICAgICAgICBpZiAoZmxhZ3MgJiBBVl9DUFVfRkxBR19SVkJfQkFTSUMpCiAgICAgICAgICAgICBj LT5leHRyYWN0X2V4cG9uZW50cyA9IGZmX2V4dHJhY3RfZXhwb25lbnRzX3J2YjsKKyAgICAgICAg aWYgKGZsYWdzICYgQVZfQ1BVX0ZMQUdfUlZWX0YzMikKKyAgICAgICAgICAgIGMtPmZsb2F0X3Rv X2ZpeGVkMjQgPSBmZl9mbG9hdF90b19maXhlZDI0X3J2djsKICAgICB9CiB9CmRpZmYgLS1naXQg YS9saWJhdmNvZGVjL3Jpc2N2L2FjM2RzcF9ydnYuUyBiL2xpYmF2Y29kZWMvcmlzY3YvYWMzZHNw X3J2di5TCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLmI4ZDMyYzQ2NzcK LS0tIC9kZXYvbnVsbAorKysgYi9saWJhdmNvZGVjL3Jpc2N2L2FjM2RzcF9ydnYuUwpAQCAtMCww ICsxLDM5IEBACisvKgorICogQ29weXJpZ2h0IChjKSAyMDIzIEluc3RpdHVlIG9mIFNvZnR3YXJl IENoaW5lc2UgQWNhZGVteSBvZiBTY2llbmNlcyAoSVNDQVMpLgorICoKKyAqIFRoaXMgZmlsZSBp cyBwYXJ0IG9mIEZGbXBlZy4KKyAqCisgKiBGRm1wZWcgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNh biByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9m IHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBi eSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNpb24gMi4xIG9m IHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorICoK KyAqIEZGbXBlZyBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNl ZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxp ZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJ Q1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgKiBMZXNzZXIgR2VuZXJhbCBQdWJsaWMgTGlj ZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBh IGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAqIExpY2Vuc2UgYWxvbmcg d2l0aCBGRm1wZWc7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdhcmUKKyAqIEZvdW5k YXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsIEJvc3RvbiwgTUEg MDIxMTAtMTMwMSBVU0EKKyAqLworCisjaW5jbHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAibGli YXZ1dGlsL3Jpc2N2L2FzbS5TIgorCitmdW5jIGZmX2Zsb2F0X3RvX2ZpeGVkMjRfcnZ2LCB6dmUz MmYKKyAgICAgICAgbGkgICAgICAgICAgICB0MSwgMSA8PCAyNAorICAgICAgICBmY3Z0LnMudyAg ICAgIGYwLCB0MQorMToKKyAgICAgICAgdnNldHZsaSAgICAgICB0MCwgYTIsIGUzMiwgbTgsIHRh LCBtYQorICAgICAgICBzdWIgICAgICAgICAgIGEyLCBhMiwgdDAKKyAgICAgICAgdmxlMzIudiAg ICAgICB2MCwgKGExKQorICAgICAgICB2Zm11bC52ZiAgICAgIHYwLCB2MCwgZjAKKyAgICAgICAg dmZjdnQueC5mLnYgICB2MCwgdjAKKyAgICAgICAgc2gyYWRkICAgICAgICBhMSwgdDAsIGExCisg ICAgICAgIHZzZTMyLnYgICAgICAgdjAsIChhMCkKKyAgICAgICAgc2gyYWRkICAgICAgICBhMCwg dDAsIGEwCisgICAgICAgIGJuZXogICAgICAgICAgYTIsIDFiCisKKyAgICAgICAgcmV0CitlbmRm dW5jCi0tIAoyLjQzLjAKCg== --000000000000169f1f060b78728e Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --000000000000169f1f060b78728e--