From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D63DD47A1D for ; Sat, 30 Dec 2023 14:00:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF5D268CC2F; Sat, 30 Dec 2023 16:00:09 +0200 (EET) Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8ADC268C5FF for ; Sat, 30 Dec 2023 16:00:03 +0200 (EET) Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-67f911e9ac4so60196356d6.3 for ; Sat, 30 Dec 2023 06:00:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703944801; x=1704549601; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=DvccSPrZSWs8ry1EZunT8qo7OcB1U6FCt5g6tFkhbRY=; b=T3yxPA1I7bH0IwCuwZ9Tx+0PhUubP+Mzq0GhmerkdJYUDUmRvRuV6C8aWk01qiFWYc utaVS/Abjzjip9Pp9bcPlxLlgTY34gns0Kk64eRQBWBswIlMaC6d+8PHU4zXHDTetIWX zof+LNKuNY3nbY21Ms7VKS0X9gjJHF0C1cQ0CixWOGyMaMAmT7RTJy9EHDhnb+X3wJbN MYVsDpwcK2SVZZ6xSpMWU4u7OczTy2f1JrxRPkxLUbHDJiKjjIXXHkSsHh+/rP27g+xH OlEu2UacQEhbxZnnVPW4iellneqPxgankyaSKLo8rGCYgx5C4tAxMBmzSn0bNrKfB7UI v//g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703944801; x=1704549601; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DvccSPrZSWs8ry1EZunT8qo7OcB1U6FCt5g6tFkhbRY=; b=NeiDYEcWcE9WrLvvy/GSY0W7tcZqZoym3A7muoKYhXydP8ciBy1USLQsG2oRD888iR ivwMCa5SEDce1C6OyqeIUjKBL1IqLrdPm/D7h477BKm6O5jeaNlaF8VeRaXBZHTWTheB BW1y15j/wLM1/SSJZZdU7ZKms9Bu7p6tiqtLHZ6B3b34VbDiiWIhgQKKDanOjxm9IhgR HjINM45LcYB56KpuvxdbhJJIuJjNH4s1MXXcgd/2V5lCJRDpxyXvjAdM4wkWV1/GWxG4 iLIVtY+rVUPPH2oYESd6WSi3zA7cpO/TIWj+LSSG2jvPFAJqXRzXrVbiGnyAb7oODwWc Jf2g== X-Gm-Message-State: AOJu0YzTjAXOYGHKLNb0Obvnt7C+TSbutMtyZtfnNG62YcGN8Z5qlwwi 73OKN4MB4eEVrGVHezfEx3UEtD6VvhL9pWrC2zfPFL1gfsq1KERRxD0= X-Google-Smtp-Source: AGHT+IE2exES88W8JITXPg54Jn4SvRUJI6Jfdeo4Q5zSH7J7uPHYtO9WA8xzy/FW2hTKen1q0wemK0BBtdEfz4uhUHs= X-Received: by 2002:a05:6214:ca4:b0:67f:5db:f4f2 with SMTP id s4-20020a0562140ca400b0067f05dbf4f2mr21060993qvs.52.1703944801166; Sat, 30 Dec 2023 06:00:01 -0800 (PST) MIME-Version: 1.0 References: <1ceb4dd3-542d-cc4d-5617-d94685324d9@martin.st> <77d73da5-56b3-4b28-83dc-280ae4c96f25@gmail.com> <256b62f-a279-386-2cec-65501f6cafe8@martin.st> In-Reply-To: <256b62f-a279-386-2cec-65501f6cafe8@martin.st> From: flow gg Date: Sat, 30 Dec 2023 21:59:50 +0800 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="0000000000009760e4060dba90d7" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --0000000000009760e4060dba90d7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Okay, it has been modified in this reply. Martin Storsj=C3=B6 =E4=BA=8E2023=E5=B9=B412=E6=9C=8829= =E6=97=A5=E5=91=A8=E4=BA=94 22:35=E5=86=99=E9=81=93=EF=BC=9A > On Fri, 29 Dec 2023, James Almer wrote: > > > On 12/29/2023 9:16 AM, Martin Storsj=C3=B6 wrote: > >> On Fri, 29 Dec 2023, flow gg wrote: > >> > >>> Tests on x86 might fail, possibly due to a 16-bit sub overflow > >> > >> If this only happens in checkasm but not in real life use, it means > > that > >> the checkasm test input is out of range, and we should try to mimic th= e > >> real input data. > >> > >> If the issue is off-by-one due to rounding, we could allow it by makin= g > >> a comparison per element, and tolerate a certain diff (maybe only on > > x86). > >> > >> But if it is an actual overflow on valid input data, the x86 asm > >> definitely needs to be fixed, by someone... Worst case, we might want > > to > >> disable that checkasm test on x86 temporarily. > > > > The function subtracts an int16 from an int8, whose result may not fit > > on an int16. The x86 asm expects it to do, hence the failures. > > > > I don't know if such cases exist in real world files, so like you said, > > if they don't then the test should generate in-range input. But if they > > do, i'll fix the x86 asm (sadly, this means sse4 will be required > > instead of sse2). > > I think it's probably best to limit the checkasm inputs that don't > overflow, for now. > > // Martin > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > --0000000000009760e4060dba90d7 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-checkasm-svqenc-add-ssd_int8_vs_int16-test.patch" Content-Disposition: attachment; filename="0002-checkasm-svqenc-add-ssd_int8_vs_int16-test.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lqs4qd5v0 RnJvbSBkNjJmMzYzZTNhYWQ1MzRjN2VhZDVmMzAxNTAyOWIzZTdjYmJmZjQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdW55dWVjaGkgPHN1bnl1ZWNoaUBpc2Nhcy5hYy5jbj4KRGF0 ZTogRnJpLCAyOSBEZWMgMjAyMyAxMzowOToyMSArMDgwMApTdWJqZWN0OiBbUEFUQ0ggMi8zXSBj aGVja2FzbS9zdnFlbmM6IGFkZCBzc2RfaW50OF92c19pbnQxNiB0ZXN0CgotLS0KIHRlc3RzL2No ZWNrYXNtL01ha2VmaWxlICAgfCAgMSArCiB0ZXN0cy9jaGVja2FzbS9jaGVja2FzbS5jIHwgIDMg KysKIHRlc3RzL2NoZWNrYXNtL2NoZWNrYXNtLmggfCAgMSArCiB0ZXN0cy9jaGVja2FzbS9zdnEx ZW5jLmMgIHwgNjggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiB0ZXN0 cy9mYXRlL2NoZWNrYXNtLm1hayAgIHwgIDEgKwogNSBmaWxlcyBjaGFuZ2VkLCA3NCBpbnNlcnRp b25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgdGVzdHMvY2hlY2thc20vc3ZxMWVuYy5jCgpkaWZm IC0tZ2l0IGEvdGVzdHMvY2hlY2thc20vTWFrZWZpbGUgYi90ZXN0cy9jaGVja2FzbS9NYWtlZmls ZQppbmRleCA0NzMyOGI1OWI5Li5mNTA3ZTk5OTkzIDEwMDY0NAotLS0gYS90ZXN0cy9jaGVja2Fz bS9NYWtlZmlsZQorKysgYi90ZXN0cy9jaGVja2FzbS9NYWtlZmlsZQpAQCAtMzQsNiArMzQsNyBA QCBBVkNPREVDT0JKUy0kKENPTkZJR19KUEVHMjAwMF9ERUNPREVSKSAgKz0ganBlZzIwMDBkc3Au bwogQVZDT0RFQ09CSlMtJChDT05GSUdfT1BVU19ERUNPREVSKSAgICAgICs9IG9wdXNkc3Aubwog QVZDT0RFQ09CSlMtJChDT05GSUdfUElYQkxPQ0tEU1ApICAgICAgICs9IHBpeGJsb2NrZHNwLm8K IEFWQ09ERUNPQkpTLSQoQ09ORklHX0hFVkNfREVDT0RFUikgICAgICArPSBoZXZjX2FkZF9yZXMu byBoZXZjX2RlYmxvY2subyBoZXZjX2lkY3QubyBoZXZjX3Nhby5vIGhldmNfcGVsLm8KK0FWQ09E RUNPQkpTLSQoQ09ORklHX1NWUTFfRU5DT0RFUikgICAgICArPSBzdnExZW5jLm8KIEFWQ09ERUNP QkpTLSQoQ09ORklHX1RBS19ERUNPREVSKSAgICAgICArPSB0YWtkc3AubwogQVZDT0RFQ09CSlMt JChDT05GSUdfVVRWSURFT19ERUNPREVSKSAgICs9IHV0dmlkZW9kc3AubwogQVZDT0RFQ09CSlMt JChDT05GSUdfVjIxMF9ERUNPREVSKSAgICAgICs9IHYyMTBkZWMubwpkaWZmIC0tZ2l0IGEvdGVz dHMvY2hlY2thc20vY2hlY2thc20uYyBiL3Rlc3RzL2NoZWNrYXNtL2NoZWNrYXNtLmMKaW5kZXgg NTc2MTNhZjVmNy4uZmYwN2Q4YjE4ZCAxMDA2NDQKLS0tIGEvdGVzdHMvY2hlY2thc20vY2hlY2th c20uYworKysgYi90ZXN0cy9jaGVja2FzbS9jaGVja2FzbS5jCkBAIC0xNjIsNiArMTYyLDkgQEAg c3RhdGljIGNvbnN0IHN0cnVjdCB7CiAgICAgI2lmIENPTkZJR19QSVhCTE9DS0RTUAogICAgICAg ICB7ICJwaXhibG9ja2RzcCIsIGNoZWNrYXNtX2NoZWNrX3BpeGJsb2NrZHNwIH0sCiAgICAgI2Vu ZGlmCisgICAgI2lmIENPTkZJR19TVlExX0VOQ09ERVIKKyAgICAgICAgeyAic3ZxMWVuYyIsIGNo ZWNrYXNtX2NoZWNrX3N2cTFlbmMgfSwKKyAgICAjZW5kaWYKICAgICAjaWYgQ09ORklHX1RBS19E RUNPREVSCiAgICAgICAgIHsgInRha2RzcCIsIGNoZWNrYXNtX2NoZWNrX3Rha2RzcCB9LAogICAg ICNlbmRpZgpkaWZmIC0tZ2l0IGEvdGVzdHMvY2hlY2thc20vY2hlY2thc20uaCBiL3Rlc3RzL2No ZWNrYXNtL2NoZWNrYXNtLmgKaW5kZXggZDc5NzQ3NzJkMy4uYzFmMTFjZmEzNiAxMDA2NDQKLS0t IGEvdGVzdHMvY2hlY2thc20vY2hlY2thc20uaAorKysgYi90ZXN0cy9jaGVja2FzbS9jaGVja2Fz bS5oCkBAIC04Miw2ICs4Miw3IEBAIHZvaWQgY2hlY2thc21fY2hlY2tfbmxtZWFucyh2b2lkKTsK IHZvaWQgY2hlY2thc21fY2hlY2tfb3B1c2RzcCh2b2lkKTsKIHZvaWQgY2hlY2thc21fY2hlY2tf cGl4YmxvY2tkc3Aodm9pZCk7CiB2b2lkIGNoZWNrYXNtX2NoZWNrX3NicmRzcCh2b2lkKTsKK3Zv aWQgY2hlY2thc21fY2hlY2tfc3ZxMWVuYyh2b2lkKTsKIHZvaWQgY2hlY2thc21fY2hlY2tfc3lu dGhfZmlsdGVyKHZvaWQpOwogdm9pZCBjaGVja2FzbV9jaGVja19zd19nYnJwKHZvaWQpOwogdm9p ZCBjaGVja2FzbV9jaGVja19zd19yZ2Iodm9pZCk7CmRpZmYgLS1naXQgYS90ZXN0cy9jaGVja2Fz bS9zdnExZW5jLmMgYi90ZXN0cy9jaGVja2FzbS9zdnExZW5jLmMKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMC4uMDY1ZGQ3OThjYQotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3Rz L2NoZWNrYXNtL3N2cTFlbmMuYwpAQCAtMCwwICsxLDY4IEBACisvKgorICogQ29weXJpZ2h0IChj KSAyMDIzIEluc3RpdHVlIG9mIFNvZnR3YXJlIENoaW5lc2UgQWNhZGVteSBvZiBTY2llbmNlcyAo SVNDQVMpLgorICoKKyAqIFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEZGbXBlZy4KKyAqCisgKiBGRm1w ZWcgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlm eQorICogaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5z ZSBhcyBwdWJsaXNoZWQgYnkKKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhl ciB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yCisgKiAoYXQgeW91ciBvcHRpb24pIGFueSBs YXRlciB2ZXJzaW9uLgorICoKKyAqIEZGbXBlZyBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0 aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRo b3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBG SVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyAqIEdOVSBHZW5lcmFs IFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBoYXZl IHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYWxvbmcK KyAqIHdpdGggRkZtcGVnOyBpZiBub3QsIHdyaXRlIHRvIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5k YXRpb24sIEluYy4sCisgKiA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLCBCb3N0b24s IE1BIDAyMTEwLTEzMDEgVVNBLgorICovCisKKyNpbmNsdWRlICJsaWJhdnV0aWwvbWVtLmgiCisj aW5jbHVkZSAibGliYXZ1dGlsL21lbV9pbnRlcm5hbC5oIgorCisjaW5jbHVkZSAibGliYXZjb2Rl Yy9zdnExZW5jZHNwLmgiCisKKyNpbmNsdWRlICJjaGVja2FzbS5oIgorCisjZGVmaW5lIEJVRl9T SVpFIDEwMjQKKworI2RlZmluZSByYW5kb21pemUoYnVmLCBsZW4pIFwKKyAgICBkbyB7IFwKKyAg ICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsZW47IGkrKykgXAorICAgICAgICAgICAgYnVmW2ld ID0gKChybmQoKSAlIDY1MjgxKSAtIDMyNjQxKTsgXAorICAgIH0gd2hpbGUgKDApCisKK3N0YXRp YyB2b2lkIHRlc3Rfc3NkX2ludDhfdnNfaW50MTYoU1ZRMUVuY0RTUENvbnRleHQgKnMpIHsKKyAg ICBkZWNsYXJlX2Z1bmMoaW50LCBjb25zdCBpbnQ4X3QgKnBpeDEsIGNvbnN0IGludDE2X3QgKnBp eDIsIGludHB0cl90IHNpemUpOworCisgICAgaW50IHIxLCByMjsKKworICAgIGlmIChjaGVja19m dW5jKHMtPnNzZF9pbnQ4X3ZzX2ludDE2LCAic3NkX2ludDhfdnNfaW50MTYiKSkgeworICAgICAg ICBMT0NBTF9BTElHTkVEXzMyKGludDhfdCwgcDEsIFtCVUZfU0laRV0pOworICAgICAgICBMT0NB TF9BTElHTkVEXzMyKGludDE2X3QsIHAyLCBbQlVGX1NJWkVdKTsKKworICAgICAgICByYW5kb21p emUocDEsIEJVRl9TSVpFKTsKKyAgICAgICAgcmFuZG9taXplKHAyLCBCVUZfU0laRSk7CisKKyAg ICAgICAgcjEgPSBjYWxsX3JlZihwMSwgcDIsIEJVRl9TSVpFKTsKKyAgICAgICAgcjIgPSBjYWxs X25ldyhwMSwgcDIsIEJVRl9TSVpFKTsKKworICAgICAgICBpZiAocjEgIT0gcjIpIHsKKyAgICAg ICAgICAgIGZhaWwoKTsKKyAgICAgICAgfQorCisgICAgICAgIGJlbmNoX25ldyhwMSwgcDIsIEJV Rl9TSVpFKTsKKyAgICB9CisKKyAgICByZXBvcnQoInNzZF9pbnQ4X3ZzX2ludDE2Iik7CisKK30K Kwordm9pZCBjaGVja2FzbV9jaGVja19zdnExZW5jKHZvaWQpCit7CisgICAgU1ZRMUVuY0RTUENv bnRleHQgcyA9IHsgMCB9OworICAgIGZmX3N2cTFlbmNfaW5pdCgmcyk7CisKKyAgICB0ZXN0X3Nz ZF9pbnQ4X3ZzX2ludDE2KCZzKTsKK30KZGlmZiAtLWdpdCBhL3Rlc3RzL2ZhdGUvY2hlY2thc20u bWFrIGIvdGVzdHMvZmF0ZS9jaGVja2FzbS5tYWsKaW5kZXggOWUwNGIxYjNjYi4uM2Q3NzU1NDll ZSAxMDA2NDQKLS0tIGEvdGVzdHMvZmF0ZS9jaGVja2FzbS5tYWsKKysrIGIvdGVzdHMvZmF0ZS9j aGVja2FzbS5tYWsKQEAgLTM0LDYgKzM0LDcgQEAgRkFURV9DSEVDS0FTTSA9IGZhdGUtY2hlY2th c20tYWFjZW5jZHNwICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICAg ICAgICAgIGZhdGUtY2hlY2thc20tb3B1c2RzcCAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgXAogICAgICAgICAgICAgICAgIGZhdGUtY2hlY2thc20tcGl4YmxvY2tkc3AgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgICAgIGZhdGUtY2hlY2thc20t c2JyZHNwICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgICAgICAgICAg ICAgIGZhdGUtY2hlY2thc20tc3ZxMWVuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXAogICAgICAgICAgICAgICAgIGZhdGUtY2hlY2thc20tc3ludGhfZmlsdGVyICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgICAgIGZhdGUtY2hlY2thc20tc3df Z2JycCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgICAg IGZhdGUtY2hlY2thc20tc3dfcmdiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XAotLSAKMi40My4wCgo= --0000000000009760e4060dba90d7 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --0000000000009760e4060dba90d7--