From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 02F3F49024 for ; Wed, 31 Jan 2024 17:57:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C8DFE68D060; Wed, 31 Jan 2024 19:57:49 +0200 (EET) Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8367D68C7E6 for ; Wed, 31 Jan 2024 19:57:42 +0200 (EET) Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-68c438fde8eso343276d6.1 for ; Wed, 31 Jan 2024 09:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706723861; x=1707328661; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=yDwIXhXvgiNjpOh6LsyqmQqArBpRcfh1SnSUgycFe8A=; b=I4tech8zQCdImdgOoq3rVxz2LsdcNHuklQajB9vW90SgEFunRyJNvGdQb7JSUOHXj3 MEUK43ElCiGUocUI3f1dNu8ZUeCNMypULeMuNCXPkjRn5+Gr6Z6t2L1IX/UQ+YnE9hfI yed9E2Osf0LndnXdQ0BoxmftZaYwrKQzr2QcIlEvUk3u6GbKbKChf2BYz/CDHJ+68Z7o 6Ti6jWT7679lxk3V09neSDSRsRgzoKpxeAwI7WNSf3RcHmhJAURjKCjvcCd/QeLr0J8U uK1OXdWFId+Xk/xxXXFte0i1N8jbjN3+c/F5F3uW6Q2M28obGRnwYrgRJDINXyft++Vk Sd5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706723861; x=1707328661; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yDwIXhXvgiNjpOh6LsyqmQqArBpRcfh1SnSUgycFe8A=; b=dZi74ff0WZGgYg/tb+gZdP2grtCJGYSyBtQ3BYYzHMq/t0i9gbbO1yJMY27K+M6D/1 xFKEtgwIngdVLh3Cv8KlXANC1fnb2EUW7vI6nIBlqQISuM4Mnz1lN3KNJxXWY6/Qndyz M6sNEJVqFzhaIBL8W24/bwehaQ0t+Cw8AWvDAyl+5qUvRGaPP8REhSi5IfQcolbRSY5n guYu2nZgqnB2AoZ658UvwCCZ5LB5SKRPeimVIBqryAPOWYtUKCiHC9Ao2gOM9u5uoCmd /Date/FV18s0hQDpzYm4mXLQYrycP5ecdkNUZNbygM6SXOpu5vfCRfEL+4NADt+Aoe5l nn/g== X-Gm-Message-State: AOJu0Ywpy1x3spUjsoDwOSXVymTFBouxydGmo/fARPPhTBzpafBt+xgv o59ty5Wt1MIBcdg6gGrbUuKTKe2oYLOXkFC6DGOjwTjWOXkqyyAr/X0F7H43cKGzvuoD68h33w7 cmJwbTfTyeGBaExwt5sRK52YRNlohP9RWzzY= X-Google-Smtp-Source: AGHT+IEd5x9r7sY9m2gLyppobF2Igz1/glxEqJg7IhvZ1Y1YcptzJRa61H0YUS/XgZv6GT8/kNugGKknWdzPrFkl/vA= X-Received: by 2002:a05:6214:212c:b0:68c:4a73:a82b with SMTP id r12-20020a056214212c00b0068c4a73a82bmr3089054qvc.43.1706723860786; Wed, 31 Jan 2024 09:57:40 -0800 (PST) MIME-Version: 1.0 References: <4074620.uURXtnen6K@basile.remlab.net> In-Reply-To: <4074620.uURXtnen6K@basile.remlab.net> From: flow gg Date: Thu, 1 Feb 2024 01:57:29 +0800 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="00000000000073dc110610419da2" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/4] lavc/rv34dsp: R-V V rv34_inv_transform_dc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --00000000000073dc110610419da2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Also fractional multipler should never be smaller than the ratio of the > specified element size to the largest element size used in the function. Here > it is largelly inconsequential, but for instance "e32, mf4" and "e64, mf2" are > invalid. Thanks, I indeed almost forgot about this part > I think this breaks the build for RV32 Okay, modified in the reply > it lacks checks for the vector length. In the rv34dsp_init.c, there's a check with ff_get_rv_vlenb() >=3D 16. Doesn't this already check the vector length? R=C3=A9mi Denis-Courmont =E4=BA=8E2024=E5=B9=B42=E6=9C=88= 1=E6=97=A5=E5=91=A8=E5=9B=9B 00:31=E5=86=99=E9=81=93=EF=BC=9A > Hi, > > I think this breaks the build for RV32, and it lacks checks for the vecto= r > length. > > Also fractional multipler should never be smaller than the ratio of the > specified element size to the largest element size used in the function. > Here > it is largelly inconsequential, but for instance "e32, mf4" and "e64, mf2= " > are > invalid. > > -- > =E9=9B=B7=E7=B1=B3=E2=80=A7=E5=BE=B7=E5=B0=BC-=E5=BA=93=E5=B0=94=E8=92=99 > http://www.remlab.net/ > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > --00000000000073dc110610419da2 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-lavc-rv34dsp-R-V-V-rv34_inv_transform_dc.patch" Content-Disposition: attachment; filename="0002-lavc-rv34dsp-R-V-V-rv34_inv_transform_dc.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ls23b4io0 RnJvbSA1MzhmZjhiMjBlYWQyNWQ5NWI4NTA3ZTMxODIwN2IxOWQ4OWE2M2MyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBzdW55dWVjaGkgPHN1bnl1ZWNoaUBpc2Nhcy5hYy5jbj4KRGF0 ZTogV2VkLCAzMSBKYW4gMjAyNCAxOTowMzoyMCArMDgwMApTdWJqZWN0OiBbUEFUQ0ggMi80XSBs YXZjL3J2MzRkc3A6IFItViBWIHJ2MzRfaW52X3RyYW5zZm9ybV9kYwoKQzkwODoKcnYzNF9pbnZf dHJhbnNmb3JtX2RjX2M6IDM1LjUKcnYzNF9pbnZfdHJhbnNmb3JtX2RjX3J2dl9pMzI6IDI3LjAK LS0tCiBsaWJhdmNvZGVjL3Jpc2N2L01ha2VmaWxlICAgICAgIHwgIDIgKysKIGxpYmF2Y29kZWMv cmlzY3YvcnYzNGRzcF9pbml0LmMgfCAzOSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysKIGxpYmF2Y29kZWMvcmlzY3YvcnYzNGRzcF9ydnYuUyAgfCAzOCArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKwogbGliYXZjb2RlYy9ydjM0ZHNwLmMgICAgICAgICAgICB8ICAyICsr CiBsaWJhdmNvZGVjL3J2MzRkc3AuaCAgICAgICAgICAgIHwgIDEgKwogNSBmaWxlcyBjaGFuZ2Vk LCA4MiBpbnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgbGliYXZjb2RlYy9yaXNjdi9y djM0ZHNwX2luaXQuYwogY3JlYXRlIG1vZGUgMTAwNjQ0IGxpYmF2Y29kZWMvcmlzY3YvcnYzNGRz cF9ydnYuUwoKZGlmZiAtLWdpdCBhL2xpYmF2Y29kZWMvcmlzY3YvTWFrZWZpbGUgYi9saWJhdmNv ZGVjL3Jpc2N2L01ha2VmaWxlCmluZGV4IGUxNWFiYTU4ZjQuLmZmZTY2MzFjZjIgMTAwNjQ0Ci0t LSBhL2xpYmF2Y29kZWMvcmlzY3YvTWFrZWZpbGUKKysrIGIvbGliYXZjb2RlYy9yaXNjdi9NYWtl ZmlsZQpAQCAtNDQsNiArNDQsOCBAQCBSVlYtT0JKUy0kKENPTkZJR19PUFVTX0RFQ09ERVIpICs9 IHJpc2N2L29wdXNkc3BfcnZ2Lm8KIE9CSlMtJChDT05GSUdfUElYQkxPQ0tEU1ApICs9IHJpc2N2 L3BpeGJsb2NrZHNwX2luaXQubwogUlYtT0JKUy0kKENPTkZJR19QSVhCTE9DS0RTUCkgKz0gcmlz Y3YvcGl4YmxvY2tkc3BfcnZpLm8KIFJWVi1PQkpTLSQoQ09ORklHX1BJWEJMT0NLRFNQKSArPSBy aXNjdi9waXhibG9ja2RzcF9ydnYubworT0JKUy0kKENPTkZJR19SVjM0RFNQKSArPSByaXNjdi9y djM0ZHNwX2luaXQubworUlZWLU9CSlMtJChDT05GSUdfUlYzNERTUCkgKz0gcmlzY3YvcnYzNGRz cF9ydnYubwogT0JKUy0kKENPTkZJR19TVlExX0VOQ09ERVIpICs9IHJpc2N2L3N2cWVuY19pbml0 Lm8KIFJWVi1PQkpTLSQoQ09ORklHX1NWUTFfRU5DT0RFUikgKz0gcmlzY3Yvc3ZxZW5jX3J2di5v CiBPQkpTLSQoQ09ORklHX1RBS19ERUNPREVSKSArPSByaXNjdi90YWtkc3BfaW5pdC5vCmRpZmYg LS1naXQgYS9saWJhdmNvZGVjL3Jpc2N2L3J2MzRkc3BfaW5pdC5jIGIvbGliYXZjb2RlYy9yaXNj di9ydjM0ZHNwX2luaXQuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi44 NTJjOGFkOWE4Ci0tLSAvZGV2L251bGwKKysrIGIvbGliYXZjb2RlYy9yaXNjdi9ydjM0ZHNwX2lu aXQuYwpAQCAtMCwwICsxLDM5IEBACisvKgorICogQ29weXJpZ2h0IChjKSAyMDI0IEluc3RpdHVl IG9mIFNvZnR3YXJlIENoaW5lc2UgQWNhZGVteSBvZiBTY2llbmNlcyAoSVNDQVMpLgorICoKKyAq IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEZGbXBlZy4KKyAqCisgKiBGRm1wZWcgaXMgZnJlZSBzb2Z0 d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkgaXQgdW5kZXIg dGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFz IHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZl cnNpb24gMi4xIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2 ZXJzaW9uLgorICoKKyAqIEZGbXBlZyBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0 IHdpbGwgYmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2 ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNT IEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgKiBMZXNzZXIgR2VuZXJh bCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQgaGF2 ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAqIExp Y2Vuc2UgYWxvbmcgd2l0aCBGRm1wZWc7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdh cmUKKyAqIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3Is IEJvc3RvbiwgTUEgMDIxMTAtMTMwMSBVU0EKKyAqLworCisjaW5jbHVkZSAiY29uZmlnLmgiCisK KyNpbmNsdWRlICJsaWJhdnV0aWwvYXR0cmlidXRlcy5oIgorI2luY2x1ZGUgImxpYmF2dXRpbC9j cHUuaCIKKyNpbmNsdWRlICJsaWJhdnV0aWwvcmlzY3YvY3B1LmgiCisjaW5jbHVkZSAibGliYXZj b2RlYy9ydjM0ZHNwLmgiCisKK3ZvaWQgZmZfcnYzNF9pbnZfdHJhbnNmb3JtX2RjX3J2dihpbnQx Nl90ICpibG9jayk7CisKK2F2X2NvbGQgdm9pZCBmZl9ydjM0ZHNwX2luaXRfcmlzY3YoUlYzNERT UENvbnRleHQgKmMpCit7CisjaWYgSEFWRV9SVlYKKyAgICBpbnQgZmxhZ3MgPSBhdl9nZXRfY3B1 X2ZsYWdzKCk7CisKKyAgICBpZiAoZmxhZ3MgJiBBVl9DUFVfRkxBR19SVlZfSTMyICYmIGZmX2dl dF9ydl92bGVuYigpID49IDE2KSB7CisgICAgICAgIGMtPnJ2MzRfaW52X3RyYW5zZm9ybV9kYyA9 IGZmX3J2MzRfaW52X3RyYW5zZm9ybV9kY19ydnY7CisgICAgfQorI2VuZGlmCit9CmRpZmYgLS1n aXQgYS9saWJhdmNvZGVjL3Jpc2N2L3J2MzRkc3BfcnZ2LlMgYi9saWJhdmNvZGVjL3Jpc2N2L3J2 MzRkc3BfcnZ2LlMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMC4uNGI3YTA3 MWY3YwotLS0gL2Rldi9udWxsCisrKyBiL2xpYmF2Y29kZWMvcmlzY3YvcnYzNGRzcF9ydnYuUwpA QCAtMCwwICsxLDM4IEBACisvKgorICogQ29weXJpZ2h0IChjKSAyMDI0IEluc3RpdHVlIG9mIFNv ZnR3YXJlIENoaW5lc2UgQWNhZGVteSBvZiBTY2llbmNlcyAoSVNDQVMpLgorICoKKyAqIFRoaXMg ZmlsZSBpcyBwYXJ0IG9mIEZGbXBlZy4KKyAqCisgKiBGRm1wZWcgaXMgZnJlZSBzb2Z0d2FyZTsg eW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRl cm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1Ymxp c2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNpb24g Mi4xIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9u LgorICoKKyAqIEZGbXBlZyBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwg YmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhl IGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBB IFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgKiBMZXNzZXIgR2VuZXJhbCBQdWJs aWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQgaGF2ZSByZWNl aXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAqIExpY2Vuc2Ug YWxvbmcgd2l0aCBGRm1wZWc7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdhcmUKKyAq IEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsIEJvc3Rv biwgTUEgMDIxMTAtMTMwMSBVU0EKKyAqLworCisjaW5jbHVkZSAibGliYXZ1dGlsL3Jpc2N2L2Fz bS5TIgorCitmdW5jIGZmX3J2MzRfaW52X3RyYW5zZm9ybV9kY19ydnYsIHp2ZTMyeAorICAgICAg ICBsaCAgICAgICAgICAgIHQxLCAwKGEwKQorICAgICAgICBzbGxpICAgICAgICAgIHQyLCB0MSwg NworICAgICAgICBzdWIgICAgICAgICAgIHQyLCB0MiwgdDEKKyAgICAgICAgc2xsaSAgICAgICAg ICB0MiwgdDIsIDIKKyAgICAgICAgc3ViICAgICAgICAgICB0MiwgdDIsIHQxCisgICAgICAgIHNy YWkgICAgICAgICAgdDIsIHQyLCAxMQorICAgICAgICBzbGxpICAgICAgICAgIHQyLCB0MiwgMTYK KyAgICAgICAgc3JhaSAgICAgICAgICB0MiwgdDIsIDE2CisgICAgICAgIHZzZXRpdmxpICAgICAg emVybywgMTYsIGUxNiwgbTIsIHRhLCBtYQorICAgICAgICB2bXYudi54ICAgICAgIHY4LCB0Mgor ICAgICAgICB2c2V0aXZsaSAgICAgIHplcm8sIDQsIGU4LCBtZjQsIHRhLCBtYQorICAgICAgICB2 c2U2NC52ICAgICAgIHY4LCAoYTApCisKKyAgICAgICAgcmV0CitlbmRmdW5jCmRpZmYgLS1naXQg YS9saWJhdmNvZGVjL3J2MzRkc3AuYyBiL2xpYmF2Y29kZWMvcnYzNGRzcC5jCmluZGV4IDhmOWQ4 ODM5NmMuLjQ0NDg2ZjhlZGQgMTAwNjQ0Ci0tLSBhL2xpYmF2Y29kZWMvcnYzNGRzcC5jCisrKyBi L2xpYmF2Y29kZWMvcnYzNGRzcC5jCkBAIC0xMzgsNiArMTM4LDggQEAgYXZfY29sZCB2b2lkIGZm X3J2MzRkc3BfaW5pdChSVjM0RFNQQ29udGV4dCAqYykKIAogI2lmIEFSQ0hfQVJNCiAgICAgZmZf cnYzNGRzcF9pbml0X2FybShjKTsKKyNlbGlmIEFSQ0hfUklTQ1YKKyAgICBmZl9ydjM0ZHNwX2lu aXRfcmlzY3YoYyk7CiAjZWxpZiBBUkNIX1g4NgogICAgIGZmX3J2MzRkc3BfaW5pdF94ODYoYyk7 CiAjZW5kaWYKZGlmZiAtLWdpdCBhL2xpYmF2Y29kZWMvcnYzNGRzcC5oIGIvbGliYXZjb2RlYy9y djM0ZHNwLmgKaW5kZXggMmU5ZWM0ZWVlNC4uYjE1NDI0ZDRhZSAxMDA2NDQKLS0tIGEvbGliYXZj b2RlYy9ydjM0ZHNwLmgKKysrIGIvbGliYXZjb2RlYy9ydjM0ZHNwLmgKQEAgLTc5LDYgKzc5LDcg QEAgdm9pZCBmZl9ydjM0ZHNwX2luaXQoUlYzNERTUENvbnRleHQgKmMpOwogdm9pZCBmZl9ydjQw ZHNwX2luaXQoUlYzNERTUENvbnRleHQgKmMpOwogCiB2b2lkIGZmX3J2MzRkc3BfaW5pdF9hcm0o UlYzNERTUENvbnRleHQgKmMpOwordm9pZCBmZl9ydjM0ZHNwX2luaXRfcmlzY3YoUlYzNERTUENv bnRleHQgKmMpOwogdm9pZCBmZl9ydjM0ZHNwX2luaXRfeDg2KFJWMzREU1BDb250ZXh0ICpjKTsK IAogdm9pZCBmZl9ydjQwZHNwX2luaXRfYWFyY2g2NChSVjM0RFNQQ29udGV4dCAqYyk7Ci0tIAoy LjQzLjAKCg== --00000000000073dc110610419da2 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --00000000000073dc110610419da2--