From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A301C43963 for ; Thu, 2 Feb 2023 17:44:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A419068BDCB; Thu, 2 Feb 2023 19:43:58 +0200 (EET) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9664B68BD86 for ; Thu, 2 Feb 2023 19:43:52 +0200 (EET) Received: by mail-pg1-f172.google.com with SMTP id s13so224708pgc.10 for ; Thu, 02 Feb 2023 09:43:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=QEGokSheKNKbV9x3f1CpRTQKp3cYZSNzkCbFFxoRvhs=; b=IshhHCF86ONp5Tl2JJE1zedqg6CC9J1ULJGbJfadgOEBpoRodoVUhixh9rkAjI5IPo ewPAV7anz6v7jN3we2sU861D78Rmmxl3qu17k6RXYJVIuyb3q7zD7jwPZsdu6Yjr2XLF XTukKsDvu3+aQH0PzQaO7sBlfG6tOjMTybi71RRfRvl/Cy9l5uWxOp+VxnKrkGkIwjHv zyunzbobZesRx6qqYXwPYSmQxpdeTduprbrorbKvBg1pYQQDJixWleiUK0hcWaL8pj9z NPnuF9TjawYy/KIGMUI+tjWijZiAaRq7I7YvhnVb7QW4DMVfmRB13UUJmPaYr0XvWxda 54DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QEGokSheKNKbV9x3f1CpRTQKp3cYZSNzkCbFFxoRvhs=; b=r5Vj9VKVyGzBXKBRvtoXAFQgO5prH64G1ZCrJTbNWDDvMcpb7RWTl/EtO+SoRzHZLt aq8nx7hJq8TSlIF1AV7BaAagOXT/WIdHhcPhFLaYjFOCMh4J3naWbvHHwdchUri1mGrK TjSvDG0h25+WyT6FLvAz0KONO8Z36xgqj7dqeVYa8oX4AZabyv5B/r2IIHgxw7ZuoN66 xxIvFZj0uAwU4DmekDiQhIctGDFEEv1erLr/hyPzUXU5aQHYKQ5uw1DykUBqQjTGzJY8 PV0XIOphaU3AhkMxW59seAFk+u1GGV11kO6CL6RRsfapu7c0OYLEFjiJP2F1MnhIyG+n Rktg== X-Gm-Message-State: AO0yUKWH7/YM01wsC9XAjD5gEFYqFMSehUIU0Uzbu8VD1amDQQY1yY8r Z88tJF5Zmql86BmNlz68qA/GiGRYTrRAMKNWlDXZ+wiKA94= X-Google-Smtp-Source: AK7set8uJiOxLJLE9XQCMRClWJjL5A0pWmx2wnKdyKN3ykmWxoMpoVwU+7caLvdfPPSDfgpc5SpbJUXBTzI3RL0Quvs= X-Received: by 2002:a05:6a00:4089:b0:592:5cbf:c71f with SMTP id bw9-20020a056a00408900b005925cbfc71fmr1598848pfb.29.1675359830295; Thu, 02 Feb 2023 09:43:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: John Coiner Date: Thu, 2 Feb 2023 12:43:39 -0500 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc.c -- correctly re-emit extradata ahead of IDR pictures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, Jan 30, 2023 at 4:12 PM Marton Balint wrote: > > For normal mpegts it also makes sense to include SPS/PPS before IDR-s, so > I'd say it is better if it is fixed in mpegtsenc. > > But it is mandatory to insert AUD NAL-s for every frame, and your patch > breaks that, because it only inserts it if SPS/PPS is also inserted, > because you changed > > if ((state & 0x1f) != 9) { // AUD NAL > > to > > if (extradd > 0) { > > So you need to rework your patch to keep the AUD insertion (but you don't > want to duplicate it of course). > > Regards, > Marton > Marton, thank you for this explanation. I understand now. There's an updated patch that preserves AUD insertion at http://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/306143.html Posting to bump the visibility of that one, which perhaps should have been tagged "v2", whoops. Should I repost with "v2" to start a new thread? Cheers, John _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".