From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 23E60456EA for ; Sat, 18 Feb 2023 19:36:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1DA9568BEF6; Sat, 18 Feb 2023 21:36:11 +0200 (EET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A66D68BED5 for ; Sat, 18 Feb 2023 21:36:05 +0200 (EET) Received: by mail-pj1-f47.google.com with SMTP id g2so1332644pjp.2 for ; Sat, 18 Feb 2023 11:36:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=Dct6kv3r9BaXaNFtd15yDjQrwwKPrSU7yI4e1y/LiOw=; b=Po//TWCPBjFAnFwPQ7WjLl5NjXjAispf5uiQaqgwAW2S4yjICZWwynN4KGLrDTXz7f IUh/duOlNN76uAma78NlGn7FS0sFVYjZRfXWznpPsQUJVQX1ajsClZjvLHD5FIvUnk0S vr5qX397uCCSkOoS96hsh3OimRNUCmHW9T+LjwFSkKLl9jxtOsU2YZQ/NGyO7mUlrUhZ 5AIQdKZdlz7nB1JdhKpbRV31W5tF/ZHGyXX7SD+rYZiJPSiXo6CsufG3Lq49rYEYTu9f BcWLNPPf5f1OzEzCHzS3NkQiXE4AoGVIvK5lGVK54mQpsSgxnPZ/810czyhm7bs4URI7 EXSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dct6kv3r9BaXaNFtd15yDjQrwwKPrSU7yI4e1y/LiOw=; b=zOPyrIhnDnHIW8dSsehzzGTno/5uRHmL00R1axjg/rtl4L6dqRDnoMXw0f/e54gDXN JnsQDpdu2wP0SGpogo6w12gsdHszggTBIwqkrDzFPkLejSTjbE74geYiAGSgme9OI88V 7R0vcCYbp00/wq2GL7AnXfTZq+b5Qn6fJCXV+k9alA+sS2Nfj3ftEpICH05WiCYf+8OA lJmrAc1xnQrFK6XZxLxN65/MfjVvrNx1bUoPL42L3FSScIhXyHKKQQDW1EYqtAxgTEqd 1frtwOjEqQjgGMuEiET+RLOjLaDISTFVZPNwMmh/N9dFbpT015s6A7vswici9TyUhjgm T3pQ== X-Gm-Message-State: AO0yUKXR807/69NTZ8FmytgWxiUrRQwmxKSSe+W5Lf3Daq4K23fMSXY7 ICUvKt8arzpNp6Q3ATbgZa9OW3f+BgFe9LqJWePmRa/D2bA= X-Google-Smtp-Source: AK7set9bIsDikpYY+QJ7Z33IJaP5QPpCAkWZ1tlfn8rfIi6t2w0G3dE7crs584hUdZ0IUT8Bs/ozU4O221t761q91qA= X-Received: by 2002:a17:90b:3e88:b0:233:c7d1:384f with SMTP id rj8-20020a17090b3e8800b00233c7d1384fmr209632pjb.48.1676748962486; Sat, 18 Feb 2023 11:36:02 -0800 (PST) MIME-Version: 1.0 References: <20230212230607.180234-1-jpcoiner@gmail.com> <1e4cd742-ed5c-d6f4-20fe-9461208233ee@passwd.hu> In-Reply-To: <1e4cd742-ed5c-d6f4-20fe-9461208233ee@passwd.hu> From: John Coiner Date: Sat, 18 Feb 2023 14:35:51 -0500 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc.c: correctly re-emit extradata ahead of IDR pictures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Feb 16, 2023 at 7:36 PM Marton Balint wrote: > > > > On Sun, 12 Feb 2023, John Coiner wrote: > > > This is v2 of the patch for https://trac.ffmpeg.org/ticket/10148. > > > > It implements the handling described at http://ffmpeg.org/pipermail/ffmpeg-devel/2023-February/306542.html, that is: > > * If we receive [AUD][IDR], we emit [AUD][SPS][PPS][IDR] > > * If we receive [SEI][AUD][IDR], we emit [AUD][SPS][PPS][SEI][IDR] > > > > This is speculative; it would be good to hear from Marton or others about whether this is the right handling. > > Looks fine to me, but I am no expert in H264 either. > > Can you check and test the attached patch? It contins cosmetic changes to > your work. If that looks OK to you as well, than I will apply it in a few > days. > > Thanks, > Marton > Thank you for the cleanups! I reviewed and tested this, it's working and seems to be equivalent to my last patch. It looks ready to apply. Cheers, John _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".