From: John Coiner <jpcoiner@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc.c: correctly re-emit extradata ahead of IDR pictures
Date: Sat, 18 Feb 2023 14:35:51 -0500
Message-ID: <CAEP=B=FNCNVDtyBnn2xHcS1oNe0_TvMV-V4gA+iF62heHsufkQ@mail.gmail.com> (raw)
In-Reply-To: <1e4cd742-ed5c-d6f4-20fe-9461208233ee@passwd.hu>
On Thu, Feb 16, 2023 at 7:36 PM Marton Balint <cus@passwd.hu> wrote:
>
>
>
> On Sun, 12 Feb 2023, John Coiner wrote:
>
> > This is v2 of the patch for https://trac.ffmpeg.org/ticket/10148.
> >
> > It implements the handling described at http://ffmpeg.org/pipermail/ffmpeg-devel/2023-February/306542.html, that is:
> > * If we receive [AUD][IDR], we emit [AUD][SPS][PPS][IDR]
> > * If we receive [SEI][AUD][IDR], we emit [AUD][SPS][PPS][SEI][IDR]
> >
> > This is speculative; it would be good to hear from Marton or others about whether this is the right handling.
>
> Looks fine to me, but I am no expert in H264 either.
>
> Can you check and test the attached patch? It contins cosmetic changes to
> your work. If that looks OK to you as well, than I will apply it in a few
> days.
>
> Thanks,
> Marton
>
Thank you for the cleanups! I reviewed and tested this, it's working
and seems to be equivalent to my last patch. It looks ready to apply.
Cheers,
John
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-02-18 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 23:06 John Coiner
2023-02-17 0:36 ` Marton Balint
2023-02-18 19:35 ` John Coiner [this message]
2023-02-20 15:28 ` Anton Khirnov
2023-02-20 22:21 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEP=B=FNCNVDtyBnn2xHcS1oNe0_TvMV-V4gA+iF62heHsufkQ@mail.gmail.com' \
--to=jpcoiner@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git