From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D373A47DD9 for ; Sun, 25 Feb 2024 16:23:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7FD8168C620; Sun, 25 Feb 2024 18:23:00 +0200 (EET) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4F2B868A906 for ; Sun, 25 Feb 2024 18:22:53 +0200 (EET) Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-512b29f82d1so2997798e87.1 for ; Sun, 25 Feb 2024 08:22:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708878172; x=1709482972; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=8aiYmWeMN9K4cE162DB/ssHx0XmgCszBa1yzVmwUPgU=; b=XmwbkJt7BS2KUw4MCYsfHuKpm/HfnkpAsw5MZwsT3pkRW/2g4HLJK5dyWQrwoG6/z8 2j6GrLhWDmHdddiKKfMLALj7GO0k9meBHllAc4yzTP0odp/D+MOYQFfNC5BfbbfHqSTW TPPIEgOukbuwSbGW91URAPALupAaCTvwaB8mPXESehZVbCjRKIqyFD4+3hRglFC9IGSe /bcvdQoGqpBw7Seyb48UzAmJYp9IFrtTdiJ1NbEhEIf0gAXW3YiPr1gUgMPYEvbxqIG7 Fwv6eFrywqXAKSOsk23vbRYl4+lNnsY3xBAtJV6LNIGAI4qHGpuyWixO0s9p8oi2/Gms CkDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708878172; x=1709482972; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8aiYmWeMN9K4cE162DB/ssHx0XmgCszBa1yzVmwUPgU=; b=CfNeI+r5cJJ3PkDnHMYrQpRNMakyH7ADGxhpuKwzZool8KmKchuf6Oe+lnZgCln2XM 7B46hCXmNe5EjXnyWAcXTgsXMaOq6cyptUSig9vSpw4ob38z/vNAQqUsA0ADZvxa7Nib 0s2HaX9yw7AlSrJUBHo7pWo2hPSxbazG8hLglMwIWYVb8PL3E7MVrphtAY9IIVYB9h7v C5UxFnoQvdA6L1Ch8kdf/oZRnkh4D8EaDeykEm+VRhM9XF8jPPq7LVmxo4cuiq4ACgdo ieER4H6J5ZWQf1q7EYtofPv5Am/ZeBuojHcCgmZrvl2KaSQed2A1JpEMyCUoU4TSTOww WMKQ== X-Gm-Message-State: AOJu0Yxu3oBUclRMrs4h965I54rgp0hhCnXtEZMBGEOpM0URUU3UnERZ u5YxTkmvFpcDIDUs2aJlX0NCvPwUBWYlsnUqO+H726s3S5FAckyYN57EVAbq+PLmt+LQt/gol3H 0Et2iuATpx5LGCFxZz1SCqY42bZy+wA9P X-Google-Smtp-Source: AGHT+IE39YCstLDLY+5hkvoomLSiYEvRPOEdZ6lsr29ma/9BUKk09orSZZ108WC8+Phmok74zzrA8I5MiZvldfDIAzQ= X-Received: by 2002:a05:6512:144:b0:512:abeb:96f3 with SMTP id m4-20020a056512014400b00512abeb96f3mr2732261lfo.39.1708878171963; Sun, 25 Feb 2024 08:22:51 -0800 (PST) MIME-Version: 1.0 References: <20240225082755.355295-1-jdek@itanimul.li> In-Reply-To: From: "Ronald S. Bultje" Date: Sun, 25 Feb 2024 11:22:40 -0500 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="00000000000067ad3d0612373455" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc: fix luma 12b overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --00000000000067ad3d0612373455 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Feb 25, 2024 at 10:56=E2=80=AFAM Ronald S. Bultje wrote: > Hi, > > On Sun, Feb 25, 2024 at 3:28=E2=80=AFAM J. Dekker wrot= e: > >> Weak filter can overflow in delta0 calculation before >> 4 in int16. >> >> Signed-off-by: J. Dekker >> --- >> >> I do not know x86 simd at all, so this is just an attempt to fix >> the implementation rather than write extremely performant code. >> >> Suggestions welcome. >> > > https://pastebin.com/KvcbQ2nK > Attached a slightly adjusted version which does sse2 in 16bit also. Ronald --00000000000067ad3d0612373455 Content-Type: application/octet-stream; name="0001-hevx-x86-deblock-fix-12bit-overflow.patch" Content-Disposition: attachment; filename="0001-hevx-x86-deblock-fix-12bit-overflow.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lt1pwrkd0 RnJvbSBlYjM0NzgzOGY2ZTA3NTY3OTEyOTY5YjgwZTRlMzhmYjU4N2EwMTAxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUm9uYWxkIFMuIEJ1bHRqZSIgPHJzYnVsdGplQGdtYWlsLmNv bT4KRGF0ZTogU3VuLCAyNSBGZWIgMjAyNCAxMDo0OTozNSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hd IGhldngveDg2L2RlYmxvY2s6IGZpeCAxMmJpdCBvdmVyZmxvdy4KCi0tLQogbGliYXZjb2RlYy94 ODYvaGV2Y19kZWJsb2NrLmFzbSB8IDQxICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0t LQogMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGliYXZjb2RlYy94ODYvaGV2Y19kZWJsb2NrLmFzbSBiL2xpYmF2Y29kZWMveDg2 L2hldmNfZGVibG9jay5hc20KaW5kZXggODVlZTQ4MDBiYi4uMjRiYjk1ODQ3NCAxMDA2NDQKLS0t IGEvbGliYXZjb2RlYy94ODYvaGV2Y19kZWJsb2NrLmFzbQorKysgYi9saWJhdmNvZGVjL3g4Ni9o ZXZjX2RlYmxvY2suYXNtCkBAIC0zMSw2ICszMSw3IEBAIGNleHRlcm4gcHdfMTAyMwogcHdfcGl4 ZWxfbWF4XzEyOiB0aW1lcyA4IGR3ICgoMSA8PCAxMiktMSkKIHB3X20yOiAgICAgICAgICAgdGlt ZXMgOCBkdyAtMgogcGRfMSA6ICAgICAgICAgICB0aW1lcyA0IGRkICAxCitwZF84IDogICAgICAg ICAgIHRpbWVzIDggZGQgIDgKIAogY2V4dGVybiBwd180CiBjZXh0ZXJuIHB3XzgKQEAgLTU0MSwx OSArNTQyLDQyIEBAIEFMSUdOIDE2CiAgICAgYWRkICAgICAgICAgICAgIGJldGFxLCByMTMKICAg ICBzaHIgICAgICAgICAgICAgYmV0YXEsIDM7ICgoYmV0YSArIChiZXRhID4+IDEpKSA+PiAzKSkK IAotICAgIG1vdmEgICAgICAgICAgICBtMTMsIFtwd184XQogICAgIHBzdWJ3ICAgICAgICAgICBt MTIsIG00LCBtMyA7IHEwIC0gcDAKLSAgICBwc2xsdyAgICAgICAgICAgbTEwLCBtMTIsIDM7IDgg KiAocTAgLSBwMCkKLSAgICBwYWRkdyAgICAgICAgICAgbTEyLCBtMTAgOyA5ICogKHEwIC0gcDAp Ci0KKyAgICBwYWRkdyAgICAgICAgICAgbTEwLCBtMTIsIG0xMgorICAgIHBhZGR3ICAgICAgICAg ICBtMTIsIG0xMCA7IDMgKiAocTAgLSBwMCkKICAgICBwc3VidyAgICAgICAgICAgbTEwLCBtNSwg bTIgOyBxMSAtIHAxCi0gICAgcHNsbHcgICAgICAgICAgICBtOCwgbTEwLCAxOyAyICogKCBxMSAt IHAxICkKLSAgICBwYWRkdyAgICAgICAgICAgbTEwLCBtODsgMyAqICggcTEgLSBwMSApCi0gICAg cHN1YncgICAgICAgICAgIG0xMiwgbTEwOyA5ICogKHEwIC0gcDApIC0gMyAqICggcTEgLSBwMSAp CisgICAgcHN1YncgICAgICAgICAgIG0xMiwgbTEwIDsgMyAqIChxMCAtIHAwKSAtIChxMSAtIHAx KQorJWlmICUxIDwgMTIKKyAgICBtb3ZhICAgICAgICAgICAgbTEzLCBbcHdfOF0KKyAgICBwYWRk dyAgICAgICAgICAgbTEwLCBtMTIsIG0xMgorICAgIHBhZGR3ICAgICAgICAgICBtMTIsIG0xMCA7 IDkgKiAocTAgLSBwMCkgLSAzICogKCBxMSAtIHAxICkKICAgICBwYWRkdyAgICAgICAgICAgbTEy LCBtMTM7ICsgOAogICAgIHBzcmF3ICAgICAgICAgICBtMTIsIDQ7ID4+IDQgLCBkZWx0YTAKICAg ICBQQUJTVyAgICAgICAgICAgbTEzLCBtMTI7IGFicyhkZWx0YTApCi0KKyVlbGlmIGNwdWZsYWco c3NzZTMpCisgICAgcGFic3cgICAgICAgICAgIG0xMywgbTEyCisgICAgcGFkZHcgICAgICAgICAg IG0xMCwgbTEzLCBtMTMKKyAgICBwYWRkdyAgICAgICAgICAgbTEzLCBtMTAgOyBhYnMoOSAqIChx MCAtIHAwKSAtIDMgKiAoIHExIC0gcDEgKSkKKyAgICBwYWRkdyAgICAgICAgICAgbTEzLCBbcHdf OF0KKyAgICBweG9yICAgICAgICAgICAgbTEwLCBtMTAKKyAgICBwY21wZ3R3ICAgICAgICAgbTEw LCBtMTIKKyAgICBwYWRkdyAgICAgICAgICAgbTEzLCBtMTAKKyAgICBwc3JsdyAgICAgICAgICAg bTEzLCA0OyA+PiA0LCBhYnMoZGVsdGEwKQorICAgIHBzaWdudyAgICAgICAgICBtMTAsIG0xMywg bTEyCisgICAgU1dBUCAgICAgICAgICAgICAxMCwgMTIKKyVlbHNlCisgICAgcHhvciAgICAgICAg ICAgIG0xMCwgbTEwCisgICAgcGNtcGd0dyAgICAgICAgIG0xMCwgbTEyCisgICAgcHhvciAgICAg ICAgICAgIG0xMiwgbTEwCisgICAgcHN1YncgICAgICAgICAgIG0xMiwgbTEwIDsgYWJzKCkKKyAg ICBwYWRkdyAgICAgICAgICAgbTEzLCBtMTIsIG0xMgorICAgIHBhZGR3ICAgICAgICAgICBtMTMs IG0xMiA7IDMqYWJzKG0xMikKKyAgICBwYWRkdyAgICAgICAgICAgbTEzLCBbcHdfOF0KKyAgICBw YWRkdyAgICAgICAgICAgbTEzLCBtMTAKKyAgICBwc3JsdyAgICAgICAgICAgbTEzLCA0CisgICAg cHhvciAgICAgICAgICAgIG0xMiwgbTEzLCBtMTAKKyAgICBwc3VidyAgICAgICAgICAgbTEyLCBt MTAKKyVlbmRpZgogCiAgICAgcHNsbHcgICAgICAgICAgIG0xMCwgbTksIDI7IDggKiB0YwogICAg IHBhZGR3ICAgICAgICAgICBtMTAsIG05OyAxMCAqIHRjCkBAIC04NTksNyArODgzLDYgQEAgY2ds b2JhbCBoZXZjX2hfbG9vcF9maWx0ZXJfbHVtYV8xMiwgNCwgMTQsIDE2LCBwaXgsIHN0cmlkZSwg YmV0YSwgdGMsIHBpeDAsIHNyYzMKICAgICBtb3ZkcXUgICAgIFtwaXhxICArIDIgKiBzdHJpZGVx XSwgbTY7ICBxMgogLmJ5cGFzc2x1bWE6CiAgICAgUkVUCi0KICVlbmRtYWNybwogCiBJTklUX1hN TSBzc2UyCi0tIAoyLjQzLjEKCg== --00000000000067ad3d0612373455 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --00000000000067ad3d0612373455--