Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorspace: fix message for missing/incorrect colorspace

From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Sami Boukortt <sboukortt@google.com>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorspace: fix message for missing/incorrect colorspace
Date: Tue, 30 May 2023 09:06:15 -0400
Message-ID: <CAEEMt2nLWbvFTy0cfHibTWy3LPdUFqHg4xf9haw0+9zyJu3qEw@mail.gmail.com> (raw)
In-Reply-To: <20230530102906.2108897-1-sboukortt@google.com>

Hi,

On Tue, May 30, 2023 at 6:29 AM Sami Boukortt <
sboukortt-at-google.com@ffmpeg.org> wrote:

> ---
>  libavfilter/vf_colorspace.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c
> index 21916b7b7a..852dc11c6c 100644
> --- a/libavfilter/vf_colorspace.c
> +++ b/libavfilter/vf_colorspace.c
> @@ -572,15 +572,15 @@ static int create_filtergraph(AVFilterContext *ctx,
>              if (s->out_csp == AVCOL_SPC_UNSPECIFIED) {
>                  if (s->user_all == CS_UNSPECIFIED) {
>                      av_log(ctx, AV_LOG_ERROR,
> -                           "Please specify output transfer
> characteristics\n");
> +                           "Please specify output colorspace\n");
>                  } else {
>                      av_log(ctx, AV_LOG_ERROR,
>                             "Unsupported output color property %d\n",
> s->user_all);
>                  }
>              } else {
>                  av_log(ctx, AV_LOG_ERROR,
> -                       "Unsupported output transfer characteristics %d
> (%s)\n",
> -                       s->out_csp, av_color_space_name(s->out_csp));
> +                       "Unsupported output colorspace %d (%s)\n",
> s->out_csp,
> +                       av_color_space_name(s->out_csp));
>              }
>              return AVERROR(EINVAL);
>          }
> --
> 2.41.0.rc0.172.g3f132b7071-goog
>

Good catch, thanks. Merged.

Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".