From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 39DEB44CD0 for ; Sat, 14 Jan 2023 15:52:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3527868A4DB; Sat, 14 Jan 2023 17:52:39 +0200 (EET) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9915168A4DB for ; Sat, 14 Jan 2023 17:52:32 +0200 (EET) Received: by mail-ej1-f41.google.com with SMTP id cf18so52371962ejb.5 for ; Sat, 14 Jan 2023 07:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=BnTKUaJQhdquP3BRN6Jo+XCGNr7rmBCDE3QthtgjohM=; b=Rxzf47NiES478DqAL+CExiOeAdw15WKI82tmpRhRLqxn6GvZKmkqqRrZeCuHhpRTMH MNPDwt9I53Z3W2yzCOrpseqptxUvt9+ECquDrdeKb4HfAtGKhDafJ5NWBPW6BdePbIRA /efMg3M8Tnvlqx3tzSYU/TTk+8HIvXXDoxJAD602YNbwIJOnC85A1ZLftGLcQ6jeKtXa sm1TQgOBgPrAfAagGxYtw7cfrPIv+V7tQSiPuc9Np+pXQSMzoYndeCDIsGqooKtd4ooB EniMtP4VHcxev6470PgD1FI6GPHme/PkQ2mtd32noUoRqf1XTmMjN6y/2vhHRUDpCvVY iudA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BnTKUaJQhdquP3BRN6Jo+XCGNr7rmBCDE3QthtgjohM=; b=ai/7blOD0qqvbnaBm8AdiP/xAhrACZwtqc++X8fY8fjLn/92DEqUZnksnklluaNR6M 23gkyzrH2RaKwAWbz2l0fTv2qn0Quj2+rQHbvYWZXx2YmLtw3r/+txue6W2FguhSwWE9 OjKP6DmT5KCXiNUODO/ARQRLO8+tiXMPvfu5F6M+754GXRwOvgxKh24Fe3aX9aTO5zlD qLdvmuH73ZzGdBmbRz7o2Vz8k+zurqGhClqhnz0xZ5gI/L1YYlFY93dPRMBgw8NvflBx GQo+K5twcWpN0e5h0htTiiV3mdKkbR6agX5lnkfeRws7PijXKSSjak1Osryxfalt03IN gqaw== X-Gm-Message-State: AFqh2krkhwz1X8qwQQM0z1Wooe343N0g1yq9L0UllqcDNUGSseXQFN++ +PpGrf6FBFuoMHGbURIrYhX9PrrXutWV4WgUPMPwljSp X-Google-Smtp-Source: AMrXdXsKEB2K7/LX1EvziaXXByDVGdKmkPW6RU5TMf6RRrwFc0kII1rlcr4qC0mO7gajHneypBNKNbmjoKmPf3Sdpn0= X-Received: by 2002:a17:906:2857:b0:82d:1b76:1e44 with SMTP id s23-20020a170906285700b0082d1b761e44mr6561168ejc.93.1673711551545; Sat, 14 Jan 2023 07:52:31 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "Ronald S. Bultje" Date: Sat, 14 Jan 2023 10:52:20 -0500 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Sat, Jan 14, 2023 at 10:16 AM Nuo Mi wrote: > On Sat, Jan 14, 2023 at 10:28 PM Ronald S. Bultje > > How come vvcdsp has only 8/10 bits/component code but vvcpred has > 8/9/10/12 > > bits/component code? > > I will remove it. > Not sure how applicable this is, but for AV1 (dav1d), most high-bitdepth (non-8 bits/component) code has the same container type requirements (e.g. "fits in int16_t"), so we add a "limit" (analogous "bitdepth") argument to relevant functions and then only have to implement it once for all non-8 bits/component implementations. This is different from *_template.c versions, because the binary size is actually significantly reduced. A further advantage is that implementing hand-written arch-specific implementations (asm) for one higher bitdepth automatically works for all. Best of all: there's no runtime penalty. Maybe you want to consider that for vvc also. (It's probably too late to fix ffh264/hevc/vp9.) I can elaborate further if you're interested (maybe IRC?). The more complex the codec gets (vvc > hevc > h264 > mpeg, and av1 > vp9 > vp8), the higher the (binary) codesize gains from such an implementation choice. FFmpeg is already huge so it's worth trying to trim its fat a bit. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".