Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder.
Date: Sat, 14 Jan 2023 10:52:20 -0500
Message-ID: <CAEEMt2n3d91FifktXRRnRpsJNZ32eYiT4CK0dV+frxikkGxysA@mail.gmail.com> (raw)
In-Reply-To: <CAFXK13d95YMkeXDtsjTAaBL2HStbtqywnRm4GGNmcS187Mf_GQ@mail.gmail.com>

Hi,

On Sat, Jan 14, 2023 at 10:16 AM Nuo Mi <nuomi2021@gmail.com> wrote:

> On Sat, Jan 14, 2023 at 10:28 PM Ronald S. Bultje <rsbultje@gmail.com>
> > How come vvcdsp has only 8/10 bits/component code but vvcpred has
> 8/9/10/12
> > bits/component code?
>
> I will remove it.
>

Not sure how applicable this is, but for AV1 (dav1d), most high-bitdepth
(non-8 bits/component) code has the same container type requirements (e.g.
"fits in int16_t"), so we add a "limit" (analogous "bitdepth") argument to
relevant functions and then only have to implement it once for all non-8
bits/component implementations. This is different from *_template.c
versions, because the binary size is actually significantly reduced. A
further advantage is that implementing hand-written arch-specific
implementations (asm) for one higher bitdepth automatically works for all.
Best of all: there's no runtime penalty. Maybe you want to consider that
for vvc also. (It's probably too late to fix ffh264/hevc/vp9.)

I can elaborate further if you're interested (maybe IRC?). The more complex
the codec gets (vvc > hevc > h264 > mpeg, and av1 > vp9 > vp8), the higher
the (binary) codesize gains from such an implementation choice. FFmpeg is
already huge so it's worth trying to trim its fat a bit.

Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-01-14 15:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-14 13:13 Nuo Mi
2023-01-14 13:32 ` Nuo Mi
2023-01-14 13:53   ` Paul B Mahol
2023-01-14 14:12     ` Nuo Mi
2023-01-14 14:28   ` Ronald S. Bultje
2023-01-14 15:15     ` Nuo Mi
2023-01-14 15:52       ` Ronald S. Bultje [this message]
2023-01-15  9:08         ` Nuo Mi
2023-02-01 14:02         ` Nuo Mi
2023-01-26 12:23   ` Thilo Borgmann
2023-01-26 13:35     ` Nuo Mi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEEMt2n3d91FifktXRRnRpsJNZ32eYiT4CK0dV+frxikkGxysA@mail.gmail.com \
    --to=rsbultje@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git