From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9DB2242BE1 for ; Tue, 31 May 2022 14:26:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C07C168B6C3; Tue, 31 May 2022 17:26:49 +0300 (EEST) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0FC9668B475 for ; Tue, 31 May 2022 17:26:43 +0300 (EEST) Received: by mail-ed1-f45.google.com with SMTP id fd25so17778621edb.3 for ; Tue, 31 May 2022 07:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xxgbr7nP4I9xCjluvWut8VJ29ljYAfHL2jNIuIDxLrE=; b=NuhEr4hHqa2W0I2CoqsQAIgdEZ8GDbKe1COK7yTjQ4UOeatxeJYnpAd/7WKFy7fR2c 4ieRuAvnEFAiqmSyDnD401dF3yQf1QsJUEXiMgxEjtp2j0zX5k4/PqL0J/IdRSxb9Ecf moWDciPK6FJqcSpJI2Wct/0Qo2CBoSRrjhBf0gqMNEsPRoZ9Ktg8qAhGkS1xcWZRckwO 4npau1zOAithVrAl1mKUyJdtnq8Epe415TqOsfMecq5PxnC8n4my15L8wO7uwINXxzdM aaQC8HBJKNKbwO9vxKr6MaW1LmUlpYikQuB23VNrhpqOwT4yIlD/f/W+5qN36YAjAf2s 0j1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xxgbr7nP4I9xCjluvWut8VJ29ljYAfHL2jNIuIDxLrE=; b=3q3PRRre2EnhnbQzmTJUAfBDkwB5hkACI9WjijUBxIZZi8XX/RxZznh1Wm7Vow04oU aClZhBI2M5QIluKn6sYezzEEQbwEYZsyU1KiFJbjKrnu7TSbdZh+c4AzTACiZgDj6iEh VeehPA0K9jcN/GWk4s+evrZo7egaHJcam7I37elFi2xz41gkGyM7tRXHbVInQpkMD2Qf +B+/WcahlZOZIF9Vp5BZFKWAn4MaT+nlSnx28wS5p2YzCGqpMrvjxFXACPIxfcZhLnOv nG1UDPeoX8YXzLh9460wLU4BOiQS7otxSxwaJFMENSuXwoHMu6Pp00/mFcBvO9/P3Qoq EnPA== X-Gm-Message-State: AOAM532g+62TCRnrmETiAgFQnVvkXIqQOl+1Cfndl+KU6K604yaIMF3S cNpxkmCzHxvkWgcO2K8iFjoJhrKrM51yIHca7dzd/9D6 X-Google-Smtp-Source: ABdhPJxj51JrupmqkPN0aDk/tMkBAPtOgqh9lDO60LC+rnOcIJ0SwlrKnj2Aybbd95TkaHIf6Z+SmDkGzZKlKRrRBiA= X-Received: by 2002:aa7:c34d:0:b0:42d:ce57:5df2 with SMTP id j13-20020aa7c34d000000b0042dce575df2mr12907211edr.315.1654007201569; Tue, 31 May 2022 07:26:41 -0700 (PDT) MIME-Version: 1.0 References: <20220528133036.33914-1-leo.izen@gmail.com> <20220528133036.33914-2-leo.izen@gmail.com> In-Reply-To: <20220528133036.33914-2-leo.izen@gmail.com> From: "Ronald S. Bultje" Date: Tue, 31 May 2022 10:26:29 -0400 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v7 1/1] avutil/csp: create public API for colorspace structs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Sat, May 28, 2022 at 9:30 AM Leo Izen wrote: > This commit moves some of the functionality from avfilter/colorspace > into avutil/csp and exposes it as a public API so it can be used by > libavcodec and/or libavformat. It also converts those structs from > double values to AVRational to make regression testing easier and > more consistent. > --- > libavfilter/colorspace.c | 143 ++++++++---------------------------- > libavfilter/colorspace.h | 31 +------- > libavfilter/fflcms2.c | 33 +++++---- > libavfilter/fflcms2.h | 4 +- > libavfilter/vf_colorspace.c | 37 +++++----- > libavfilter/vf_iccdetect.c | 5 +- > libavfilter/vf_tonemap.c | 17 +---- > libavutil/Makefile | 2 + > libavutil/csp.c | 128 ++++++++++++++++++++++++++++++++ > libavutil/csp.h | 106 ++++++++++++++++++++++++++ > libavutil/version.h | 2 +- > 11 files changed, 317 insertions(+), 191 deletions(-) > create mode 100644 libavutil/csp.c > create mode 100644 libavutil/csp.h > As far as I can see, all comments have been addressed and there's support for merging this from multiple people (including me). I intend to push this in 24 hrs if there are no further comments. Please comment if you disagree. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".