From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Leo Izen <leo.izen@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v7 1/1] avutil/csp: create public API for colorspace structs
Date: Tue, 31 May 2022 10:26:29 -0400
Message-ID: <CAEEMt2moLvJwQpvL5GCta=EvN2HihWccZCtdcDKhMRXY++Q0BA@mail.gmail.com> (raw)
In-Reply-To: <20220528133036.33914-2-leo.izen@gmail.com>
Hi,
On Sat, May 28, 2022 at 9:30 AM Leo Izen <leo.izen@gmail.com> wrote:
> This commit moves some of the functionality from avfilter/colorspace
> into avutil/csp and exposes it as a public API so it can be used by
> libavcodec and/or libavformat. It also converts those structs from
> double values to AVRational to make regression testing easier and
> more consistent.
> ---
> libavfilter/colorspace.c | 143 ++++++++----------------------------
> libavfilter/colorspace.h | 31 +-------
> libavfilter/fflcms2.c | 33 +++++----
> libavfilter/fflcms2.h | 4 +-
> libavfilter/vf_colorspace.c | 37 +++++-----
> libavfilter/vf_iccdetect.c | 5 +-
> libavfilter/vf_tonemap.c | 17 +----
> libavutil/Makefile | 2 +
> libavutil/csp.c | 128 ++++++++++++++++++++++++++++++++
> libavutil/csp.h | 106 ++++++++++++++++++++++++++
> libavutil/version.h | 2 +-
> 11 files changed, 317 insertions(+), 191 deletions(-)
> create mode 100644 libavutil/csp.c
> create mode 100644 libavutil/csp.h
>
As far as I can see, all comments have been addressed and there's support
for merging this from multiple people (including me). I intend to push this
in 24 hrs if there are no further comments. Please comment if you disagree.
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-31 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 13:30 [FFmpeg-devel] [PATCH v7 0/1] " Leo Izen
2022-05-28 13:30 ` [FFmpeg-devel] [PATCH v7 1/1] " Leo Izen
2022-05-31 14:26 ` Ronald S. Bultje [this message]
2022-06-01 18:31 ` Ronald S. Bultje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEEMt2moLvJwQpvL5GCta=EvN2HihWccZCtdcDKhMRXY++Q0BA@mail.gmail.com' \
--to=rsbultje@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=leo.izen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git