Re: [FFmpeg-devel] [PATCH v2 4/4] vvcdec: reuse h26x/h2656_deblock_template.c

From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 4/4] vvcdec: reuse h26x/h2656_deblock_template.c
Date: Mon, 8 Jan 2024 20:22:39 -0500
Message-ID: <CAEEMt2m_hDAwUuCwkWoGTkzSfkzuL2FX8PKJfTW=k+nMdEzMqw@mail.gmail.com> (raw)
In-Reply-To: <CAFXK13d9sXtDoPHCBbsyfgcBOfEwLRL5rbz+-KBZ_VuRyt2TZQ@mail.gmail.com>

Hi,

On Mon, Jan 8, 2024 at 8:03 PM Nuo Mi <nuomi2021@gmail.com> wrote:

> On Sat, Jan 6, 2024 at 6:52 PM Nuo Mi <nuomi2021@gmail.com> wrote:
>
> > ---
> >  libavcodec/vvc/vvc_filter_template.c | 82 +---------------------------
> >  1 file changed, 3 insertions(+), 79 deletions(-)
> >
> > diff --git a/libavcodec/vvc/vvc_filter_template.c
> > b/libavcodec/vvc/vvc_filter_template.c
> > index 9418980c33..671ed7de4e 100644
> > --- a/libavcodec/vvc/vvc_filter_template.c
> > +++ b/libavcodec/vvc/vvc_filter_template.c
> > @@ -461,6 +461,8 @@ static void FUNC(alf_recon_coeff_and_clip)(int16_t
> > *coeff, int16_t *clip,
> >  #define FQ2 pix[2  * xstride + 1 * ystride]
> >  #define FQ3 pix[3  * xstride + 1 * ystride]
> >
> > +#include "libavcodec/h26x/h2656_deblock_template.c"
> >
> Will merge this in two days if there are no objections to the file and
> directory names.
>

Are there options to share the actual generated binary code? The C code
admittedly is not so important, but it would be great if there was some way
to ensure that optimizations written for HEVC in some instruction set, work
for VVC also - or vice versa.

Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".