From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C2443411BD for ; Wed, 16 Nov 2022 13:23:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 322C968BD32; Wed, 16 Nov 2022 15:23:18 +0200 (EET) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 737AD68BC58 for ; Wed, 16 Nov 2022 15:23:11 +0200 (EET) Received: by mail-ej1-f43.google.com with SMTP id kt23so44043214ejc.7 for ; Wed, 16 Nov 2022 05:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Jur59DlRnEPQYkh2ZYZVLFMEb7Aa/JUcbiFXb+bADZ8=; b=GxugLDtdYkf5VkHNOK+ldbF8B2KqrsVH2EenX+HppYXI7+MjULbM4LGgugLpVLcbeJ VN8fFvCnz511j5i1S69gwmDvnDxLm/8EkTRGzBmIfXQ21/EYCsHGouc4a/aK04UjGg23 +oGr1w612iYf1DfB+G8ifsaiGGpJVdJfhaCV5Rl7vtei5V/p82+t7SvRYtUFVUrXZQkQ Gf3SyfFsoOF3R1Xqt7vqjld0i2WSMu1joo+vwKLLdRR2r6CMELzgzio9Aia6sdgE0fMS iJ3hEVCy8+51hYiwKNK3WjV2dL0MglP5p/Y80+vsyJM3eVnO8a8L89wzEJXgnJHKzh6E DcnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jur59DlRnEPQYkh2ZYZVLFMEb7Aa/JUcbiFXb+bADZ8=; b=8IbwqE9QabFkA9YTnF48/oA6nm0uayVt92worGdHqLWmgJERLze1tMK/0SfB9r6/er 7VJNZYpMNMYyWieevTmnQUk1vWR+dDYD0JeteZXt/ckeiIPPUThSALrEVekbj+qmYlj1 1v0HSjJQIKcIkQkgUZF23pJHj0fK6aWEZvG6EtiaWr6K8LnISvd98GEx5toBds789AWM DgAX0pm53+ii64v5CbtavCCnzD077h7cNrVPOLxPEtB8lvdjfWkVJ6Aca72EAEsZPlX1 5Fa/oSSlXx4wy4kTOLcE8j34bj2gYqnlc5OCROMNWmlL87+GOVOk5mvpkGaGc4CgnslV Z6HA== X-Gm-Message-State: ANoB5pnUwH00h6xia0GlB3GWDFOg3jtop6/4xAPgo6N83xV1co0t4/yh NvE5yti1rAGBmHMb+nw0B6wQy2Wwrwq9D2bIRSK6PGrN X-Google-Smtp-Source: AA0mqf70zXOCBkjTf9CGMizm9bqKYqJ2bDHbQomg0JlFV+brKUtpFY52sXF1uqI4uozJISiIYI9uFP2XHdJvD7mL+54= X-Received: by 2002:a17:906:7c8d:b0:7af:1233:948d with SMTP id w13-20020a1709067c8d00b007af1233948dmr8311590ejo.698.1668604990432; Wed, 16 Nov 2022 05:23:10 -0800 (PST) MIME-Version: 1.0 References: <20221116084412.2537585-1-hiroh@chromium.org> In-Reply-To: From: "Ronald S. Bultje" Date: Wed, 16 Nov 2022 08:22:59 -0500 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Fix wrong vpx_rac_is_end() check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Hirokazu Honda Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Wed, Nov 16, 2022 at 8:20 AM Ronald S. Bultje wrote: > On Wed, Nov 16, 2022 at 3:44 AM Hirokazu Honda wrote: > >> @@ -2471,7 +2472,7 @@ static av_always_inline int >> decode_mb_row_no_filter(AVCodecContext *avctx, void >> prefetch_motion(s, mb, mb_x, mb_y, mb_xy, VP8_FRAME_PREVIOUS); >> >> if (!mb->skip) >> - decode_mb_coeffs(s, td, c, mb, s->top_nnz[mb_x], >> td->left_nnz, is_vp7); >> + decode_mb_coeffs(s, td, coeff_c, mb, s->top_nnz[mb_x], >> td->left_nnz, is_vp7); >> >> if (mb->mode <= MODE_I4x4) >> intra_predict(s, td, dst, mb, mb_x, mb_y, is_vp7); >> -- >> 2.38.1.431.g37b22c650d-goog >> > > Thanks for the fix. So, you're transferring the truncation check from the > per-slice coef buffer to the "main" mode/mv buffer. Shouldn't we check > both? Or is one of them allowed to be truncated? (That seems unlikely, but > that appears to be what you're suggesting here, otherwise there wouldn't be > any artifacts.) > To clarify: I think a vpx_rac_is_end(coeff_c) in the "if (!mb->skip)" branch here would be helpful, I think. Outside, we don't use coeff_c, so no truncation check is needed. Assuming that still fixes the issue, then. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".