From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Henrik Gramner <henrik@gramner.com>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc: fix luma 12b overflow
Date: Sun, 25 Feb 2024 18:00:10 -0500
Message-ID: <CAEEMt2mFiFPxXURcjGbS8RtJe0=p9GQvEk-vkj+phnXpnBTu2g@mail.gmail.com> (raw)
In-Reply-To: <CAFGUN0p=gTb5_L6+gOAN8i9OOeiFsq9mhVL-VQzWhrZX21tPhw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
Hi,
On Sun, Feb 25, 2024 at 5:30 PM Henrik Gramner via ffmpeg-devel <
ffmpeg-devel@ffmpeg.org> wrote:
> On Sun, Feb 25, 2024 at 5:42 PM Ronald S. Bultje <rsbultje@gmail.com>
> wrote:
> > + mova m13, [pw_8]
> > + paddw m10, m12, m12
> > + paddw m12, m10 ; 9 * (q0 - p0) - 3 * ( q1 - p1 )
> > paddw m12, m13; + 8
>
> Memory operand
>
> > + paddw m10, m13, m13
> > + paddw m13, m10 ; abs(9 * (q0 - p0) - 3 * ( q1 - p1 ))
> > + paddw m13, [pw_8]
> [...]
> > + paddw m13, m12, m12
> > + paddw m13, m12 ; 3*abs(m12)
> > + paddw m13, [pw_8]
>
> Another minor improvement would be to reorder the adds like (x + x) +
> (x + 8) instead of ((x + x) + x) + 8 to allow for more
> instruction-level parallelism.
>
New version attached.
Ronald
[-- Attachment #2: 0001-hevc-x86-deblock-fix-12bit-overflow.patch --]
[-- Type: application/octet-stream, Size: 2299 bytes --]
[-- Attachment #3: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-25 23:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 8:27 J. Dekker
2024-02-25 15:56 ` Ronald S. Bultje
2024-02-25 16:22 ` Ronald S. Bultje
2024-02-25 16:24 ` Ronald S. Bultje
2024-02-25 16:28 ` James Almer
2024-02-25 16:41 ` Ronald S. Bultje
2024-02-25 22:30 ` Henrik Gramner via ffmpeg-devel
2024-02-25 23:00 ` Ronald S. Bultje [this message]
2024-02-26 14:26 ` J. Dekker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEEMt2mFiFPxXURcjGbS8RtJe0=p9GQvEk-vkj+phnXpnBTu2g@mail.gmail.com' \
--to=rsbultje@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=henrik@gramner.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git