From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Dawid Kozinski <d.kozinski@samsung.com>, d.frankiewic@samsung.com
Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code
Date: Mon, 2 Oct 2023 09:49:24 -0400
Message-ID: <CAEEMt2mCoFLrsm2fzWBe0Yh7gozjcYnZ7L8B56BxcBTAOZUTZA@mail.gmail.com> (raw)
In-Reply-To: <20230929083213.1254-1-d.kozinski@samsung.com>
Hi,
On Fri, Sep 29, 2023 at 4:32 AM Dawid Kozinski <d.kozinski@samsung.com>
wrote:
> Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> ---
> libavcodec/hevcpred_template.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/libavcodec/hevcpred_template.c
> b/libavcodec/hevcpred_template.c
> index 16d1c7f35f..46bd806523 100644
> --- a/libavcodec/hevcpred_template.c
> +++ b/libavcodec/hevcpred_template.c
> @@ -213,13 +213,10 @@ do { \
> j = 0;
> while (j < size_max_x && !IS_INTRA(j, -1))
> j++;
> - if (j > 0)
> - if (cand_up_left) {
> - EXTEND_LEFT_CIP(top, j, j + 1);
> - } else {
> - EXTEND_LEFT_CIP(top, j, j);
> - top[-1] = top[0];
> - }
> + if (j > 0) {
> + EXTEND_LEFT_CIP(top, j, j);
> + top[-1] = top[0];
> + }
> left[-1] = top[-1];
> }
> left[-1] = top[-1];
> --
> 2.25.1
>
LGTM.
Can you merge yourself, or do you need me to merge for you?
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-02 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230929083224eucas1p2b7359a39687cb97fd1d51f6583371e77@eucas1p2.samsung.com>
2023-09-29 8:32 ` Dawid Kozinski
2023-10-02 13:49 ` Ronald S. Bultje [this message]
2023-10-03 8:15 ` Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics
2023-10-03 12:45 ` Ronald S. Bultje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEEMt2mCoFLrsm2fzWBe0Yh7gozjcYnZ7L8B56BxcBTAOZUTZA@mail.gmail.com \
--to=rsbultje@gmail.com \
--cc=d.frankiewic@samsung.com \
--cc=d.kozinski@samsung.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git