From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8AFD4430B0 for ; Fri, 20 May 2022 13:39:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4E7DE68B48E; Fri, 20 May 2022 16:39:57 +0300 (EEST) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 368FC68B321 for ; Fri, 20 May 2022 16:39:51 +0300 (EEST) Received: by mail-ej1-f47.google.com with SMTP id kq17so15708005ejb.4 for ; Fri, 20 May 2022 06:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=/rg7u2ukP6TpBFuLlUdZ8uQjh8YWyuMxsR7hIEgaVMc=; b=jxVYgkiEh/aA3mXu/SL+ze2hDQU1zuCg4c991npk5kpwnGurMybWWM3KZkNEBisYav ifA12GpQNfUQ5cDa2Ls7/YGoR5cDllLbHrFBUmQktO1he+rK/P99AFyr/hZwzu2rbaRW 2wVmWHytH9/y257w/ySolUVQ2q3vHIFopaoU/db1qaC+cQPjStgMAPV85dTzsx3NOMe/ U2/lAQYhI2cIgn5TCiS9MJyX2MllhBiDIYENDdWKTOglN+2FyvoD0CVgo0laf0mK+dT7 /MzHVQWkFoP+5Ceh4b1NoMEUs3xjqRYCtN0sDG+eHf9Y65B2JczVZdac/UjqklyuSPhr WjbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=/rg7u2ukP6TpBFuLlUdZ8uQjh8YWyuMxsR7hIEgaVMc=; b=HQ7msmq+V+1Jqhahu6dSQI7qyJMHfXVpjk69q0l6xuvKhk8zrrDC2EOaxiNi2QsviE MVaDWh9JLwle4nNVStP3Sy9vgbNblR1vJFTmJ2DM9B/TCIftdGSlCPbRwIqrtc0O7nwb 6XneJLeRomuKMEbDvgtmho70OI1W1hCo7vRyw88o8mvc20sfOlQ5N7ssBkRxyQVDmKfI BRfLjBfc8d5jJlmMHuqwYVh/Z/WsWoLduKwXI+20Cv7fgy19AD5E8RQqia6zfbr3LjSn TFfhsOHePVrbIjmfdOU5TVREN+SHZQf4h8FYOaHEOu/av9gL6D/zASJJCQfDWRRCTnTp owSA== X-Gm-Message-State: AOAM530bs59F2M4bZ2eWhY8UWIDTFTEfOMNg+sZc5CvXHzvTlfqg1P6F tK1SWm/o68f67pEFCi7VCfIBqf5HGj6CUgmOGP31vMzh X-Google-Smtp-Source: ABdhPJzW0wTttIgj3i153PUW7EEvrb0TAX4zQhc8vuYYicu6SnrqxQwtyV2myH/kPhb/j9dbZJMriELD6lfxM8hxVm4= X-Received: by 2002:a17:907:2d1e:b0:6fe:b48a:cdb9 with SMTP id gs30-20020a1709072d1e00b006feb48acdb9mr1693044ejc.686.1653053990155; Fri, 20 May 2022 06:39:50 -0700 (PDT) MIME-Version: 1.0 References: <20220518151817.21270-1-leo.izen@gmail.com> <20220518182338.GR396728@pb2> <20220518182748.GS396728@pb2> <20220520102815.GT396728@pb2> <20220520131143.GU396728@pb2> In-Reply-To: <20220520131143.GU396728@pb2> From: "Ronald S. Bultje" Date: Fri, 20 May 2022 09:39:37 -0400 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Fri, May 20, 2022 at 9:11 AM Michael Niedermayer wrote: > On Fri, May 20, 2022 at 07:26:56AM -0400, Ronald S. Bultje wrote: > > On Fri, May 20, 2022 at 6:28 AM Michael Niedermayer < > michael@niedermayer.cc> > > > 1. exactly representing values > > > > This isn't actually what I meant when I made the argument. If the spec > says > > "0.137", I'd expect to be able to git grep the source code for "0.137" > and > > find where it's defined. This is lost with AVRational, where it becomes { > > 137, 1000 }. This may sound silly, but I find this helpful. > > > > One way to address this is to add the exact value in a comment, like > > "(AVRational) { 137, 1000 }, // 0.137". This isn't pretty but retains > > grep-discoverability. > > We use fixed point numbers in multiple places without > loosing grep-discoverability > for example > [..] > the advantage over a comment is that a comment can be forgotten > the argument for a macro cannot be forgotten and still succeed build > That sounds reasonable, I'm OK with this approach. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".