From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/vp9: set update_map to 0 when segmentation.enabled is 0
Date: Wed, 22 May 2024 13:33:35 -0400
Message-ID: <CAEEMt2kwNSDetGz92ik5j4tbr=-m3axoT4SUoC2FUiYdO0rVjw@mail.gmail.com> (raw)
In-Reply-To: <CA+anqdznv0kkC8h1fwpMdDy19KTze3B_dP5iuWerUJPmYa9RwA@mail.gmail.com>
Hi,
On Wed, May 22, 2024 at 1:28 PM Hendrik Leppkes <h.leppkes@gmail.com> wrote:
> On Wed, May 22, 2024 at 7:16 PM Lynne via ffmpeg-devel
> <ffmpeg-devel@ffmpeg.org> wrote:
> > I'd hate to apply fixes with no information in shared code. This can get
> > removed with no information about what relies on it.
>
> Changing 5 different hwaccel modules to avoid one line here seems
> rather silly, doesn't it?
> We can add a comment, if that helps.
>
Comment is a good idea, I think Lynne is right there's a risk we
accidentally remove it.
Generally, I'd like to see more hwaccel fate coverage, e.g. a vaapi (or
whatever) fate machine that runs relevant tests using hw decoder instead of
sw decoder. That would protect against the same risk.
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-05-22 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 5:58 llyyr
2024-05-22 14:36 ` Hendrik Leppkes
2024-05-22 15:10 ` Ronald S. Bultje
2024-05-22 16:17 ` Philip Langdale via ffmpeg-devel
2024-05-22 17:16 ` Lynne via ffmpeg-devel
2024-05-22 17:28 ` Hendrik Leppkes
2024-05-22 17:33 ` Ronald S. Bultje [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEEMt2kwNSDetGz92ik5j4tbr=-m3axoT4SUoC2FUiYdO0rVjw@mail.gmail.com' \
--to=rsbultje@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git