From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: "Martin Storsjö" <martin@martin.st>, "Alan Kelly" <alankelly@google.com>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] checkasm: sw_scale: Reduce range of test data in the yuv2yuvX test to get closer to real data
Date: Wed, 17 Aug 2022 16:49:36 -0400
Message-ID: <CAEEMt2kgj6OZ1kr3Kuqq3MV==La0uLfo7k=MOEOP1oCAvnhqRg@mail.gmail.com> (raw)
In-Reply-To: <20220817203147.1957322-2-martin@martin.st>
Hi,
On Wed, Aug 17, 2022 at 4:32 PM Martin Storsjö <martin@martin.st> wrote:
> This avoids overflows on some inputs in the x86 case, where the
> assembly version would clip/overflow differently from the
> C reference function.
>
> This doesn't seem to be a real issue with actual input data, but
> only with the previous fully random input data.
>
I'm a bit scared of this change... If we can trigger overflows with
specific pixel patterns, doesn't that make FFmpeg input-data exploitable?
Think of how that would go with corporate users with user-provided input
data.
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-17 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 20:31 [FFmpeg-devel] [PATCH 1/2] checkasm: sw_scale: Fix the difference printing for approximate functions Martin Storsjö
2022-08-17 20:31 ` [FFmpeg-devel] [PATCH 2/2] checkasm: sw_scale: Reduce range of test data in the yuv2yuvX test to get closer to real data Martin Storsjö
2022-08-17 20:49 ` Ronald S. Bultje [this message]
2022-08-18 7:22 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEEMt2kgj6OZ1kr3Kuqq3MV==La0uLfo7k=MOEOP1oCAvnhqRg@mail.gmail.com' \
--to=rsbultje@gmail.com \
--cc=alankelly@google.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=martin@martin.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git