From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ADD92499D4 for ; Sun, 25 Feb 2024 16:24:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A3C3868C69F; Sun, 25 Feb 2024 18:24:45 +0200 (EET) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 70E7268BCA7 for ; Sun, 25 Feb 2024 18:24:39 +0200 (EET) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2d244b28b95so24191201fa.0 for ; Sun, 25 Feb 2024 08:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708878278; x=1709483078; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=WsRDYmyVGaAkkDOI3raRVipk1KFtic4rPIoSL++6VcQ=; b=D0XQLLcNYXGW5QuWLkXi9/xdFszTDe4JS9VDkNIBf//tstU74lLDByBoCyRLUyxo9z rpc+a9dZXHZxF7VwdMjDixPPGE3/w2mN+UKly+cKFK2IlP5Eqm5cSNVOTmb2JC9QZ3aQ MVXslIX+WCx7I1Cums6pNmF78A0GjZ9BTuwBdDQSwwa+w/9rQo7fBfgKWTy03XqGP15L AD96eu1MIEtGwCxaCNityc2c5bB+0RA5MCL7SLSW/SjnReokAivEadf0OwiydMsk13FC FTcTXRzkL8L5Z90BwyDYpuoZKGKvSZYutFVTqGY1pk9wxyNeiqDgrKEbVrASR/5iTumW Iw7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708878278; x=1709483078; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WsRDYmyVGaAkkDOI3raRVipk1KFtic4rPIoSL++6VcQ=; b=KUDFJbjzKrVeIjrc8Pd989S98xNZjbzYL04jRVZ0xdEsdLdOAV5E4Nac3ESG4WKPdE b0qnzaZcuBTV+qCiDW4lUfpZ5C3QbdwFPa15SkBRTf6+H3FGXQgRWCsDdK2Hp5DopbVC txKmXUbOPb6llbhyZiD4rRTu6uqjSjUmamdm9ltWaDiYxYUj2pFx5SEklDstBYY2rGjK zMWFoNu7vET4onigYSQfmVTl46wzdMqT6+Mmd8eB0jaNXdh9IgF9fEVewaY+qCeb/jgX urIxSl4raFqbsOW8y+LkzTe7Cwn8DhFAdot8oIgoOcTvCSTprtyXaEvpFAnB6xBcVGIU Y5vg== X-Gm-Message-State: AOJu0YxYixd+nBaK9nO6yO9q4aH4Oh/wFNdS08RlyGIbOouHET379o7w 3sAUPFwlOZIdz+ihbI4NvhnTJlTL41arocYEUxr+L4LFhfA7Bki73CFbEi1wVfbV7L9BJrmCYhp ESW6zUiTyL8r8xeaeBFnVmotGEFxNSPxt X-Google-Smtp-Source: AGHT+IEdMBd516bCtKdpul/k60AsRmelYWIgIsp1gVrzRz94rICKQcfQo4xUDQ7hSbNsy1FZZTeVTEyVCrfZYy2VNn0= X-Received: by 2002:a2e:910f:0:b0:2d2:4def:a7bd with SMTP id m15-20020a2e910f000000b002d24defa7bdmr2546186ljg.24.1708878278222; Sun, 25 Feb 2024 08:24:38 -0800 (PST) MIME-Version: 1.0 References: <20240225082755.355295-1-jdek@itanimul.li> In-Reply-To: From: "Ronald S. Bultje" Date: Sun, 25 Feb 2024 11:24:26 -0500 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="000000000000bcfefb0612373a85" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc: fix luma 12b overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --000000000000bcfefb0612373a85 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Sun, Feb 25, 2024 at 11:22=E2=80=AFAM Ronald S. Bultje wrote: > > > On Sun, Feb 25, 2024 at 10:56=E2=80=AFAM Ronald S. Bultje > wrote: > >> Hi, >> >> On Sun, Feb 25, 2024 at 3:28=E2=80=AFAM J. Dekker wro= te: >> >>> Weak filter can overflow in delta0 calculation before >> 4 in int16. >>> >>> Signed-off-by: J. Dekker >>> --- >>> >>> I do not know x86 simd at all, so this is just an attempt to fix >>> the implementation rather than write extremely performant code. >>> >>> Suggestions welcome. >>> >> >> https://pastebin.com/KvcbQ2nK >> > > Attached a slightly adjusted version which does sse2 in 16bit also. > And now without typos and whitespace changes. Ronald --000000000000bcfefb0612373a85 Content-Type: application/octet-stream; name="0001-hevc-x86-deblock-fix-12bit-overflow.patch" Content-Disposition: attachment; filename="0001-hevc-x86-deblock-fix-12bit-overflow.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lt1pzvwy0 RnJvbSA2MDM4OTliNWUzMTMyYjQxYWExZTUyMmE2MTAyN2U2MjY1MmY3NGE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUm9uYWxkIFMuIEJ1bHRqZSIgPHJzYnVsdGplQGdtYWlsLmNv bT4KRGF0ZTogU3VuLCAyNSBGZWIgMjAyNCAxMDo0OTozNSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hd IGhldmMveDg2L2RlYmxvY2s6IGZpeCAxMmJpdCBvdmVyZmxvdy4KCi0tLQogbGliYXZjb2RlYy94 ODYvaGV2Y19kZWJsb2NrLmFzbSB8IDQwICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LQogMSBmaWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGliYXZjb2RlYy94ODYvaGV2Y19kZWJsb2NrLmFzbSBiL2xpYmF2Y29kZWMveDg2 L2hldmNfZGVibG9jay5hc20KaW5kZXggODVlZTQ4MDBiYi4uODY5MzAxY2FmZiAxMDA2NDQKLS0t IGEvbGliYXZjb2RlYy94ODYvaGV2Y19kZWJsb2NrLmFzbQorKysgYi9saWJhdmNvZGVjL3g4Ni9o ZXZjX2RlYmxvY2suYXNtCkBAIC0zMSw2ICszMSw3IEBAIGNleHRlcm4gcHdfMTAyMwogcHdfcGl4 ZWxfbWF4XzEyOiB0aW1lcyA4IGR3ICgoMSA8PCAxMiktMSkKIHB3X20yOiAgICAgICAgICAgdGlt ZXMgOCBkdyAtMgogcGRfMSA6ICAgICAgICAgICB0aW1lcyA0IGRkICAxCitwZF84IDogICAgICAg ICAgIHRpbWVzIDggZGQgIDgKIAogY2V4dGVybiBwd180CiBjZXh0ZXJuIHB3XzgKQEAgLTU0MSwx OSArNTQyLDQyIEBAIEFMSUdOIDE2CiAgICAgYWRkICAgICAgICAgICAgIGJldGFxLCByMTMKICAg ICBzaHIgICAgICAgICAgICAgYmV0YXEsIDM7ICgoYmV0YSArIChiZXRhID4+IDEpKSA+PiAzKSkK IAotICAgIG1vdmEgICAgICAgICAgICBtMTMsIFtwd184XQogICAgIHBzdWJ3ICAgICAgICAgICBt MTIsIG00LCBtMyA7IHEwIC0gcDAKLSAgICBwc2xsdyAgICAgICAgICAgbTEwLCBtMTIsIDM7IDgg KiAocTAgLSBwMCkKLSAgICBwYWRkdyAgICAgICAgICAgbTEyLCBtMTAgOyA5ICogKHEwIC0gcDAp Ci0KKyAgICBwYWRkdyAgICAgICAgICAgbTEwLCBtMTIsIG0xMgorICAgIHBhZGR3ICAgICAgICAg ICBtMTIsIG0xMCA7IDMgKiAocTAgLSBwMCkKICAgICBwc3VidyAgICAgICAgICAgbTEwLCBtNSwg bTIgOyBxMSAtIHAxCi0gICAgcHNsbHcgICAgICAgICAgICBtOCwgbTEwLCAxOyAyICogKCBxMSAt IHAxICkKLSAgICBwYWRkdyAgICAgICAgICAgbTEwLCBtODsgMyAqICggcTEgLSBwMSApCi0gICAg cHN1YncgICAgICAgICAgIG0xMiwgbTEwOyA5ICogKHEwIC0gcDApIC0gMyAqICggcTEgLSBwMSAp CisgICAgcHN1YncgICAgICAgICAgIG0xMiwgbTEwIDsgMyAqIChxMCAtIHAwKSAtIChxMSAtIHAx KQorJWlmICUxIDwgMTIKKyAgICBtb3ZhICAgICAgICAgICAgbTEzLCBbcHdfOF0KKyAgICBwYWRk dyAgICAgICAgICAgbTEwLCBtMTIsIG0xMgorICAgIHBhZGR3ICAgICAgICAgICBtMTIsIG0xMCA7 IDkgKiAocTAgLSBwMCkgLSAzICogKCBxMSAtIHAxICkKICAgICBwYWRkdyAgICAgICAgICAgbTEy LCBtMTM7ICsgOAogICAgIHBzcmF3ICAgICAgICAgICBtMTIsIDQ7ID4+IDQgLCBkZWx0YTAKICAg ICBQQUJTVyAgICAgICAgICAgbTEzLCBtMTI7IGFicyhkZWx0YTApCi0KKyVlbGlmIGNwdWZsYWco c3NzZTMpCisgICAgcGFic3cgICAgICAgICAgIG0xMywgbTEyCisgICAgcGFkZHcgICAgICAgICAg IG0xMCwgbTEzLCBtMTMKKyAgICBwYWRkdyAgICAgICAgICAgbTEzLCBtMTAgOyBhYnMoOSAqIChx MCAtIHAwKSAtIDMgKiAoIHExIC0gcDEgKSkKKyAgICBwYWRkdyAgICAgICAgICAgbTEzLCBbcHdf OF0KKyAgICBweG9yICAgICAgICAgICAgbTEwLCBtMTAKKyAgICBwY21wZ3R3ICAgICAgICAgbTEw LCBtMTIKKyAgICBwYWRkdyAgICAgICAgICAgbTEzLCBtMTAKKyAgICBwc3JsdyAgICAgICAgICAg bTEzLCA0OyA+PiA0LCBhYnMoZGVsdGEwKQorICAgIHBzaWdudyAgICAgICAgICBtMTAsIG0xMywg bTEyCisgICAgU1dBUCAgICAgICAgICAgICAxMCwgMTIKKyVlbHNlCisgICAgcHhvciAgICAgICAg ICAgIG0xMCwgbTEwCisgICAgcGNtcGd0dyAgICAgICAgIG0xMCwgbTEyCisgICAgcHhvciAgICAg ICAgICAgIG0xMiwgbTEwCisgICAgcHN1YncgICAgICAgICAgIG0xMiwgbTEwIDsgYWJzKCkKKyAg ICBwYWRkdyAgICAgICAgICAgbTEzLCBtMTIsIG0xMgorICAgIHBhZGR3ICAgICAgICAgICBtMTMs IG0xMiA7IDMqYWJzKG0xMikKKyAgICBwYWRkdyAgICAgICAgICAgbTEzLCBbcHdfOF0KKyAgICBw YWRkdyAgICAgICAgICAgbTEzLCBtMTAKKyAgICBwc3JsdyAgICAgICAgICAgbTEzLCA0CisgICAg cHhvciAgICAgICAgICAgIG0xMiwgbTEzLCBtMTAKKyAgICBwc3VidyAgICAgICAgICAgbTEyLCBt MTAKKyVlbmRpZgogCiAgICAgcHNsbHcgICAgICAgICAgIG0xMCwgbTksIDI7IDggKiB0YwogICAg IHBhZGR3ICAgICAgICAgICBtMTAsIG05OyAxMCAqIHRjCi0tIAoyLjQzLjEKCg== --000000000000bcfefb0612373a85 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --000000000000bcfefb0612373a85--