From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B2FE043466 for ; Sun, 11 Sep 2022 14:41:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0772168BAE1; Sun, 11 Sep 2022 17:41:44 +0300 (EEST) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E29268BA4F for ; Sun, 11 Sep 2022 17:41:37 +0300 (EEST) Received: by mail-ej1-f53.google.com with SMTP id v16so14624522ejr.10 for ; Sun, 11 Sep 2022 07:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=Hp9BwAhnXjESwdNE7iRoLmvxklXlLq98uqiKEvmtU08=; b=dBa4d8aWJhUFcn8/2+cfgNn7KfGBqvk6jxqOmKnAI5Su7NOSm9C0vcKgdKRfOBLZqH zn237inSfxlL5krex3wGlUcDpzKXci0Xc9AsL8/Hpuj0xfiX9KP/IECnzFNrKxBLk9Ri zwTN5kP1A0Z3sKBfbYuY/38+ICQb1ga+f+byc9XN0tKUWOhzrsg4h/+G4EFjbwr7JebJ 1yWjPwq8bS8la2FQmtZNn26JMKbYB7GKZiddc2wTDrMzZII84XvXEMVhc3YIzqYKSdMu Y+6cDnxWnLYwjbdo3//ZNOMS7tHWQTqOqVKm4jdvyGoGi0KAWe15QGnZN/0FQYFeGXet z0sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=Hp9BwAhnXjESwdNE7iRoLmvxklXlLq98uqiKEvmtU08=; b=Xp/MrECT8HTEOkHMX3Of94rNnZWHB8BJvSw7GNPZ+uefcIHRd2sZYoKa6c/Nzs6vES JjknSKQB2iH+x44quNV7goxQahjwkSB/iveqEFvcXFDYrX0S6lVXM/9udxGQP9CCa7wx fRrRk2dCVH0DnkRIR4qFV8xc4MZlqJhcqDhUS1Z0UFOZWeDdWqWTN2G/CfzLLKW3XPwm WEphF0xnS7UdrnaL5BN/7S0nQkqmTCZ46rSI9xM2Cut1x4dWZPNAGPzGFOHbzt4/9cfs kWKoQUVUDYc8b3Q5TyHr3lCQ270uWudiCGxuE/7bAvNQB3sxEBFgJ/wf4Dhfd7KTOnWi nKlA== X-Gm-Message-State: ACgBeo0prDRokJWI1fiRSEP80osVi+YeA0UvfOWDoLp6huJryplI6ZTW WtPhNcDBzP0jrrn7HKbRaldl6afrTpziL+3xvqzUlR8w X-Google-Smtp-Source: AA6agR6CXFAUgImd+LDfEwE1PcW1gD97ty0msTIwT/WVejxNpSWkWnkgcf+huTHPHKulqEucMlqWHhNfbeHZeBwP7lY= X-Received: by 2002:a17:906:58cc:b0:74f:f27a:e8a6 with SMTP id e12-20020a17090658cc00b0074ff27ae8a6mr16647259ejs.18.1662907296523; Sun, 11 Sep 2022 07:41:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Ronald S. Bultje" Date: Sun, 11 Sep 2022 10:41:24 -0400 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Sun, Sep 11, 2022 at 12:38 AM Andreas Rheinhardt < andreas.rheinhardt@outlook.com> wrote: > Peter Ross: > > On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: > >> It is a VP8-only feature. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/vp8.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c > >> index c00c5c975e..04a2113cc8 100644 > >> --- a/libavcodec/vp8.c > >> +++ b/libavcodec/vp8.c > >> @@ -637,7 +637,6 @@ static int vp7_decode_frame_header(VP8Context *s, > const uint8_t *buf, int buf_si > >> for (i = 0; i < 2; i++) > >> memcpy(s->prob->mvc[i], vp7_mv_default_prob[i], > >> sizeof(vp7_mv_default_prob[i])); > >> - memset(&s->lf_delta, 0, sizeof(s->lf_delta)); > >> memcpy(s->prob[0].scan, ff_zigzag_scan, > sizeof(s->prob[0].scan)); > >> } > >> > >> @@ -2171,7 +2170,7 @@ void filter_level_for_mb(VP8Context *s, > VP8Macroblock *mb, > >> } else > >> filter_level = s->filter.level; > >> > >> - if (s->lf_delta.enabled) { > >> + if (!is_vp7 && s->lf_delta.enabled) { > >> filter_level += s->lf_delta.ref[mb->ref_frame]; > >> filter_level += s->lf_delta.mode[mb->mode]; > >> } > > > > what's the motivation for patches 01 and 02? > > are you not just adding another condition (is_vp7) to evaluate at decode > time? > > if its improved readability, then suggest renaming 'lf_delta' to > 'lf_delta_vp8' > > > > pathces 3-18 look fine to me. > > > > is_vp7 is evaluated at compile-time > This should probably be changed to be uppercase then. Lowercase suggests it's a variable. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".