From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Stone Chen <chen.stonechen@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v3 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC
Date: Sat, 18 May 2024 11:33:14 -0400
Message-ID: <CAEEMt2k4qZor9eRo1BeZxdpCDE2V9oGaHniNtrp3zFW6anXbuQ@mail.gmail.com> (raw)
In-Reply-To: <20240514204019.11022-2-chen.stonechen@gmail.com>
Hi,
On Tue, May 14, 2024 at 4:40 PM Stone Chen <chen.stonechen@gmail.com> wrote:
> + vvc_sad_8:
> + .loop_height:
> + movu xm0, [src1q]
> + movu xm1, [src2q]
> + MIN_MAX_SAD xm2, xm0, xm1
> + vpmovzxwd m1, xm1
> + vpaddd m3, m1
>
[..]
> + vvc_sad_16_128:
> + .loop_height:
>
[..]
> + .loop_width:
> + movu xm0, [src1q]
> + movu xm1, [src2q]
> + MIN_MAX_SAD xm2, xm0, xm1
> + vpmovzxwd m1, xm1
> + vpaddd m3, m1
>
Wouldn't it be more efficient if the main loops did a full register worth
at a time?
vpbroadcastd m4, [pw_1]
loop:
movu m0, [src1q]
movu m1, [src2q]
MIN_MAX_SAD m2, m0, m1
pmaddwd m1, m4
paddd m3, m1
(And then for w8, load 2 rows per iteration using movu xmN, [row0] and
vinserti128 mN, [row1], 1.)
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-18 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 20:40 Stone Chen
2024-05-14 20:40 ` [FFmpeg-devel] [PATCH v3 2/2][GSoC 2024] tests/checkasm: Add check_vvc_sad to vvc_mc.c Stone Chen
2024-05-18 10:50 ` [FFmpeg-devel] 回复: [PATCH v3 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC Wu Jianhua
2024-05-18 13:04 ` [FFmpeg-devel] " Ronald S. Bultje
2024-05-18 13:12 ` Stone Chen
2024-05-18 15:33 ` Ronald S. Bultje [this message]
2024-05-19 14:24 ` Stone Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEEMt2k4qZor9eRo1BeZxdpCDE2V9oGaHniNtrp3zFW6anXbuQ@mail.gmail.com \
--to=rsbultje@gmail.com \
--cc=chen.stonechen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git