Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code

From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: d.frankiewic@samsung.com
Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed unreachable code
Date: Tue, 3 Oct 2023 08:45:37 -0400
Message-ID: <CAEEMt2=wah3=Uror5gykcSa7FBwJFOvub70wzmYT20fGaPr7mw@mail.gmail.com> (raw)
In-Reply-To: <00e701d9f5d1$c0b68f60$4223ae20$@samsung.com>

Hi,

On Tue, Oct 3, 2023 at 4:15 AM Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff
Engineer/Samsung Electronics <d.kozinski@samsung.com> wrote:

>
>
>
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ronald
> > S. Bultje
> > Sent: poniedziałek, 2 października 2023 15:49
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Cc: Dawid Kozinski <d.kozinski@samsung.com>; d.frankiewic@samsung.com
> > Subject: Re: [FFmpeg-devel] [PATCH v1] avcodec/hevcpred_template: Removed
> > unreachable code
> >
> > Hi,
> >
> > On Fri, Sep 29, 2023 at 4:32 AM Dawid Kozinski <d.kozinski@samsung.com>
> > wrote:
> >
> > > Signed-off-by: Dawid Kozinski <d.kozinski@samsung.com>
> > > ---
> > >  libavcodec/hevcpred_template.c | 11 ++++-------
> > >  1 file changed, 4 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/libavcodec/hevcpred_template.c
> > > b/libavcodec/hevcpred_template.c index 16d1c7f35f..46bd806523 100644
> > > --- a/libavcodec/hevcpred_template.c
> > > +++ b/libavcodec/hevcpred_template.c
> > > @@ -213,13 +213,10 @@ do {                                  \
> > >                  j = 0;
> > >                  while (j < size_max_x && !IS_INTRA(j, -1))
> > >                      j++;
> > > -                if (j > 0)
> > > -                    if (cand_up_left) {
> > > -                        EXTEND_LEFT_CIP(top, j, j + 1);
> > > -                    } else {
> > > -                        EXTEND_LEFT_CIP(top, j, j);
> > > -                        top[-1] = top[0];
> > > -                    }
> > > +                if (j > 0) {
> > > +                    EXTEND_LEFT_CIP(top, j, j);
> > > +                    top[-1] = top[0];
> > > +                }
> > >                  left[-1] = top[-1];
> > >              }
> > >              left[-1] = top[-1];
> > > --
> > > 2.25.1
> > >
> >
> > LGTM.
> >
> > Can you merge yourself, or do you need me to merge for you?
>
> Thank you for review.
> If you can, merge it, please.
>

Done.

Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".