From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream
Date: Wed, 8 Nov 2023 10:55:57 -0500
Message-ID: <CAEEMt2=rWDU6TZumq1N_aUgNJsn=f4t=y+QO3o05VCYzA5qBkg@mail.gmail.com> (raw)
In-Reply-To: <DM6PR11MB268149AD323CBAF77A02F295B1A8A@DM6PR11MB2681.namprd11.prod.outlook.com>
Hi Jianhui,
On Tue, Nov 7, 2023 at 8:52 PM Dai, Jianhui J <
jianhui.j.dai-at-intel.com@ffmpeg.org> wrote:
> The smaller delta patch to export the variable:
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/DM6PR11MB268186349E600824E1577DFDB1A8A@DM6PR11MB2681.namprd11.prod.outlook.com/
> Personally, I prefer to limit the static data only in vp8.c.
>
Understood. It's going to be a dice-roll either way, and since I'm the
maintainer, I get to pick :-). I prefer continuing with what we have in
this version, but I'll leave it open for the majority opinion to overrule
me for a few days before we merge this.
Do you need me to merge or do you have commit access?
If you adapt the cbs patch to use this (newly) exported table, I have no
further review comments.
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-08 16:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 0:56 Dai, Jianhui J
2023-11-06 2:47 ` Ronald S. Bultje
2023-11-06 4:13 ` Dai, Jianhui J
2023-11-06 12:07 ` Ronald S. Bultje
2023-11-06 12:08 ` Ronald S. Bultje
2023-11-07 5:00 ` Dai, Jianhui J
2023-11-07 20:25 ` Ronald S. Bultje
2023-11-08 1:51 ` Dai, Jianhui J
2023-11-08 15:55 ` Ronald S. Bultje [this message]
2023-11-08 16:37 ` Ronald S. Bultje
2023-11-09 3:23 ` Dai, Jianhui J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEEMt2=rWDU6TZumq1N_aUgNJsn=f4t=y+QO3o05VCYzA5qBkg@mail.gmail.com' \
--to=rsbultje@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git