From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 67C12499D9 for ; Sun, 25 Feb 2024 16:42:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 433D668C64C; Sun, 25 Feb 2024 18:41:59 +0200 (EET) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C1DA668BDBB for ; Sun, 25 Feb 2024 18:41:52 +0200 (EET) Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2d0cd9871b3so18959101fa.1 for ; Sun, 25 Feb 2024 08:41:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708879311; x=1709484111; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=5e3Au1dGLWwtaqvpvS0JUX1ydf8FwAyGTqGEzuWYfwc=; b=UYa7dh6aGZNvQbCoPicLj00quQS03nFNuIZdGAjM9FVX3smXb6OUbSJGRB4z2YOSF9 n04LfcpY6sbAeSVLUoPvTt32xeWX+9ySnX9vTIAJl8taVissaSDWIXKiUuaMrvlHq0Wh eqqpoe5bBNdlyr9b4PevSLvWwM8ZxKvtGI7nfqK3BQmggjVcpWydLT6Qt79XBO+IVfkS nGjE6EeWjg4gt/6PV4lTyhOAaGvBoSr7wG7BshKX6ACiY5n5ZWF7nuHHGGf1soipIp7T fm/5vL64Wm+/q9frBGrTruk1tvVHdA/IsOldDwMm0Uk8CKQT4KWH/mxDTx0iEnKYKo6r qqog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708879311; x=1709484111; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5e3Au1dGLWwtaqvpvS0JUX1ydf8FwAyGTqGEzuWYfwc=; b=NXnfwZQEcJ5NO+ex0gTw1vdCXEdPmD6T0kfNj0Zx5l5Hfu7SH9eOdEm+PFECFr1wY9 jfoYKeIuJlXaIo8XkLssCyiNLUn0tZnBD1Ii/Ofldrg4+FBSdzf5zr/lMy9kmDbOT92w 6MbFl2t7pEAkFxGb1PUZnuF0XvTTLWeukKtiJN16qX9qXbNjRrKH2e2VjkBukGaZ/W3p EsAtLu6Z/UE32Fr1mKxFgNnxqDBzzC8iKWYZh7qkJkhdFQVnjPmLnmbaxm6qFBIcHbL1 ozueLYvkqkYxy2xIrpx7gjyaIuIT2W2qbBztku9Ro60T4940cwP7xyASe3kFHbwW8+7u 0rQQ== X-Gm-Message-State: AOJu0YxfNh2OYyzSDUghIUNglfjimZB0etSTy1wKhVuLjJpT8NtyrGZC epwv+fe0NMQzbuPy2LrdlCieMel/H8I4V+uPJhqJhxiVxa/sPEHfF3PJlTGGU45cfGMytNqRphN 4SjG/fzIue/l7ciLzYWxDV4nIbIIRqpXd X-Google-Smtp-Source: AGHT+IE7/hZBAvNFVWJCiRii6CtAR7F87KiwUZCIA4vvuMpg0bq1h4gBv3ER8hS+nclGbIyJt7/IqiNcnvXwqGY4uqE= X-Received: by 2002:a2e:712:0:b0:2d2:8051:3248 with SMTP id 18-20020a2e0712000000b002d280513248mr1080542ljh.18.1708879311420; Sun, 25 Feb 2024 08:41:51 -0800 (PST) MIME-Version: 1.0 References: <20240225082755.355295-1-jdek@itanimul.li> In-Reply-To: From: "Ronald S. Bultje" Date: Sun, 25 Feb 2024 11:41:39 -0500 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="000000000000525f3906123778a8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc: fix luma 12b overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --000000000000525f3906123778a8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Sun, Feb 25, 2024 at 11:28=E2=80=AFAM James Almer wr= ote: > On 2/25/2024 1:22 PM, Ronald S. Bultje wrote: > > On Sun, Feb 25, 2024 at 10:56=E2=80=AFAM Ronald S. Bultje > > wrote: > > > >> Hi, > >> > >> On Sun, Feb 25, 2024 at 3:28=E2=80=AFAM J. Dekker w= rote: > >> > >>> Weak filter can overflow in delta0 calculation before >> 4 in int16. > >>> > >>> Signed-off-by: J. Dekker > >>> --- > >>> > >>> I do not know x86 simd at all, so this is just an attempt to fix > >>> the implementation rather than write extremely performant code. > >>> > >>> Suggestions welcome. > >>> > >> > >> https://pastebin.com/KvcbQ2nK > >> > > > > Attached a slightly adjusted version which does sse2 in 16bit also. > > > > Ronald > > > diff --git a/libavcodec/x86/hevc_deblock.asm > b/libavcodec/x86/hevc_deblock.asm > > index 85ee4800bb..869301caff 100644 > > --- a/libavcodec/x86/hevc_deblock.asm > > +++ b/libavcodec/x86/hevc_deblock.asm > > @@ -31,6 +31,7 @@ cextern pw_1023 > > pw_pixel_max_12: times 8 dw ((1 << 12)-1) > > pw_m2: times 8 dw -2 > > pd_1 : times 4 dd 1 > > +pd_8 : times 8 dd 8 > > This is unused. > Fixed. Ronald --000000000000525f3906123778a8 Content-Type: application/octet-stream; name="0001-hevc-x86-deblock-fix-12bit-overflow.patch" Content-Disposition: attachment; filename="0001-hevc-x86-deblock-fix-12bit-overflow.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lt1qm0md0 RnJvbSA0MDE3MmIwMDUzNGRjMWNmNWI0NTAwMjliZTZlZmJlODBjM2U2NmUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiUm9uYWxkIFMuIEJ1bHRqZSIgPHJzYnVsdGplQGdtYWlsLmNv bT4KRGF0ZTogU3VuLCAyNSBGZWIgMjAyNCAxMDo0OTozNSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hd IGhldmMveDg2L2RlYmxvY2s6IGZpeCAxMmJpdCBvdmVyZmxvdy4KCi0tLQogbGliYXZjb2RlYy94 ODYvaGV2Y19kZWJsb2NrLmFzbSB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LQogMSBmaWxlIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvbGliYXZjb2RlYy94ODYvaGV2Y19kZWJsb2NrLmFzbSBiL2xpYmF2Y29kZWMveDg2 L2hldmNfZGVibG9jay5hc20KaW5kZXggODVlZTQ4MDBiYi4uN2I1ZmI1MTU5OCAxMDA2NDQKLS0t IGEvbGliYXZjb2RlYy94ODYvaGV2Y19kZWJsb2NrLmFzbQorKysgYi9saWJhdmNvZGVjL3g4Ni9o ZXZjX2RlYmxvY2suYXNtCkBAIC01NDEsMTkgKzU0MSw0MiBAQCBBTElHTiAxNgogICAgIGFkZCAg ICAgICAgICAgICBiZXRhcSwgcjEzCiAgICAgc2hyICAgICAgICAgICAgIGJldGFxLCAzOyAoKGJl dGEgKyAoYmV0YSA+PiAxKSkgPj4gMykpCiAKLSAgICBtb3ZhICAgICAgICAgICAgbTEzLCBbcHdf OF0KICAgICBwc3VidyAgICAgICAgICAgbTEyLCBtNCwgbTMgOyBxMCAtIHAwCi0gICAgcHNsbHcg ICAgICAgICAgIG0xMCwgbTEyLCAzOyA4ICogKHEwIC0gcDApCi0gICAgcGFkZHcgICAgICAgICAg IG0xMiwgbTEwIDsgOSAqIChxMCAtIHAwKQotCisgICAgcGFkZHcgICAgICAgICAgIG0xMCwgbTEy LCBtMTIKKyAgICBwYWRkdyAgICAgICAgICAgbTEyLCBtMTAgOyAzICogKHEwIC0gcDApCiAgICAg cHN1YncgICAgICAgICAgIG0xMCwgbTUsIG0yIDsgcTEgLSBwMQotICAgIHBzbGx3ICAgICAgICAg ICAgbTgsIG0xMCwgMTsgMiAqICggcTEgLSBwMSApCi0gICAgcGFkZHcgICAgICAgICAgIG0xMCwg bTg7IDMgKiAoIHExIC0gcDEgKQotICAgIHBzdWJ3ICAgICAgICAgICBtMTIsIG0xMDsgOSAqIChx MCAtIHAwKSAtIDMgKiAoIHExIC0gcDEgKQorICAgIHBzdWJ3ICAgICAgICAgICBtMTIsIG0xMCA7 IDMgKiAocTAgLSBwMCkgLSAocTEgLSBwMSkKKyVpZiAlMSA8IDEyCisgICAgbW92YSAgICAgICAg ICAgIG0xMywgW3B3XzhdCisgICAgcGFkZHcgICAgICAgICAgIG0xMCwgbTEyLCBtMTIKKyAgICBw YWRkdyAgICAgICAgICAgbTEyLCBtMTAgOyA5ICogKHEwIC0gcDApIC0gMyAqICggcTEgLSBwMSAp CiAgICAgcGFkZHcgICAgICAgICAgIG0xMiwgbTEzOyArIDgKICAgICBwc3JhdyAgICAgICAgICAg bTEyLCA0OyA+PiA0ICwgZGVsdGEwCiAgICAgUEFCU1cgICAgICAgICAgIG0xMywgbTEyOyBhYnMo ZGVsdGEwKQotCislZWxpZiBjcHVmbGFnKHNzc2UzKQorICAgIHBhYnN3ICAgICAgICAgICBtMTMs IG0xMgorICAgIHBhZGR3ICAgICAgICAgICBtMTAsIG0xMywgbTEzCisgICAgcGFkZHcgICAgICAg ICAgIG0xMywgbTEwIDsgYWJzKDkgKiAocTAgLSBwMCkgLSAzICogKCBxMSAtIHAxICkpCisgICAg cGFkZHcgICAgICAgICAgIG0xMywgW3B3XzhdCisgICAgcHhvciAgICAgICAgICAgIG0xMCwgbTEw CisgICAgcGNtcGd0dyAgICAgICAgIG0xMCwgbTEyCisgICAgcGFkZHcgICAgICAgICAgIG0xMywg bTEwCisgICAgcHNybHcgICAgICAgICAgIG0xMywgNDsgPj4gNCwgYWJzKGRlbHRhMCkKKyAgICBw c2lnbncgICAgICAgICAgbTEwLCBtMTMsIG0xMgorICAgIFNXQVAgICAgICAgICAgICAgMTAsIDEy CislZWxzZQorICAgIHB4b3IgICAgICAgICAgICBtMTAsIG0xMAorICAgIHBjbXBndHcgICAgICAg ICBtMTAsIG0xMgorICAgIHB4b3IgICAgICAgICAgICBtMTIsIG0xMAorICAgIHBzdWJ3ICAgICAg ICAgICBtMTIsIG0xMCA7IGFicygpCisgICAgcGFkZHcgICAgICAgICAgIG0xMywgbTEyLCBtMTIK KyAgICBwYWRkdyAgICAgICAgICAgbTEzLCBtMTIgOyAzKmFicyhtMTIpCisgICAgcGFkZHcgICAg ICAgICAgIG0xMywgW3B3XzhdCisgICAgcGFkZHcgICAgICAgICAgIG0xMywgbTEwCisgICAgcHNy bHcgICAgICAgICAgIG0xMywgNAorICAgIHB4b3IgICAgICAgICAgICBtMTIsIG0xMywgbTEwCisg ICAgcHN1YncgICAgICAgICAgIG0xMiwgbTEwCislZW5kaWYKIAogICAgIHBzbGx3ICAgICAgICAg ICBtMTAsIG05LCAyOyA4ICogdGMKICAgICBwYWRkdyAgICAgICAgICAgbTEwLCBtOTsgMTAgKiB0 YwotLSAKMi40My4xCgo= --000000000000525f3906123778a8 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --000000000000525f3906123778a8--