Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Return error on error

From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Return error on error
Date: Sat, 27 Apr 2024 09:45:15 -0400
Message-ID: <CAEEMt2=JnhR2PBDjKg-N=rCzA_qCoua6DBVO18vSHZO==yKz7g@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB074478E14CD460105F3A0C608F152@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

Hi,

On Sat, Apr 27, 2024 at 7:47 AM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Regression since e1ba00ac8f755f37ebc8448d3dbea906d7b79da2.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavcodec/vp8.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c
> index f37938ad27..19f32b3400 100644
> --- a/libavcodec/vp8.c
> +++ b/libavcodec/vp8.c
> @@ -107,8 +107,11 @@ static int vp8_alloc_frame(VP8Context *s, VP8Frame
> *f, int ref)
>                                             ref ? AV_GET_BUFFER_FLAG_REF :
> 0);
>      if (ret < 0)
>          return ret;
> -    if (!(f->seg_map = ff_refstruct_allocz(s->mb_width * s->mb_height)))
> +    f->seg_map = ff_refstruct_allocz(s->mb_width * s->mb_height);
> +    if (!f->seg_map) {
> +        ret = AVERROR(ENOMEM);
>          goto fail;
> +    }
>      ret = ff_hwaccel_frame_priv_alloc(s->avctx,
> &f->hwaccel_picture_private);
>      if (ret < 0)
>          goto fail;
> --
> 2.40.1
>

OK.

Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".