From: "Ronald S. Bultje" <rsbultje@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc: fix luma 12b overflow
Date: Sun, 25 Feb 2024 10:56:30 -0500
Message-ID: <CAEEMt2=B2TF550nA6QgSFd+Ng7oRizCGxyZ=ugrmo+FiKCoCUw@mail.gmail.com> (raw)
In-Reply-To: <20240225082755.355295-1-jdek@itanimul.li>
Hi,
On Sun, Feb 25, 2024 at 3:28 AM J. Dekker <jdek@itanimul.li> wrote:
> Weak filter can overflow in delta0 calculation before >> 4 in int16.
>
> Signed-off-by: J. Dekker <jdek@itanimul.li>
> ---
>
> I do not know x86 simd at all, so this is just an attempt to fix
> the implementation rather than write extremely performant code.
>
> Suggestions welcome.
>
https://pastebin.com/KvcbQ2nK
Most of this can remain in 16bits when doing pabsw before the add. The odd
thing is that if I break (intentionally) the sse2 version, the ssse3/avx
checkams tests start failing occasionally also. I'm not sure why that is
the case. Not sure how to measure perf impact, I don't think there is any
for the non-12bit case (same number of instructions) but I didn't test very
hard and the perf is not very stable...
Ronald
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-25 15:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 8:27 J. Dekker
2024-02-25 15:56 ` Ronald S. Bultje [this message]
2024-02-25 16:22 ` Ronald S. Bultje
2024-02-25 16:24 ` Ronald S. Bultje
2024-02-25 16:28 ` James Almer
2024-02-25 16:41 ` Ronald S. Bultje
2024-02-25 22:30 ` Henrik Gramner via ffmpeg-devel
2024-02-25 23:00 ` Ronald S. Bultje
2024-02-26 14:26 ` J. Dekker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEEMt2=B2TF550nA6QgSFd+Ng7oRizCGxyZ=ugrmo+FiKCoCUw@mail.gmail.com' \
--to=rsbultje@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git